* [PATCH V2] arm: dts: imx7ulp: fix reg of cpu node
@ 2019-12-18 12:22 Peng Fan
2019-12-18 12:44 ` Fabio Estevam
2019-12-23 7:43 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Peng Fan @ 2019-12-18 12:22 UTC (permalink / raw)
To: robh+dt, mark.rutland, shawnguo, kernel, festevam, baruch
Cc: dl-linux-imx, Aisheng Dong, devicetree, linux-arm-kernel,
linux-kernel, Alice Guo, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
According to arm cpus binding doc,
"
On 32-bit ARM v7 or later systems this property is
required and matches the CPU MPIDR[23:0] register
bits.
Bits [23:0] in the reg cell must be set to
bits [23:0] in MPIDR.
All other bits in the reg cell must be set to 0.
"
In i.MX7ULP, the MPIDR[23:0] is 0xf00, not 0, so fix it.
Otherwise there will be warning:
"DT missing boot CPU MPIDR[23:0], fall back to default cpu_logical_map"
Fixes: 20434dc92c05 ("ARM: dts: imx: add common imx7ulp dtsi support")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V2:
Fix suffix, from 0 -> f00
arch/arm/boot/dts/imx7ulp.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
index d37a1927c88e..ab91c98f2124 100644
--- a/arch/arm/boot/dts/imx7ulp.dtsi
+++ b/arch/arm/boot/dts/imx7ulp.dtsi
@@ -37,10 +37,10 @@
#address-cells = <1>;
#size-cells = <0>;
- cpu0: cpu@0 {
+ cpu0: cpu@f00 {
compatible = "arm,cortex-a7";
device_type = "cpu";
- reg = <0>;
+ reg = <0xf00>;
};
};
--
2.16.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] arm: dts: imx7ulp: fix reg of cpu node
2019-12-18 12:22 [PATCH V2] arm: dts: imx7ulp: fix reg of cpu node Peng Fan
@ 2019-12-18 12:44 ` Fabio Estevam
2019-12-23 7:43 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2019-12-18 12:44 UTC (permalink / raw)
To: Peng Fan
Cc: robh+dt, mark.rutland, shawnguo, kernel, baruch, dl-linux-imx,
Aisheng Dong, devicetree, linux-arm-kernel, linux-kernel,
Alice Guo
On Wed, Dec 18, 2019 at 9:22 AM Peng Fan <peng.fan@nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> According to arm cpus binding doc,
> "
> On 32-bit ARM v7 or later systems this property is
> required and matches the CPU MPIDR[23:0] register
> bits.
>
> Bits [23:0] in the reg cell must be set to
> bits [23:0] in MPIDR.
>
> All other bits in the reg cell must be set to 0.
> "
>
> In i.MX7ULP, the MPIDR[23:0] is 0xf00, not 0, so fix it.
> Otherwise there will be warning:
> "DT missing boot CPU MPIDR[23:0], fall back to default cpu_logical_map"
>
> Fixes: 20434dc92c05 ("ARM: dts: imx: add common imx7ulp dtsi support")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] arm: dts: imx7ulp: fix reg of cpu node
2019-12-18 12:22 [PATCH V2] arm: dts: imx7ulp: fix reg of cpu node Peng Fan
2019-12-18 12:44 ` Fabio Estevam
@ 2019-12-23 7:43 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2019-12-23 7:43 UTC (permalink / raw)
To: Peng Fan
Cc: robh+dt, mark.rutland, kernel, festevam, baruch, dl-linux-imx,
Aisheng Dong, devicetree, linux-arm-kernel, linux-kernel,
Alice Guo
On Wed, Dec 18, 2019 at 12:22:32PM +0000, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> According to arm cpus binding doc,
> "
> On 32-bit ARM v7 or later systems this property is
> required and matches the CPU MPIDR[23:0] register
> bits.
>
> Bits [23:0] in the reg cell must be set to
> bits [23:0] in MPIDR.
>
> All other bits in the reg cell must be set to 0.
> "
>
> In i.MX7ULP, the MPIDR[23:0] is 0xf00, not 0, so fix it.
> Otherwise there will be warning:
> "DT missing boot CPU MPIDR[23:0], fall back to default cpu_logical_map"
>
> Fixes: 20434dc92c05 ("ARM: dts: imx: add common imx7ulp dtsi support")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
For arm32 DTS patches, we use 'ARM: ...' prefix. Fixed it up and
applied.
Shawn
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-23 7:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 12:22 [PATCH V2] arm: dts: imx7ulp: fix reg of cpu node Peng Fan
2019-12-18 12:44 ` Fabio Estevam
2019-12-23 7:43 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).