* [PATCH] soc: imx: add PM dependency for IMX7_PM_DOMAINS
@ 2017-05-11 11:37 Arnd Bergmann
2017-05-11 11:39 ` Fabio Estevam
2017-05-12 3:51 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-05-11 11:37 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer
Cc: Arnd Bergmann, Fabio Estevam, Andrey Smirnov, linux-arm-kernel,
linux-kernel
The new pm domain driver causes a build failure when CONFIG_PM
is not set:
warning: (IMX7_PM_DOMAINS) selects PM_GENERIC_DOMAINS which has unmet direct dependencies (PM)
drivers/base/power/domain_governor.c: In function 'default_suspend_ok':
drivers/base/power/domain_governor.c:75:17: error: 'struct dev_pm_info' has no member named 'ignore_children'
This adds a dependency to ensure that we don't attempt to build the
driver without CONFIG_PM.
Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/soc/imx/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
index 357a5d8f8da0..a5b86a28f343 100644
--- a/drivers/soc/imx/Kconfig
+++ b/drivers/soc/imx/Kconfig
@@ -2,8 +2,9 @@ menu "i.MX SoC drivers"
config IMX7_PM_DOMAINS
bool "i.MX7 PM domains"
- select PM_GENERIC_DOMAINS
depends on SOC_IMX7D || (COMPILE_TEST && OF)
+ depends on PM
+ select PM_GENERIC_DOMAINS
default y if SOC_IMX7D
endmenu
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: imx: add PM dependency for IMX7_PM_DOMAINS
2017-05-11 11:37 [PATCH] soc: imx: add PM dependency for IMX7_PM_DOMAINS Arnd Bergmann
@ 2017-05-11 11:39 ` Fabio Estevam
2017-05-12 3:51 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2017-05-11 11:39 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Shawn Guo, Sascha Hauer, Fabio Estevam, Andrey Smirnov,
linux-arm-kernel, linux-kernel
On Thu, May 11, 2017 at 8:37 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The new pm domain driver causes a build failure when CONFIG_PM
> is not set:
>
> warning: (IMX7_PM_DOMAINS) selects PM_GENERIC_DOMAINS which has unmet direct dependencies (PM)
> drivers/base/power/domain_governor.c: In function 'default_suspend_ok':
> drivers/base/power/domain_governor.c:75:17: error: 'struct dev_pm_info' has no member named 'ignore_children'
>
> This adds a dependency to ensure that we don't attempt to build the
> driver without CONFIG_PM.
>
> Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: imx: add PM dependency for IMX7_PM_DOMAINS
2017-05-11 11:37 [PATCH] soc: imx: add PM dependency for IMX7_PM_DOMAINS Arnd Bergmann
2017-05-11 11:39 ` Fabio Estevam
@ 2017-05-12 3:51 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2017-05-12 3:51 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Sascha Hauer, Fabio Estevam, Andrey Smirnov, linux-arm-kernel,
linux-kernel
On Thu, May 11, 2017 at 01:37:47PM +0200, Arnd Bergmann wrote:
> The new pm domain driver causes a build failure when CONFIG_PM
> is not set:
>
> warning: (IMX7_PM_DOMAINS) selects PM_GENERIC_DOMAINS which has unmet direct dependencies (PM)
> drivers/base/power/domain_governor.c: In function 'default_suspend_ok':
> drivers/base/power/domain_governor.c:75:17: error: 'struct dev_pm_info' has no member named 'ignore_children'
>
> This adds a dependency to ensure that we don't attempt to build the
> driver without CONFIG_PM.
>
> Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-12 3:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-11 11:37 [PATCH] soc: imx: add PM dependency for IMX7_PM_DOMAINS Arnd Bergmann
2017-05-11 11:39 ` Fabio Estevam
2017-05-12 3:51 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).