From: Fabio Estevam <festevam@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Timur Tabi <timur@tabi.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Geliang Tang <geliangtang@163.com>,
moderated for non-subscribers <alsa-devel@alsa-project.org>,
LKML <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: fsl: fix fsl_spdif.c build errors
Date: Sun, 6 Nov 2016 17:43:53 -0200 [thread overview]
Message-ID: <CAOMZO5DPP7suoCzSjkSzCugiC-nCNcLL8Xn68QdgaC3M9P_=cA@mail.gmail.com> (raw)
In-Reply-To: <7ea1cd5a-9215-18ed-2412-b6860a0b708f@infradead.org>
Hi Randy,
On Sat, Nov 5, 2016 at 9:16 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors in sound/soc/fsl/fsl_spdif.c by selecting BITREVERSE.
> Fixes these build errors:
Care to explain why the error is happening?
> sound/built-in.o: In function `spdif_write_channel_status':
> fsl_spdif.c:(.text+0xbe39d): undefined reference to `byte_rev_table'
> fsl_spdif.c:(.text+0xbe3a8): undefined reference to `byte_rev_table'
> fsl_spdif.c:(.text+0xbe3be): undefined reference to `byte_rev_table'
> fsl_spdif.c:(.text+0xbe3d8): undefined reference to `byte_rev_table'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Applies-to: all 3.x, all 4.x
Not sure if this last line is correct. The kbuild report says this
error starts to happen with:
commit: 8cfc8ddc99df9509a46043b14af81f5c6a223eab pstore: add lzo/lz4
compression support
on a x86_64 randconfig.
Also, why only SND_SOC_FSL_SPDIF needs to have BITREVERSE selected?
next prev parent reply other threads:[~2016-11-06 19:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-05 23:16 [PATCH] ASoC: fsl: fix fsl_spdif.c build errors Randy Dunlap
2016-11-06 19:43 ` Fabio Estevam [this message]
2016-11-06 21:40 ` [alsa-devel] " Randy Dunlap
2016-11-06 22:05 ` Fabio Estevam
2016-11-08 21:38 ` Kees Cook
2016-11-09 14:59 ` Applied "ASoC: fsl: fix fsl_spdif.c build errors" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5DPP7suoCzSjkSzCugiC-nCNcLL8Xn68QdgaC3M9P_=cA@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=geliangtang@163.com \
--cc=keescook@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=rdunlap@infradead.org \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).