linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: imx7ulp: Correct system clock source option #7
@ 2019-10-11  8:36 Anson Huang
  2019-10-11 11:14 ` Fabio Estevam
  0 siblings, 1 reply; 4+ messages in thread
From: Anson Huang @ 2019-10-11  8:36 UTC (permalink / raw)
  To: mturquette, sboyd, shawnguo, s.hauer, kernel, festevam,
	aisheng.dong, gustavo, linux-clk, linux-arm-kernel, linux-kernel
  Cc: Linux-imx

In the latest reference manual Rev.0,06/2019, the SCG1's system
clock source option #7 is no longer from upll, it is reserved,
update clock driver accordingly.

Fixes: b1260067ac3d ("clk: imx: add imx7ulp clk driver")
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 drivers/clk/imx/clk-imx7ulp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/imx/clk-imx7ulp.c b/drivers/clk/imx/clk-imx7ulp.c
index 2022d9b..b2c5866 100644
--- a/drivers/clk/imx/clk-imx7ulp.c
+++ b/drivers/clk/imx/clk-imx7ulp.c
@@ -24,7 +24,7 @@ static const char * const spll_pfd_sels[]	= { "spll_pfd0", "spll_pfd1", "spll_pf
 static const char * const spll_sels[]		= { "spll", "spll_pfd_sel", };
 static const char * const apll_pfd_sels[]	= { "apll_pfd0", "apll_pfd1", "apll_pfd2", "apll_pfd3", };
 static const char * const apll_sels[]		= { "apll", "apll_pfd_sel", };
-static const char * const scs_sels[]		= { "dummy", "sosc", "sirc", "firc", "dummy", "apll_sel", "spll_sel", "upll", };
+static const char * const scs_sels[]		= { "dummy", "sosc", "sirc", "firc", "dummy", "apll_sel", "spll_sel", "dummy", };
 static const char * const ddr_sels[]		= { "apll_pfd_sel", "upll", };
 static const char * const nic_sels[]		= { "firc", "ddr_clk", };
 static const char * const periph_plat_sels[]	= { "dummy", "nic1_bus_clk", "nic1_clk", "ddr_clk", "apll_pfd2", "apll_pfd1", "apll_pfd0", "upll", };
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] clk: imx7ulp: Correct system clock source option #7
  2019-10-11  8:36 [PATCH] clk: imx7ulp: Correct system clock source option #7 Anson Huang
@ 2019-10-11 11:14 ` Fabio Estevam
  2019-10-12  1:05   ` Anson Huang
  0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2019-10-11 11:14 UTC (permalink / raw)
  To: Anson Huang
  Cc: Michael Turquette, Stephen Boyd, Shawn Guo, Sascha Hauer,
	Sascha Hauer, Dong Aisheng, Gustavo A. R. Silva, linux-clk,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel, NXP Linux Team

On Fri, Oct 11, 2019 at 5:39 AM Anson Huang <Anson.Huang@nxp.com> wrote:
>
> In the latest reference manual Rev.0,06/2019, the SCG1's system

This should be SCS instead of SCG1.

> clock source option #7 is no longer from upll, it is reserved,
> update clock driver accordingly.
>
> Fixes: b1260067ac3d ("clk: imx: add imx7ulp clk driver")
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [PATCH] clk: imx7ulp: Correct system clock source option #7
  2019-10-11 11:14 ` Fabio Estevam
@ 2019-10-12  1:05   ` Anson Huang
  2019-10-12 12:43     ` Fabio Estevam
  0 siblings, 1 reply; 4+ messages in thread
From: Anson Huang @ 2019-10-12  1:05 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Michael Turquette, Stephen Boyd, Shawn Guo, Sascha Hauer,
	Sascha Hauer, Aisheng Dong, Gustavo A. R. Silva, linux-clk,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel, dl-linux-imx

Hi, Fabio

> On Fri, Oct 11, 2019 at 5:39 AM Anson Huang <Anson.Huang@nxp.com>
> wrote:
> >
> > In the latest reference manual Rev.0,06/2019, the SCG1's system
> 
> This should be SCS instead of SCG1.

The reference states SCG system clock, SCS stands for system clock source, so I think
it is actually meaning SCG1's system clock source😊 

Selects the SCG system clock.
0000b - Reserved
0001b - System OSC (SOSC_CLK)
0010b - Slow IRC (SIRC_CLK)
0011b - Fast IRC (FIRC_CLK)
0100b - Reserved
0101b - Auxiliary PLL (APLL_CLK)
0110b - System PLL (SPLL_CLK)
0111b - Reserved

> 
> > clock source option #7 is no longer from upll, it is reserved, update
> > clock driver accordingly.
> >
> > Fixes: b1260067ac3d ("clk: imx: add imx7ulp clk driver")
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

Thanks,
Anson

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] clk: imx7ulp: Correct system clock source option #7
  2019-10-12  1:05   ` Anson Huang
@ 2019-10-12 12:43     ` Fabio Estevam
  0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2019-10-12 12:43 UTC (permalink / raw)
  To: Anson Huang
  Cc: Michael Turquette, Stephen Boyd, Shawn Guo, Sascha Hauer,
	Sascha Hauer, Aisheng Dong, Gustavo A. R. Silva, linux-clk,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel, dl-linux-imx

Hi Anson,

On Fri, Oct 11, 2019 at 10:05 PM Anson Huang <anson.huang@nxp.com> wrote:

> The reference states SCG system clock, SCS stands for system clock source, so I think
> it is actually meaning SCG1's system clock source
>
> Selects the SCG system clock.

Yes, SCG is the name used in the Reference Manual and also the driver
calls it scs_sels,
so it would be better to keep consistency and spell SCG in the commit log.

Thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-12 12:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-11  8:36 [PATCH] clk: imx7ulp: Correct system clock source option #7 Anson Huang
2019-10-11 11:14 ` Fabio Estevam
2019-10-12  1:05   ` Anson Huang
2019-10-12 12:43     ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).