From: Fabio Estevam <festevam@gmail.com>
To: Zidan Wang <b50113@freescale.com>
Cc: Mark Brown <broonie@kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Takashi Iwai <tiwai@suse.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
patches@opensource.wolfsonmicro.com,
Liam Girdwood <lgirdwood@gmail.com>,
Xiubo Li <Li.Xiubo@freescale.com>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: wm8960: Add shared_lrclk and capless to device tree
Date: Wed, 19 Nov 2014 10:59:51 -0200 [thread overview]
Message-ID: <CAOMZO5DuJpEPALw60yC3kxEbdE_-fAbUG-3L+hZ+Oo1bd=0Kew@mail.gmail.com> (raw)
In-Reply-To: <1416400568-7512-1-git-send-email-b50113@freescale.com>
On Wed, Nov 19, 2014 at 10:36 AM, Zidan Wang <b50113@freescale.com> wrote:
> wm8960 codec has a wm8960_data struct which has two fields shared_lrclk and capless.
> The wm8960_data is get from platform_data and it is reasonable to set it from device
> tree when platform_data is null.
> And when shared_lrclk is set, LRCM will be enabled. But the following software reset
> in wm8960_probe will reset it to the default state. So LRCM operation should after
> software reset.
>
> Signed-off-by: Zidan Wang <b50113@freescale.com>
> ---
> sound/soc/codecs/wm8960.c | 49 ++++++++++++++++++++++++++++++-----------------
I think you could a add
Documentation/devicetree/bindings/sound/wm8960.txt in a separate patch
and document these properties there.
next prev parent reply other threads:[~2014-11-19 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 12:36 [alsa-devel][PATCH] ASoC: wm8960: Add shared_lrclk and capless to device tree Zidan Wang
2014-11-19 12:59 ` Fabio Estevam [this message]
2014-11-19 17:48 ` Mark Brown
2014-11-19 17:51 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5DuJpEPALw60yC3kxEbdE_-fAbUG-3L+hZ+Oo1bd=0Kew@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=b50113@freescale.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).