LKML Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build warning after merge of the spi tree
@ 2020-01-15  2:23 Stephen Rothwell
  2020-01-15  9:10 ` Jean Pihet
  0 siblings, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2020-01-15  2:23 UTC (permalink / raw)
  To: Mark Brown; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jean Pihet

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

Hi all,

After merging the spi tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/spi/spi-ti-qspi.c: In function 'ti_qspi_start_transfer_one':
drivers/spi/spi-ti-qspi.c:392:8: warning: 'rx_wlen' may be used uninitialized in this function [-Wmaybe-uninitialized]
  392 |     if (rx_wlen >= 32)
      |        ^
drivers/spi/spi-ti-qspi.c:318:12: note: 'rx_wlen' was declared here
  318 |  u8 rxlen, rx_wlen;
      |            ^~~~~~~

Introduced by commit

  e7cc5cfbea4c ("spi: spi-ti-qspi: optimize byte-transfers")

Looks like it may be a false positive.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: linux-next: build warning after merge of the spi tree
  2020-01-15  2:23 linux-next: build warning after merge of the spi tree Stephen Rothwell
@ 2020-01-15  9:10 ` Jean Pihet
  2020-01-15 10:27   ` Stephen Rothwell
  0 siblings, 1 reply; 19+ messages in thread
From: Jean Pihet @ 2020-01-15  9:10 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Linux Next Mailing List, Linux Kernel Mailing List

Hi Stephen,

I did not have this warning, it may be a combination of compiler
version and build flags. Do you need a fixup patch for it?

Thanks,
Jean

On Wed, Jan 15, 2020 at 3:23 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the spi tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> drivers/spi/spi-ti-qspi.c: In function 'ti_qspi_start_transfer_one':
> drivers/spi/spi-ti-qspi.c:392:8: warning: 'rx_wlen' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   392 |     if (rx_wlen >= 32)
>       |        ^
> drivers/spi/spi-ti-qspi.c:318:12: note: 'rx_wlen' was declared here
>   318 |  u8 rxlen, rx_wlen;
>       |            ^~~~~~~
>
> Introduced by commit
>
>   e7cc5cfbea4c ("spi: spi-ti-qspi: optimize byte-transfers")
>
> Looks like it may be a false positive.
>
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: linux-next: build warning after merge of the spi tree
  2020-01-15  9:10 ` Jean Pihet
@ 2020-01-15 10:27   ` Stephen Rothwell
  2020-01-15 11:38     ` Jean Pihet
  0 siblings, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2020-01-15 10:27 UTC (permalink / raw)
  To: Jean Pihet; +Cc: Mark Brown, Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

Hi Jean,

On Wed, 15 Jan 2020 10:10:09 +0100 Jean Pihet <jean.pihet@newoldbits.com> wrote:
>
> I did not have this warning, it may be a combination of compiler
> version and build flags. Do you need a fixup patch for it?

That is up to Mark, really.  Unfortunately, Linus will probably get
this warning during the merge window which he will complain about.

It is really weird, as there are three other references to rx_wlen
immediately before the one complained about ... so maybe this is a bug
in the compiler I am using (gcc 9.2.1 from Debian, cross compiler
ppc64le hosted).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: linux-next: build warning after merge of the spi tree
  2020-01-15 10:27   ` Stephen Rothwell
@ 2020-01-15 11:38     ` Jean Pihet
  0 siblings, 0 replies; 19+ messages in thread
From: Jean Pihet @ 2020-01-15 11:38 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Linux Next Mailing List, Linux Kernel Mailing List

Stephen,

On Wed, Jan 15, 2020 at 11:28 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Jean,
>
> On Wed, 15 Jan 2020 10:10:09 +0100 Jean Pihet <jean.pihet@newoldbits.com> wrote:
> >
> > I did not have this warning, it may be a combination of compiler
> > version and build flags. Do you need a fixup patch for it?
>
> That is up to Mark, really.  Unfortunately, Linus will probably get
> this warning during the merge window which he will complain about.

Ok I just sent a fixup patch to Mark (on spi ML). Could it still reach 5.6?

>
> It is really weird, as there are three other references to rx_wlen
> immediately before the one complained about ... so maybe this is a bug
> in the compiler I am using (gcc 9.2.1 from Debian, cross compiler
> ppc64le hosted).
Yes indeed it is weird. Only some compiler versions are throwing the warning.

Thanks,
Jean

>
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 19+ messages in thread

* linux-next: build warning after merge of the spi tree
@ 2019-04-29  4:30 Stephen Rothwell
  0 siblings, 0 replies; 19+ messages in thread
From: Stephen Rothwell @ 2019-04-29  4:30 UTC (permalink / raw)
  To: Mark Brown
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Linus Walleij

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

Hi Mark,

After merging the spi tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/spi/spi-ep93xx.c: In function 'ep93xx_spi_probe':
drivers/spi/spi-ep93xx.c:654:6: warning: unused variable 'i' [-Wunused-variable]
  int i;
      ^

Introduced by commit

  06a391b1621e ("spi: ep93xx: Convert to use CS GPIO descriptors")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* RE: linux-next: build warning after merge of the spi tree
  2019-01-29  8:26   ` Stephen Rothwell
@ 2019-01-29  8:39     ` Yogesh Narayan Gaur
  0 siblings, 0 replies; 19+ messages in thread
From: Yogesh Narayan Gaur @ 2019-01-29  8:39 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Linux Next Mailing List, Linux Kernel Mailing List,
	Frieder Schrempf, Boris Brezillon

Hi Stephen,

> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: Tuesday, January 29, 2019 1:57 PM
> To: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>
> Cc: Mark Brown <broonie@kernel.org>; Linux Next Mailing List <linux-
> next@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>;
> Frieder Schrempf <frieder.schrempf@kontron.de>; Boris Brezillon
> <bbrezillon@kernel.org>
> Subject: Re: linux-next: build warning after merge of the spi tree
> 
> Hi Yogesh,
> 
> On Tue, 29 Jan 2019 06:57:51 +0000 Yogesh Narayan Gaur
> <yogeshnarayan.gaur@nxp.com> wrote:
> >
> > > WARNING: modpost: missing MODULE_LICENSE() in
> > > drivers/spi/spi-nxp-fspi.o see include/linux/module.h for more
> > > information
> > >
> > Can someone help in pointing out that why above warning message is coming
> for mentioned commit.
> > Below MODULE_LICENSE string is present in the above mentioned file,
> drivers/spi/spi-nxp-fspi.c.
> >     MODULE_LICENSE("GPL v2");
> 
> The version in linux-next has no such line.
> 
Yes, somehow this missing line was appended to the commit message instead of the actual in patchwork, also being pointed out by Frieder in his reply.
Sorry for this.

I have send fix patch for this warning message [1]. Please check the patch and apply.

--
Regards,
Yogesh Gaur

[1] https://patchwork.ozlabs.org/patch/1032586/

> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: linux-next: build warning after merge of the spi tree
  2019-01-29  6:57 ` Yogesh Narayan Gaur
  2019-01-29  7:25   ` Schrempf Frieder
@ 2019-01-29  8:26   ` Stephen Rothwell
  2019-01-29  8:39     ` Yogesh Narayan Gaur
  1 sibling, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2019-01-29  8:26 UTC (permalink / raw)
  To: Yogesh Narayan Gaur
  Cc: Mark Brown, Linux Next Mailing List, Linux Kernel Mailing List,
	Frieder Schrempf, Boris Brezillon

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

Hi Yogesh,

On Tue, 29 Jan 2019 06:57:51 +0000 Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> wrote:
>
> > WARNING: modpost: missing MODULE_LICENSE() in drivers/spi/spi-nxp-fspi.o
> > see include/linux/module.h for more information
> >   
> Can someone help in pointing out that why above warning message is coming for mentioned commit.
> Below MODULE_LICENSE string is present in the above mentioned file, drivers/spi/spi-nxp-fspi.c.
>     MODULE_LICENSE("GPL v2");

The version in linux-next has no such line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: linux-next: build warning after merge of the spi tree
  2019-01-29  6:57 ` Yogesh Narayan Gaur
@ 2019-01-29  7:25   ` Schrempf Frieder
  2019-01-29  8:26   ` Stephen Rothwell
  1 sibling, 0 replies; 19+ messages in thread
From: Schrempf Frieder @ 2019-01-29  7:25 UTC (permalink / raw)
  To: Yogesh Narayan Gaur, Stephen Rothwell, Mark Brown
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Boris Brezillon

On 29.01.19 07:57, Yogesh Narayan Gaur wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
>> Sent: Tuesday, January 29, 2019 7:33 AM
>> To: Mark Brown <broonie@kernel.org>
>> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing
>> List <linux-kernel@vger.kernel.org>; Yogesh Narayan Gaur
>> <yogeshnarayan.gaur@nxp.com>; Frieder Schrempf
>> <frieder.schrempf@kontron.de>; Boris Brezillon <bbrezillon@kernel.org>;
>> Ashish Kumar <ashish.kumar@nxp.com>
>> Subject: linux-next: build warning after merge of the spi tree
>>
>> Hi all,
>>
>> After merging the spi tree, today's linux-next build (KCONFIG_NAME) produced
>> this warning:
>>
>> WARNING: modpost: missing MODULE_LICENSE() in drivers/spi/spi-nxp-fspi.o
>> see include/linux/module.h for more information
>>
> Can someone help in pointing out that why above warning message is coming for mentioned commit.
> Below MODULE_LICENSE string is present in the above mentioned file, drivers/spi/spi-nxp-fspi.c.
>      MODULE_LICENSE("GPL v2");

No, it is not present. Look at your patches [1] or at spi-next [2]. 
MODULE_LICENSE is definitely missing.

In patchwork the missing line was appended to the commit message instead 
of the actual patch for some reason.

[1] https://patchwork.kernel.org/patch/10764347/
[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/commit/?h=for-next&id=a5356aef6a907c2e2aed0caaa2b88b6021394471

^ permalink raw reply	[flat|nested] 19+ messages in thread

* RE: linux-next: build warning after merge of the spi tree
  2019-01-29  2:02 Stephen Rothwell
@ 2019-01-29  6:57 ` Yogesh Narayan Gaur
  2019-01-29  7:25   ` Schrempf Frieder
  2019-01-29  8:26   ` Stephen Rothwell
  0 siblings, 2 replies; 19+ messages in thread
From: Yogesh Narayan Gaur @ 2019-01-29  6:57 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Frieder Schrempf, Boris Brezillon

Hi,

> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: Tuesday, January 29, 2019 7:33 AM
> To: Mark Brown <broonie@kernel.org>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing
> List <linux-kernel@vger.kernel.org>; Yogesh Narayan Gaur
> <yogeshnarayan.gaur@nxp.com>; Frieder Schrempf
> <frieder.schrempf@kontron.de>; Boris Brezillon <bbrezillon@kernel.org>;
> Ashish Kumar <ashish.kumar@nxp.com>
> Subject: linux-next: build warning after merge of the spi tree
> 
> Hi all,
> 
> After merging the spi tree, today's linux-next build (KCONFIG_NAME) produced
> this warning:
> 
> WARNING: modpost: missing MODULE_LICENSE() in drivers/spi/spi-nxp-fspi.o
> see include/linux/module.h for more information
> 
Can someone help in pointing out that why above warning message is coming for mentioned commit.
Below MODULE_LICENSE string is present in the above mentioned file, drivers/spi/spi-nxp-fspi.c.
    MODULE_LICENSE("GPL v2");

--
Regards,
Yogesh Gaur
> Introduced by commit
> 
>   a5356aef6a90 ("spi: spi-mem: Add driver for NXP FlexSPI controller")
> 
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 19+ messages in thread

* linux-next: build warning after merge of the spi tree
@ 2019-01-29  2:02 Stephen Rothwell
  2019-01-29  6:57 ` Yogesh Narayan Gaur
  0 siblings, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2019-01-29  2:02 UTC (permalink / raw)
  To: Mark Brown
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Yogesh Narayan Gaur, Frieder Schrempf, Boris Brezillon,
	Ashish Kumar

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

Hi all,

After merging the spi tree, today's linux-next build (KCONFIG_NAME)
produced this warning:

WARNING: modpost: missing MODULE_LICENSE() in drivers/spi/spi-nxp-fspi.o
see include/linux/module.h for more information

Introduced by commit

  a5356aef6a90 ("spi: spi-mem: Add driver for NXP FlexSPI controller")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* linux-next: build warning after merge of the spi tree
@ 2019-01-10  0:44 Stephen Rothwell
  0 siblings, 0 replies; 19+ messages in thread
From: Stephen Rothwell @ 2019-01-10  0:44 UTC (permalink / raw)
  To: Mark Brown
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Linus Walleij

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi Mark,

After merging the spi tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/spi/spi-dw.c: In function 'dw_spi_setup':
drivers/spi/spi-dw.c:400:6: warning: unused variable 'ret' [-Wunused-variable]
  int ret;
      ^~~

Introduced by commit

  9400c41e77b8 ("spi: dw: Convert to use CS GPIO descriptors")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* linux-next: build warning after merge of the spi tree
@ 2019-01-10  0:41 Stephen Rothwell
  0 siblings, 0 replies; 19+ messages in thread
From: Stephen Rothwell @ 2019-01-10  0:41 UTC (permalink / raw)
  To: Mark Brown
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Linus Walleij

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

Hi Mark,

After merging the spi tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/spi/spi-davinci.c: In function 'davinci_spi_setup':
drivers/spi/spi-davinci.c:426:21: warning: unused variable 'master' [-Wunused-variable]
  struct spi_master *master = spi->master;
                     ^~~~~~

Introduced by commit

  101a68e74fe0 ("spi: davinci: Convert to use CS GPIO descriptors")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: linux-next: build warning after merge of the spi tree
       [not found] ` <CAP6Zq1gp+hmNkvk8D2uv8FUqTXE4+ZMPhMB7A7vLMaM6swHy4g@mail.gmail.com>
@ 2018-11-15 19:26   ` Mark Brown
  0 siblings, 0 replies; 19+ messages in thread
From: Mark Brown @ 2018-11-15 19:26 UTC (permalink / raw)
  To: Tomer Maimon; +Cc: sfr, linux-next, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 693 bytes --]

On Thu, Nov 15, 2018 at 05:56:19PM +0200, Tomer Maimon wrote:
> Hi Mark and Stephen,
> 
> I saw the warning from the kbuilt, in this matter the ioread() function
> will call every time (and the val parameter will used) because rsize can be
> 1 or 2.
> 
> rsize = min(bytes_per_word(priv->bits_per_word), priv->rx_bytes);
> bytes_per_word(priv->bits_per_word)function return 1 or 2.
> npcm_pspi_recv()function will called only if parameter priv->rx_bytes is
> not 0.
> 
> please let me know if you think that I still need to modify the npcm_pspi_recv
> to fix kbuilt warning.

Please, it's going to create noise for people working on the kernel if
they get a spurious warning.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* linux-next: build warning after merge of the spi tree
@ 2018-11-14  2:18 Stephen Rothwell
       [not found] ` <CAP6Zq1gp+hmNkvk8D2uv8FUqTXE4+ZMPhMB7A7vLMaM6swHy4g@mail.gmail.com>
  0 siblings, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2018-11-14  2:18 UTC (permalink / raw)
  To: Mark Brown
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Tomer Maimon

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

Hi Mark,

After merging the spi tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/spi/spi-npcm-pspi.c: In function 'npcm_pspi_recv':
drivers/spi/spi-npcm-pspi.c:226:17: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
   *priv->rx_buf = val;
   ~~~~~~~~~~~~~~^~~~~

Introduced by commit

  2a22f1b30cee ("spi: npcm: add NPCM PSPI controller driver")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* linux-next: build warning after merge of the spi tree
@ 2018-08-03  4:37 Stephen Rothwell
  0 siblings, 0 replies; 19+ messages in thread
From: Stephen Rothwell @ 2018-08-03  4:37 UTC (permalink / raw)
  To: Mark Brown
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Frieder Schrempf, Boris Brezillon

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]

Hi Mark,

After merging the spi tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/spi/spi-mem.c: In function 'spi_mem_probe':
drivers/spi/spi-mem.c:375:13: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   mem->name = ctlr->mem_ops->get_name(mem);
             ^
drivers/spi/spi-mem.c:377:13: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   mem->name = dev_name(&spi->dev);
             ^

Introduced by commit

  5d27a9c8ea9e ("spi: spi-mem: Extend the SPI mem interface to set a custom memory name")

"const" is good :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: linux-next: build warning after merge of the spi tree
  2017-03-27  2:41 Stephen Rothwell
@ 2017-03-27  5:33 ` Vignesh R
  0 siblings, 0 replies; 19+ messages in thread
From: Vignesh R @ 2017-03-27  5:33 UTC (permalink / raw)
  To: Mark Brown; +Cc: Stephen Rothwell, linux-next, linux-kernel



On Monday 27 March 2017 08:11 AM, Stephen Rothwell wrote:
> Hi Mark,
> 
> After merging the spi tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/spi/spi-ti-qspi.c: In function 'ti_qspi_dma_xfer':
> drivers/spi/spi-ti-qspi.c:398:21: warning: unused variable 'dma_dev' [-Wunused-variable]
>   struct dma_device *dma_dev = chan->device;
>                      ^
> 
> Introduced by commit
> 
>   1351aaeb50b2 ("spi: spi-ti-qspi: Use dma_engine wrapper for dma memcpy call")
> 

Sorry, I have posted a fix for the same.

-- 
Regards
Vignesh

^ permalink raw reply	[flat|nested] 19+ messages in thread

* linux-next: build warning after merge of the spi tree
@ 2017-03-27  2:41 Stephen Rothwell
  2017-03-27  5:33 ` Vignesh R
  0 siblings, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2017-03-27  2:41 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-next, linux-kernel, Vignesh R

Hi Mark,

After merging the spi tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/spi/spi-ti-qspi.c: In function 'ti_qspi_dma_xfer':
drivers/spi/spi-ti-qspi.c:398:21: warning: unused variable 'dma_dev' [-Wunused-variable]
  struct dma_device *dma_dev = chan->device;
                     ^

Introduced by commit

  1351aaeb50b2 ("spi: spi-ti-qspi: Use dma_engine wrapper for dma memcpy call")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: linux-next: build warning after merge of the spi tree
  2010-10-14  1:59 Stephen Rothwell
@ 2010-10-14  5:00 ` Grant Likely
  0 siblings, 0 replies; 19+ messages in thread
From: Grant Likely @ 2010-10-14  5:00 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Masayuki Ohtake

On Thu, Oct 14, 2010 at 12:59:52PM +1100, Stephen Rothwell wrote:
> Hi Grant,
> 
> After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/spi/spi_topcliff_pch.c: In function 'pch_spi_process_messages':
> drivers/spi/spi_topcliff_pch.c:752: warning: 'data' is used uninitialized in this function
> 
> and, indeed it is ...

Oops, so it is.  I messed that up in the refactoring patch.
Fortunately this is a new driver so it is not a regression.  I'll push
out the fix this evening.

g.



^ permalink raw reply	[flat|nested] 19+ messages in thread

* linux-next: build warning after merge of the spi tree
@ 2010-10-14  1:59 Stephen Rothwell
  2010-10-14  5:00 ` Grant Likely
  0 siblings, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2010-10-14  1:59 UTC (permalink / raw)
  To: Grant Likely; +Cc: linux-next, linux-kernel, Masayuki Ohtake

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi Grant,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/spi/spi_topcliff_pch.c: In function 'pch_spi_process_messages':
drivers/spi/spi_topcliff_pch.c:752: warning: 'data' is used uninitialized in this function

and, indeed it is ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, back to index

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-15  2:23 linux-next: build warning after merge of the spi tree Stephen Rothwell
2020-01-15  9:10 ` Jean Pihet
2020-01-15 10:27   ` Stephen Rothwell
2020-01-15 11:38     ` Jean Pihet
  -- strict thread matches above, loose matches on Subject: below --
2019-04-29  4:30 Stephen Rothwell
2019-01-29  2:02 Stephen Rothwell
2019-01-29  6:57 ` Yogesh Narayan Gaur
2019-01-29  7:25   ` Schrempf Frieder
2019-01-29  8:26   ` Stephen Rothwell
2019-01-29  8:39     ` Yogesh Narayan Gaur
2019-01-10  0:44 Stephen Rothwell
2019-01-10  0:41 Stephen Rothwell
2018-11-14  2:18 Stephen Rothwell
     [not found] ` <CAP6Zq1gp+hmNkvk8D2uv8FUqTXE4+ZMPhMB7A7vLMaM6swHy4g@mail.gmail.com>
2018-11-15 19:26   ` Mark Brown
2018-08-03  4:37 Stephen Rothwell
2017-03-27  2:41 Stephen Rothwell
2017-03-27  5:33 ` Vignesh R
2010-10-14  1:59 Stephen Rothwell
2010-10-14  5:00 ` Grant Likely

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git