linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/papr_scm: Delete unnecessary assignment for the field “owner”
@ 2019-11-03 12:31 Markus Elfring
  2019-11-03 23:06 ` Oliver O'Halloran
  2019-11-04 10:57 ` Vaibhav Jain
  0 siblings, 2 replies; 3+ messages in thread
From: Markus Elfring @ 2019-11-03 12:31 UTC (permalink / raw)
  To: linuxppc-dev, Aneesh Kumar K.V, Benjamin Herrenschmidt,
	Dan Williams, Michael Ellerman, Oliver O'Halloran,
	Paul Mackerras, Vaibhav Jain
  Cc: LKML, kernel-janitors

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 3 Nov 2019 13:23:13 +0100

The field “owner” is set by the core.
Thus delete an unneeded initialisation.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/powerpc/platforms/pseries/papr_scm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
index ee07d0718bf1..f87b474d25a7 100644
--- a/arch/powerpc/platforms/pseries/papr_scm.c
+++ b/arch/powerpc/platforms/pseries/papr_scm.c
@@ -513,7 +513,6 @@ static struct platform_driver papr_scm_driver = {
 	.remove = papr_scm_remove,
 	.driver = {
 		.name = "papr_scm",
-		.owner = THIS_MODULE,
 		.of_match_table = papr_scm_match,
 	},
 };
--
2.23.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] powerpc/papr_scm: Delete unnecessary assignment for the field “owner”
  2019-11-03 12:31 [PATCH] powerpc/papr_scm: Delete unnecessary assignment for the field “owner” Markus Elfring
@ 2019-11-03 23:06 ` Oliver O'Halloran
  2019-11-04 10:57 ` Vaibhav Jain
  1 sibling, 0 replies; 3+ messages in thread
From: Oliver O'Halloran @ 2019-11-03 23:06 UTC (permalink / raw)
  To: Markus Elfring
  Cc: linuxppc-dev, Aneesh Kumar K.V, Benjamin Herrenschmidt,
	Dan Williams, Michael Ellerman, Paul Mackerras, Vaibhav Jain,
	LKML, kernel-janitors

On Sun, Nov 3, 2019 at 11:31 PM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 3 Nov 2019 13:23:13 +0100
>
> The field “owner” is set by the core.
> Thus delete an unneeded initialisation.

Acked-by: Oliver O'Halloran <oohall@gmail.com>

>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  arch/powerpc/platforms/pseries/papr_scm.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
> index ee07d0718bf1..f87b474d25a7 100644
> --- a/arch/powerpc/platforms/pseries/papr_scm.c
> +++ b/arch/powerpc/platforms/pseries/papr_scm.c
> @@ -513,7 +513,6 @@ static struct platform_driver papr_scm_driver = {
>         .remove = papr_scm_remove,
>         .driver = {
>                 .name = "papr_scm",
> -               .owner = THIS_MODULE,
>                 .of_match_table = papr_scm_match,
>         },
>  };
> --
> 2.23.0
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] powerpc/papr_scm: Delete unnecessary assignment for the field “owner”
  2019-11-03 12:31 [PATCH] powerpc/papr_scm: Delete unnecessary assignment for the field “owner” Markus Elfring
  2019-11-03 23:06 ` Oliver O'Halloran
@ 2019-11-04 10:57 ` Vaibhav Jain
  1 sibling, 0 replies; 3+ messages in thread
From: Vaibhav Jain @ 2019-11-04 10:57 UTC (permalink / raw)
  To: Markus Elfring, linuxppc-dev, Aneesh Kumar K.V,
	Benjamin Herrenschmidt, Dan Williams, Michael Ellerman,
	Oliver O'Halloran, Paul Mackerras
  Cc: LKML, kernel-janitors

Markus Elfring <Markus.Elfring@web.de> writes:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 3 Nov 2019 13:23:13 +0100
>
> The field “owner” is set by the core.
> Thus delete an unneeded initialisation.
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  arch/powerpc/platforms/pseries/papr_scm.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
> index ee07d0718bf1..f87b474d25a7 100644
> --- a/arch/powerpc/platforms/pseries/papr_scm.c
> +++ b/arch/powerpc/platforms/pseries/papr_scm.c
> @@ -513,7 +513,6 @@ static struct platform_driver papr_scm_driver = {
>  	.remove = papr_scm_remove,
>  	.driver = {
>  		.name = "papr_scm",
> -		.owner = THIS_MODULE,
>  		.of_match_table = papr_scm_match,
>  	},
>  };
> --
> 2.23.0
>
LGTM

Acked-by: Vaibhav Jain <vaibhav@linux.ibm.com>

Thanks,
-- 
Vaibhav Jain <vaibhav@linux.ibm.com>
Linux Technology Center, IBM India Pvt. Ltd.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-11-04 10:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-03 12:31 [PATCH] powerpc/papr_scm: Delete unnecessary assignment for the field “owner” Markus Elfring
2019-11-03 23:06 ` Oliver O'Halloran
2019-11-04 10:57 ` Vaibhav Jain

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).