* [PATCH] Fix checkpatch.pl issue.
@ 2012-07-08 8:16 Toshiaki Yamane
2012-07-08 8:36 ` Jan Ceuleers
0 siblings, 1 reply; 3+ messages in thread
From: Toshiaki Yamane @ 2012-07-08 8:16 UTC (permalink / raw)
To: greg; +Cc: sjakub, linux-kernel, Toshiaki Yamane
-printk(KERN_ERR, to pr_err(...
Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
---
drivers/staging/asus_oled/asus_oled.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index 510d796..f63c1d3 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -782,20 +782,20 @@ static int __init asus_oled_init(void)
oled_class = class_create(THIS_MODULE, ASUS_OLED_UNDERSCORE_NAME);
if (IS_ERR(oled_class)) {
- printk(KERN_ERR "Error creating " ASUS_OLED_UNDERSCORE_NAME " class\n");
+ pr_err("Error creating " ASUS_OLED_UNDERSCORE_NAME " class\n");
return PTR_ERR(oled_class);
}
retval = class_create_file(oled_class, &class_attr_version.attr);
if (retval) {
- printk(KERN_ERR "Error creating class version file\n");
+ pr_err("Error creating class version file\n");
goto error;
}
retval = usb_register(&oled_driver);
if (retval) {
- printk(KERN_ERR "usb_register failed. Error number %d\n", retval);
+ pr_err("usb_register failed. Error number %d\n", retval);
goto error;
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix checkpatch.pl issue.
2012-07-08 8:16 [PATCH] Fix checkpatch.pl issue Toshiaki Yamane
@ 2012-07-08 8:36 ` Jan Ceuleers
2012-07-08 9:16 ` yamanetoshi
0 siblings, 1 reply; 3+ messages in thread
From: Jan Ceuleers @ 2012-07-08 8:36 UTC (permalink / raw)
To: Toshiaki Yamane; +Cc: greg, sjakub, linux-kernel
On 07/08/2012 10:16 AM, Toshiaki Yamane wrote:
> -printk(KERN_ERR, to pr_err(...
>
> Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
Hi
I submit that your subject line should be more descriptive. Perhaps
something like the following:
[PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...)
The rest of your commit message could then clarify that this change was
inspired by checkpatch.
HTH, Jan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix checkpatch.pl issue.
2012-07-08 8:36 ` Jan Ceuleers
@ 2012-07-08 9:16 ` yamanetoshi
0 siblings, 0 replies; 3+ messages in thread
From: yamanetoshi @ 2012-07-08 9:16 UTC (permalink / raw)
To: Jan Ceuleers; +Cc: greg, sjakub, linux-kernel
I agree.
On Sun, Jul 8, 2012 at 5:36 PM, Jan Ceuleers <jan.ceuleers@computer.org> wrote:
> On 07/08/2012 10:16 AM, Toshiaki Yamane wrote:
>> -printk(KERN_ERR, to pr_err(...
>>
>> Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
>
> Hi
>
> I submit that your subject line should be more descriptive. Perhaps
> something like the following:
>
> [PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...)
>
> The rest of your commit message could then clarify that this change was
> inspired by checkpatch.
>
> HTH, Jan
--
Regards,
.
.
...
Yamane Toshiaki
yamanetoshi@gmail.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-08 9:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-08 8:16 [PATCH] Fix checkpatch.pl issue Toshiaki Yamane
2012-07-08 8:36 ` Jan Ceuleers
2012-07-08 9:16 ` yamanetoshi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).