linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robert Marko <robimarko@gmail.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: sravanhome@gmail.com, lgirdwood@gmail.com, broonie@kernel.org,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] regulator: mp5416: alphabetically sort header includes
Date: Tue, 7 Jun 2022 14:42:38 +0200	[thread overview]
Message-ID: <CAOX2RU5zUMEVZeScSPV6MvzvxwghECJy1DHDTfW5CFDeyPuE+A@mail.gmail.com> (raw)
In-Reply-To: <a08c5dd0-279d-724a-4836-6e66bfa183e8@wanadoo.fr>

On Sat, 4 Jun 2022 at 17:41, Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> Le 04/06/2022 à 16:56, Robert Marko a écrit :
> > Sort the header include list alphabetically.
> >
> > Signed-off-by: Robert Marko <robimarko@gmail.com>
> > ---
> >   drivers/regulator/mp5416.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/regulator/mp5416.c b/drivers/regulator/mp5416.c
> > index 39cebec0edb6..d8245080df03 100644
> > --- a/drivers/regulator/mp5416.c
> > +++ b/drivers/regulator/mp5416.c
> > @@ -6,14 +6,14 @@
> >   //
> >   // Author: Saravanan Sekar <sravanhome@gmail.com>
> >
> > +#include <linux/err.h>
> > +#include <linux/i2c.h>
> > +#include <linux/init.h>
> >   #include <linux/kernel.h>
>
> Nitpick: it seems that kernel.h is not needed here. (at least it compile
> without it).

Hi,

It also seems to work fine without it, will send a patch to remove it.

Regards,
Robert
>
> CJ
>
> >   #include <linux/module.h>
> > -#include <linux/init.h>
> > -#include <linux/err.h>
> >   #include <linux/platform_device.h>
> >   #include <linux/regmap.h>
> >   #include <linux/regulator/driver.h>
> > -#include <linux/i2c.h>
> >
> >   #define MP5416_REG_CTL0                     0x00
> >   #define MP5416_REG_CTL1                     0x01
>

      reply	other threads:[~2022-06-07 12:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-04 14:56 [PATCH 1/3] regulator: mp5416: alphabetically sort header includes Robert Marko
2022-06-04 14:56 ` [PATCH 2/3] regulator: mp5416: use OF match data Robert Marko
2022-06-04 14:56 ` [PATCH 3/3] regulator: mp5416: add support for MP5496 Robert Marko
2022-06-04 15:41 ` [PATCH 1/3] regulator: mp5416: alphabetically sort header includes Christophe JAILLET
2022-06-07 12:42   ` Robert Marko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOX2RU5zUMEVZeScSPV6MvzvxwghECJy1DHDTfW5CFDeyPuE+A@mail.gmail.com \
    --to=robimarko@gmail.com \
    --cc=broonie@kernel.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sravanhome@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).