linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sumit Semwal <sumit.semwal@linaro.org>
To: Laura Abbott <labbott@redhat.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: android: ion: Bail out upon SIGKILL when allocating memory.
Date: Mon, 1 Jul 2019 19:32:16 +0530	[thread overview]
Message-ID: <CAO_48GHu+c3_AxeMSpWbgwPZx4j7JOd6x5t9Jto7=jjV1xw9HA@mail.gmail.com> (raw)
In-Reply-To: <ceef00e8-819a-c0f0-cbb5-60e60e6631fe@redhat.com>

Hello Tetsuo,

On Mon, 1 Jul 2019 at 17:07, Laura Abbott <labbott@redhat.com> wrote:
>
> On 7/1/19 6:55 AM, Tetsuo Handa wrote:
> > Andrew, can you pick up this patch? No response from Laura Abbott nor Sumit Semwal.
Apologies; it didn't seem to get flitered out for me. I'll re-check my
email filters.
> >
> > On 2019/06/21 18:58, Tetsuo Handa wrote:
> >>  From e0758655727044753399fb4f7c5f3eb25ac5cccd Mon Sep 17 00:00:00 2001
> >> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> >> Date: Fri, 21 Jun 2019 11:22:51 +0900
> >> Subject: [PATCH] staging: android: ion: Bail out upon SIGKILL when allocating memory.
> >>
> >> syzbot found that a thread can stall for minutes inside
> >> ion_system_heap_allocate() after that thread was killed by SIGKILL [1].
> >> Let's check for SIGKILL before doing memory allocation.
> >>
> >> [1] https://syzkaller.appspot.com/bug?id=a0e3436829698d5824231251fad9d8e998f94f5e
> >>
> >> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> >> Reported-by: syzbot <syzbot+8ab2d0f39fb79fe6ca40@syzkaller.appspotmail.com>
> >> ---
> >>   drivers/staging/android/ion/ion_page_pool.c | 3 +++
> >>   1 file changed, 3 insertions(+)
> >>
> >> diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
> >> index fd4995fb676e..f85ec5b16b65 100644
> >> --- a/drivers/staging/android/ion/ion_page_pool.c
> >> +++ b/drivers/staging/android/ion/ion_page_pool.c
> >> @@ -8,11 +8,14 @@
> >>   #include <linux/list.h>
> >>   #include <linux/slab.h>
> >>   #include <linux/swap.h>
> >> +#include <linux/sched/signal.h>
> >>
> >>   #include "ion.h"
> >>
> >>   static inline struct page *ion_page_pool_alloc_pages(struct ion_page_pool *pool)
> >>   {
> >> +    if (fatal_signal_pending(current))
> >> +            return NULL;
> >>      return alloc_pages(pool->gfp_mask, pool->order);
> >>   }
> >>
> >>
> >
>
> Acked-by: Laura Abbott <labbott@redhat.com>
fwiw, Acked-by: Sumit Semwal <sumit.semwal@linaro.org>


-- 
Thanks and regards,

Sumit Semwal
Linaro Consumer Group - Kernel Team Lead
Linaro.org │ Open source software for ARM SoCs

  reply	other threads:[~2019-07-01 14:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12 20:53 INFO: task syz-executor can't die for more than 143 seconds syzbot
2019-06-13  2:53 ` syzbot
2019-06-14 10:16   ` [PATCH] kexec: Bail out upon SIGKILL when allocating memory Tetsuo Handa
2019-07-01 10:52     ` Tetsuo Handa
2019-07-24  2:54     ` Eric Biggers
2019-07-24  3:09       ` Tetsuo Handa
2019-06-21  9:58 ` INFO: task syz-executor can't die for more than 143 seconds Tetsuo Handa
2019-07-01 10:55   ` [PATCH] staging: android: ion: Bail out upon SIGKILL when allocating memory Tetsuo Handa
2019-07-01 11:36     ` Laura Abbott
2019-07-01 14:02       ` Sumit Semwal [this message]
2019-07-01 21:02         ` Tetsuo Handa
2019-07-01 21:21           ` Laura Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAO_48GHu+c3_AxeMSpWbgwPZx4j7JOd6x5t9Jto7=jjV1xw9HA@mail.gmail.com' \
    --to=sumit.semwal@linaro.org \
    --cc=akpm@linux-foundation.org \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).