From: Olof Johansson <olof@lixom.net>
To: Rob Herring <robherring2@gmail.com>
Cc: Ian Campbell <ian.campbell@citrix.com>,
"arm@kernel.org" <arm@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Kumar Gala <galak@codeaurora.org>,
Liviu Dudau <liviu.dudau@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Russell King <linux@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Kristina Martsenko <kristina.martsenko@arm.com>,
Kevin Hilman <khilman@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH v5] dtb: Create a common home for cross-architecture dtsi files.
Date: Sun, 23 Aug 2015 16:52:32 -0700 [thread overview]
Message-ID: <CAOesGMigmaEviCDBAncomkq+uowr18B5FTOmOyBHsNz4p6F6Dw@mail.gmail.com> (raw)
In-Reply-To: <CAL_Jsq+tUmRfvKE6vf+za6TsG_fhMWn5M2DDDLcCfkDt=KJGVg@mail.gmail.com>
On Sun, Aug 23, 2015 at 4:42 PM, Rob Herring <robherring2@gmail.com> wrote:
> On Sun, Aug 23, 2015 at 6:13 PM, Olof Johansson <olof@lixom.net> wrote:
>> On Fri, Aug 14, 2015 at 2:21 PM, Rob Herring <robherring2@gmail.com> wrote:
>>> +arm-soc
>>>
>>> On Tue, Aug 11, 2015 at 5:07 AM, Ian Campbell <ian.campbell@citrix.com> wrote:
>>>> On Mon, 2015-08-03 at 17:06 +0100, Ian Campbell wrote:
>>>>> Commit 9ccd608070b6 ("arm64: dts: add device tree for ARM SMM-A53x2 on
>>>>> LogicTile Express 20MG") added a new dts file to arch/arm64 which
>>>>> included "../../../../arm/boot/dts/vexpress-v2m-rs1.dtsi", i.e. a
>>>>> .dtsi supplied by arch/arm.
>>>>>
>>>>> Unfortunately this causes some issues for the split device tree
>>>>> repository[0], since things get moved around there. In that context
>>>>> the new .dts ends up at src/arm64/arm/vexpress-v2f-1xv7-ca53x2.dts
>>>>> while the include is at src/arm/vexpress-v2m-rs1.dtsi.
>>>>
>>>> Hi Grant,
>>>>
>>>> Do you think there is any chance of getting this into 4.2-rc$NEXT or shall
>>>> we wait until 4.3? I'm assuming this should go via the DT tree, but maybe
>>>> it should go via an ARM tree?
>>>
>>> I was assuming this would go thru the arm-soc tree which is why I
>>> acked it. It is getting a bit late for 4.2 at this point, but I guess
>>> the standalone tree remains broken for these platforms until this is
>>> done. Probably not such a big deal in grand scheme of things.
>>
>> I'm cc:d in the far tail of a thread, so I'll just comment here
>> instead of further up:
>>
>> I'm not a fan at all of creating kernel/dts/<arch>/*, at least if
>> there's expected to be contents in there.
>>
>> We don't have include/linux/asm-<arch>/ in the common tree either.
>> Let's not create that for dts.
>
> I'd really like to move ALL dts files from arch/*. There's nothing
> really tied to the architecture. They may happen to use some bindings
> that only apply to an architecture, but fundamentally they don't
> depend on the arch. Also, I'd like to be able to do "make all-dtbs"
> and build every dtb in the tree.
The main benefit of keeping it per architecture and platform is that
it partitions the maintainer and review space a bit.
Right now it's not possible to do even per-arch "all-dtbs" since only
the currently configured platforms will get their dtbs compiled.
> That said, I'm not crazy enough to propose this re-org in the kernel
> tree, but would like to do that if/when we moved dts files out of the
> kernel.
I believe this is currently still quite firmly in the "if" stage. :(
>> So, while I'm all for a prefix-based sharing of DTSI files, I don't
>> want them to go in a common kernel/dts directory.
>>
>> Besides sharing some snippets between arm and arm64, what else is
>> expected to need to go into such a shared location today?
>
> Overlays. You easily have the same sharing of common boards. There are
> also usecases of overlays on architectures that don't generally use DT
> (x86).
Ok, overlays might make sense if they can be made to work generically
enough and not be tied to expectations of the base board platform.
Still, even then I don't see dts as a core kernel feature (kernel/*),
lib/* might make more sense. And I don't want to see things like
vexpress stuff in there.
> We could also see sharing between PPC and ARM on FSL networking parts,
> but I've not heard if they actually have that problem.
Yeah, there could potentially be some sharing between MIPS and
ARM{,64} too, but I don't know if we'll actually see it done.
-Olof
next prev parent reply other threads:[~2015-08-23 23:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 16:06 [PATCH v5] dtb: Create a common home for cross-architecture dtsi files Ian Campbell
2015-08-03 16:47 ` Frank Rowand
2015-08-11 10:07 ` Ian Campbell
2015-08-14 21:21 ` Rob Herring
2015-08-16 9:01 ` Ian Campbell
2015-08-23 23:13 ` Olof Johansson
2015-08-23 23:42 ` Rob Herring
2015-08-23 23:52 ` Olof Johansson [this message]
2015-08-24 20:58 ` Rob Herring
2015-08-24 22:22 ` Olof Johansson
2015-09-01 8:44 ` Ian Campbell
2015-09-17 11:07 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOesGMigmaEviCDBAncomkq+uowr18B5FTOmOyBHsNz4p6F6Dw@mail.gmail.com \
--to=olof@lixom.net \
--cc=arm@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ian.campbell@citrix.com \
--cc=khilman@linaro.org \
--cc=kristina.martsenko@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=robherring2@gmail.com \
--cc=sudeep.holla@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).