From: Viresh Kumar <viresh.kumar@linaro.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Vincent Guittot <vincent.guittot@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH 1/4] base/drivers/arch_topology: Remove useless check
Date: Tue, 30 Oct 2018 11:20:19 +0530 [thread overview]
Message-ID: <CAOh2x==y+7jEdC-3xpvhr6j+RTtXRwTnBFC2uRVUmuktbCvsKw@mail.gmail.com> (raw)
In-Reply-To: <1540830201-2947-1-git-send-email-daniel.lezcano@linaro.org>
On Mon, Oct 29, 2018 at 9:56 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
Would have been better if I was cc'd on all the patches since I was
looking at this
stuff actively this week :)
> The function 'register_cpufreq_notifier' registers the
> init_cpu_capacity_notifier() only if raw_capacity is not NULL.
>
> Hence init_cpu_capacity_notifier() can not be called with raw_capacity
> set to NULL, it is pointless to check it.
It isn't entirely pointless though.
It is possible for init_cpu_capacity_notifier() to get called after
free_raw_capacity()
is called from it as the notifier unregistration happens from a workqueue.
next prev parent reply other threads:[~2018-10-30 5:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 16:23 [PATCH 1/4] base/drivers/arch_topology: Remove useless check Daniel Lezcano
2018-10-29 16:23 ` [PATCH 2/4] base/drivers/arch_topology: Replace mutex with READ_ONCE / WRITE_ONCE Daniel Lezcano
2018-10-30 5:57 ` Viresh Kumar
2018-11-23 13:58 ` Sudeep Holla
2018-11-23 16:04 ` Daniel Lezcano
2018-11-23 16:20 ` Sudeep Holla
2018-11-23 16:54 ` Daniel Lezcano
2018-11-26 8:27 ` Juri Lelli
2018-11-26 8:39 ` Daniel Lezcano
2018-11-26 11:33 ` Mark Brown
2018-10-29 16:23 ` [PATCH 3/4] base/drivers/topology: Move instructions in the error path Daniel Lezcano
2018-10-30 6:12 ` Viresh Kumar
2018-10-30 8:32 ` Daniel Lezcano
2018-10-29 16:23 ` [PATCH 4/4] base/drivers/topology: Default dmpis-mhz if they are not set in DT Daniel Lezcano
2018-10-30 7:13 ` Viresh Kumar
2018-10-30 8:39 ` Daniel Lezcano
2018-10-30 8:45 ` Viresh Kumar
2018-10-30 8:58 ` Viresh Kumar
2018-11-21 22:12 ` Daniel Lezcano
2018-11-22 4:29 ` Viresh Kumar
2018-11-22 10:29 ` Daniel Lezcano
2018-11-22 10:31 ` Viresh Kumar
2018-11-22 10:32 ` Daniel Lezcano
2018-11-22 11:11 ` Daniel Lezcano
2018-10-30 5:50 ` Viresh Kumar [this message]
2018-10-30 7:55 ` [PATCH 1/4] base/drivers/arch_topology: Remove useless check Daniel Lezcano
2018-10-30 8:33 ` Viresh Kumar
2018-10-30 13:35 ` Daniel Lezcano
2018-10-31 4:27 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOh2x==y+7jEdC-3xpvhr6j+RTtXRwTnBFC2uRVUmuktbCvsKw@mail.gmail.com' \
--to=viresh.kumar@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).