* [PATCH -next] i2c: designware: Add helper to remove redundancy
@ 2022-03-10 14:22 Jan Dabros
2022-03-10 14:52 ` Jarkko Nikula
0 siblings, 1 reply; 3+ messages in thread
From: Jan Dabros @ 2022-03-10 14:22 UTC (permalink / raw)
To: linux-kernel, linux-i2c, jarkko.nikula, andriy.shevchenko
Cc: wsa, upstream, jsd
Simplify code by adding an extra static function for sending I2C
requests and verifying results.
Signed-off-by: Jan Dabros <jsd@semihalf.com>
---
drivers/i2c/busses/i2c-designware-amdpsp.c | 44 ++++++++++++----------
1 file changed, 24 insertions(+), 20 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-amdpsp.c b/drivers/i2c/busses/i2c-designware-amdpsp.c
index c64e459afb5c..cc758792f150 100644
--- a/drivers/i2c/busses/i2c-designware-amdpsp.c
+++ b/drivers/i2c/busses/i2c-designware-amdpsp.c
@@ -229,6 +229,26 @@ static int psp_send_i2c_req(enum psp_i2c_req_type i2c_req_type)
return ret;
}
+static int psp_send_i2c_req_check_err(enum psp_i2c_req_type request)
+{
+ int status;
+
+ status = psp_send_i2c_req(request);
+ if (status) {
+ if (status == -ETIMEDOUT)
+ dev_err(psp_i2c_dev, "Timed out waiting for PSP to %s I2C bus\n",
+ (request == PSP_I2C_REQ_ACQUIRE) ?
+ "release" : "acquire");
+ else
+ dev_err(psp_i2c_dev, "PSP communication error\n");
+
+ dev_err(psp_i2c_dev, "Assume i2c bus is for exclusive host usage\n");
+ psp_i2c_mbox_fail = true;
+ }
+
+ return status;
+}
+
static int psp_acquire_i2c_bus(void)
{
int status;
@@ -248,17 +268,9 @@ static int psp_acquire_i2c_bus(void)
goto cleanup;
};
- status = psp_send_i2c_req(PSP_I2C_REQ_ACQUIRE);
- if (status) {
- if (status == -ETIMEDOUT)
- dev_err(psp_i2c_dev, "Timed out waiting for PSP to release I2C bus\n");
- else
- dev_err(psp_i2c_dev, "PSP communication error\n");
-
- dev_err(psp_i2c_dev, "Assume i2c bus is for exclusive host usage\n");
- psp_i2c_mbox_fail = true;
+ status = psp_send_i2c_req_check_err(PSP_I2C_REQ_ACQUIRE);
+ if (status)
goto cleanup;
- }
psp_i2c_sem_acquired = jiffies;
psp_i2c_access_count++;
@@ -293,17 +305,9 @@ static void psp_release_i2c_bus(void)
goto cleanup;
/* Send a release command to PSP */
- status = psp_send_i2c_req(PSP_I2C_REQ_RELEASE);
- if (status) {
- if (status == -ETIMEDOUT)
- dev_err(psp_i2c_dev, "Timed out waiting for PSP to acquire I2C bus\n");
- else
- dev_err(psp_i2c_dev, "PSP communication error\n");
-
- dev_err(psp_i2c_dev, "Assume i2c bus is for exclusive host usage\n");
- psp_i2c_mbox_fail = true;
+ status = psp_send_i2c_req_check_err(PSP_I2C_REQ_RELEASE);
+ if (status)
goto cleanup;
- }
dev_dbg(psp_i2c_dev, "PSP semaphore held for %ums\n",
jiffies_to_msecs(jiffies - psp_i2c_sem_acquired));
--
2.35.1.616.g0bdcbb4464-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] i2c: designware: Add helper to remove redundancy
2022-03-10 14:22 [PATCH -next] i2c: designware: Add helper to remove redundancy Jan Dabros
@ 2022-03-10 14:52 ` Jarkko Nikula
2022-03-10 21:57 ` Jan Dąbroś
0 siblings, 1 reply; 3+ messages in thread
From: Jarkko Nikula @ 2022-03-10 14:52 UTC (permalink / raw)
To: Jan Dabros, linux-kernel, linux-i2c, andriy.shevchenko; +Cc: wsa, upstream
On 3/10/22 16:22, Jan Dabros wrote:
> Simplify code by adding an extra static function for sending I2C
> requests and verifying results.
>
> Signed-off-by: Jan Dabros <jsd@semihalf.com>
> ---
> drivers/i2c/busses/i2c-designware-amdpsp.c | 44 ++++++++++++----------
> 1 file changed, 24 insertions(+), 20 deletions(-)
>
Do I remember correctly was this suggested by Andy? I.e. to give kudos
to him if that was the case:
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> diff --git a/drivers/i2c/busses/i2c-designware-amdpsp.c b/drivers/i2c/busses/i2c-designware-amdpsp.c
> index c64e459afb5c..cc758792f150 100644
> --- a/drivers/i2c/busses/i2c-designware-amdpsp.c
> +++ b/drivers/i2c/busses/i2c-designware-amdpsp.c
> @@ -229,6 +229,26 @@ static int psp_send_i2c_req(enum psp_i2c_req_type i2c_req_type)
> return ret;
> }
>
> +static int psp_send_i2c_req_check_err(enum psp_i2c_req_type request)
> +{
> + int status;
> +
> + status = psp_send_i2c_req(request);
> + if (status) {
> + if (status == -ETIMEDOUT)
> + dev_err(psp_i2c_dev, "Timed out waiting for PSP to %s I2C bus\n",
> + (request == PSP_I2C_REQ_ACQUIRE) ?
> + "release" : "acquire");
> + else
> + dev_err(psp_i2c_dev, "PSP communication error\n");
> +
> + dev_err(psp_i2c_dev, "Assume i2c bus is for exclusive host usage\n");
> + psp_i2c_mbox_fail = true;
> + }
> +
Does it make sense to have these inside the psp_send_i2c_req() and get
rid of this new middle function? I mean psp_send_i2c_req() is called now
only from here so can it do these common error prints and set
"psp_i2c_mbox_fail = true"?
Jarkko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] i2c: designware: Add helper to remove redundancy
2022-03-10 14:52 ` Jarkko Nikula
@ 2022-03-10 21:57 ` Jan Dąbroś
0 siblings, 0 replies; 3+ messages in thread
From: Jan Dąbroś @ 2022-03-10 21:57 UTC (permalink / raw)
To: Jarkko Nikula
Cc: Linux Kernel Mailing List, linux-i2c, Andy Shevchenko,
Wolfram Sang, upstream
czw., 10 mar 2022 o 15:52 Jarkko Nikula
<jarkko.nikula@linux.intel.com> napisał(a):
>
> On 3/10/22 16:22, Jan Dabros wrote:
> > Simplify code by adding an extra static function for sending I2C
> > requests and verifying results.
> >
> > Signed-off-by: Jan Dabros <jsd@semihalf.com>
> > ---
> > drivers/i2c/busses/i2c-designware-amdpsp.c | 44 ++++++++++++----------
> > 1 file changed, 24 insertions(+), 20 deletions(-)
> >
> Do I remember correctly was this suggested by Andy? I.e. to give kudos
> to him if that was the case:
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Definitely! Actually I wasn't aware of such a tag, will add this in v2.
>
> > diff --git a/drivers/i2c/busses/i2c-designware-amdpsp.c b/drivers/i2c/busses/i2c-designware-amdpsp.c
> > index c64e459afb5c..cc758792f150 100644
> > --- a/drivers/i2c/busses/i2c-designware-amdpsp.c
> > +++ b/drivers/i2c/busses/i2c-designware-amdpsp.c
> > @@ -229,6 +229,26 @@ static int psp_send_i2c_req(enum psp_i2c_req_type i2c_req_type)
> > return ret;
> > }
> >
> > +static int psp_send_i2c_req_check_err(enum psp_i2c_req_type request)
> > +{
> > + int status;
> > +
> > + status = psp_send_i2c_req(request);
> > + if (status) {
> > + if (status == -ETIMEDOUT)
> > + dev_err(psp_i2c_dev, "Timed out waiting for PSP to %s I2C bus\n",
> > + (request == PSP_I2C_REQ_ACQUIRE) ?
> > + "release" : "acquire");
> > + else
> > + dev_err(psp_i2c_dev, "PSP communication error\n");
> > +
> > + dev_err(psp_i2c_dev, "Assume i2c bus is for exclusive host usage\n");
> > + psp_i2c_mbox_fail = true;
> > + }
> > +
>
> Does it make sense to have these inside the psp_send_i2c_req() and get
> rid of this new middle function? I mean psp_send_i2c_req() is called now
> only from here so can it do these common error prints and set
> "psp_i2c_mbox_fail = true"?
I like this idea, please take a look at v2.
Best Regards,
Jan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-10 21:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-10 14:22 [PATCH -next] i2c: designware: Add helper to remove redundancy Jan Dabros
2022-03-10 14:52 ` Jarkko Nikula
2022-03-10 21:57 ` Jan Dąbroś
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).