From: Gilad Ben-Yossef <gilad@benyossef.com>
To: Colin King <colin.king@canonical.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: ccree: remove unused pointer cc_base
Date: Thu, 9 Nov 2017 11:21:50 +0200 [thread overview]
Message-ID: <CAOtvUMeJABR=mp-5_aO2wq3FoFAiKzftSpor7r_J6382XGpGcA@mail.gmail.com> (raw)
In-Reply-To: <20171109081305.3659-1-colin.king@canonical.com>
Hi Colin,
Thank you very much for your patch.
On Thu, Nov 9, 2017 at 10:13 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer cc_base is being assigned but is never read, hence it is
> redundant and can be removed. Cleans up clang warning:
>
> drivers/staging/ccree/ssi_driver.c:235:2: warning: Value stored to
> 'cc_base' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/ccree/ssi_driver.c | 3 ---
> 1 file changed, 3 deletions(-)
Your patch is perfectly fine but I just happened to send a patch
series that includes
this fix but also deals with other occurrences of the same now
no-longer needed cc_base
variable just a second ago before checking my email...
Sorry about that and thanks again.
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru
prev parent reply other threads:[~2017-11-09 9:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 8:13 [PATCH] staging: ccree: remove unused pointer cc_base Colin King
2017-11-09 9:21 ` Gilad Ben-Yossef [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOtvUMeJABR=mp-5_aO2wq3FoFAiKzftSpor7r_J6382XGpGcA@mail.gmail.com' \
--to=gilad@benyossef.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).