* [PATCH] gpu: ipu-v3: fix a possible NULL dereference
@ 2016-08-16 13:33 LABBE Corentin
2016-08-23 15:24 ` Sean Paul
0 siblings, 1 reply; 3+ messages in thread
From: LABBE Corentin @ 2016-08-16 13:33 UTC (permalink / raw)
To: p.zabel; +Cc: dri-devel, linux-kernel, LABBE Corentin
of_match_device could return NULL, and so cause a NULL pointer
dereference later.
For fixing this problem, we use of_device_get_match_data(), this will
simplify the code a little by using a standard function for
getting the match data.
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
drivers/gpu/ipu-v3/ipu-common.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c
index 99dcacf..05a9cc6 100644
--- a/drivers/gpu/ipu-v3/ipu-common.c
+++ b/drivers/gpu/ipu-v3/ipu-common.c
@@ -1207,15 +1207,13 @@ EXPORT_SYMBOL_GPL(ipu_dump);
static int ipu_probe(struct platform_device *pdev)
{
- const struct of_device_id *of_id =
- of_match_device(imx_ipu_dt_ids, &pdev->dev);
struct ipu_soc *ipu;
struct resource *res;
unsigned long ipu_base;
int i, ret, irq_sync, irq_err;
const struct ipu_devtype *devtype;
- devtype = of_id->data;
+ devtype = of_device_get_match_data(&pdev->dev);
irq_sync = platform_get_irq(pdev, 0);
irq_err = platform_get_irq(pdev, 1);
--
2.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpu: ipu-v3: fix a possible NULL dereference
2016-08-16 13:33 [PATCH] gpu: ipu-v3: fix a possible NULL dereference LABBE Corentin
@ 2016-08-23 15:24 ` Sean Paul
2016-08-23 16:23 ` Corentin LABBE
0 siblings, 1 reply; 3+ messages in thread
From: Sean Paul @ 2016-08-23 15:24 UTC (permalink / raw)
To: LABBE Corentin; +Cc: p.zabel, Linux Kernel Mailing List, dri-devel
On Tue, Aug 16, 2016 at 9:33 AM, LABBE Corentin
<clabbe.montjoie@gmail.com> wrote:
> of_match_device could return NULL, and so cause a NULL pointer
> dereference later.
>
> For fixing this problem, we use of_device_get_match_data(), this will
> simplify the code a little by using a standard function for
> getting the match data.
>
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> ---
> drivers/gpu/ipu-v3/ipu-common.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c
> index 99dcacf..05a9cc6 100644
> --- a/drivers/gpu/ipu-v3/ipu-common.c
> +++ b/drivers/gpu/ipu-v3/ipu-common.c
> @@ -1207,15 +1207,13 @@ EXPORT_SYMBOL_GPL(ipu_dump);
>
> static int ipu_probe(struct platform_device *pdev)
> {
> - const struct of_device_id *of_id =
> - of_match_device(imx_ipu_dt_ids, &pdev->dev);
> struct ipu_soc *ipu;
> struct resource *res;
> unsigned long ipu_base;
> int i, ret, irq_sync, irq_err;
> const struct ipu_devtype *devtype;
>
> - devtype = of_id->data;
> + devtype = of_device_get_match_data(&pdev->dev);
While you avoid the of_id dereference, it's possible that
of_device_get_match_data() returns NULL, so you're really just moving
the oops around.
Sean
>
> irq_sync = platform_get_irq(pdev, 0);
> irq_err = platform_get_irq(pdev, 1);
> --
> 2.7.3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpu: ipu-v3: fix a possible NULL dereference
2016-08-23 15:24 ` Sean Paul
@ 2016-08-23 16:23 ` Corentin LABBE
0 siblings, 0 replies; 3+ messages in thread
From: Corentin LABBE @ 2016-08-23 16:23 UTC (permalink / raw)
To: Sean Paul; +Cc: p.zabel, Linux Kernel Mailing List, dri-devel
On 23/08/2016 17:24, Sean Paul wrote:
> On Tue, Aug 16, 2016 at 9:33 AM, LABBE Corentin
> <clabbe.montjoie@gmail.com> wrote:
>> of_match_device could return NULL, and so cause a NULL pointer
>> dereference later.
>>
>> For fixing this problem, we use of_device_get_match_data(), this will
>> simplify the code a little by using a standard function for
>> getting the match data.
>>
>> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
>> ---
>> drivers/gpu/ipu-v3/ipu-common.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c
>> index 99dcacf..05a9cc6 100644
>> --- a/drivers/gpu/ipu-v3/ipu-common.c
>> +++ b/drivers/gpu/ipu-v3/ipu-common.c
>> @@ -1207,15 +1207,13 @@ EXPORT_SYMBOL_GPL(ipu_dump);
>>
>> static int ipu_probe(struct platform_device *pdev)
>> {
>> - const struct of_device_id *of_id =
>> - of_match_device(imx_ipu_dt_ids, &pdev->dev);
>> struct ipu_soc *ipu;
>> struct resource *res;
>> unsigned long ipu_base;
>> int i, ret, irq_sync, irq_err;
>> const struct ipu_devtype *devtype;
>>
>> - devtype = of_id->data;
>> + devtype = of_device_get_match_data(&pdev->dev);
>
> While you avoid the of_id dereference, it's possible that
> of_device_get_match_data() returns NULL, so you're really just moving
> the oops around.
>
> Sean
>
Hello
I apologize for didnt seen that, I will send an updated patch which fix that.
Regards
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-23 16:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-16 13:33 [PATCH] gpu: ipu-v3: fix a possible NULL dereference LABBE Corentin
2016-08-23 15:24 ` Sean Paul
2016-08-23 16:23 ` Corentin LABBE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).