* [PATCH 15/15] perf annotate: ensure objdump argv is NULL terminated
@ 2019-10-15 0:33 Ian Rogers
2019-10-15 0:34 ` Ian Rogers
0 siblings, 1 reply; 2+ messages in thread
From: Ian Rogers @ 2019-10-15 0:33 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Jin Yao, Song Liu, linux-kernel
Cc: Stephane Eranian, Ian Rogers
Provide null termination.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/annotate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index f7c620e0099b..a9089e64046d 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -1921,6 +1921,7 @@ static int symbol__disassemble(struct symbol *sym, struct annotate_args *args)
NULL, /* Will be the objdump command to run. */
"--",
NULL, /* Will be the symfs path. */
+ NULL,
};
struct child_process objdump_process;
int err = dso__disassemble_filename(dso, symfs_filename, sizeof(symfs_filename));
--
2.23.0.700.g56cf767bdb-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 15/15] perf annotate: ensure objdump argv is NULL terminated
2019-10-15 0:33 [PATCH 15/15] perf annotate: ensure objdump argv is NULL terminated Ian Rogers
@ 2019-10-15 0:34 ` Ian Rogers
0 siblings, 0 replies; 2+ messages in thread
From: Ian Rogers @ 2019-10-15 0:34 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Jin Yao, Song Liu, LKML
Apologies, resending with the correct patch number.
On Mon, Oct 14, 2019 at 5:33 PM Ian Rogers <irogers@google.com> wrote:
>
> Provide null termination.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/util/annotate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index f7c620e0099b..a9089e64046d 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -1921,6 +1921,7 @@ static int symbol__disassemble(struct symbol *sym, struct annotate_args *args)
> NULL, /* Will be the objdump command to run. */
> "--",
> NULL, /* Will be the symfs path. */
> + NULL,
> };
> struct child_process objdump_process;
> int err = dso__disassemble_filename(dso, symfs_filename, sizeof(symfs_filename));
> --
> 2.23.0.700.g56cf767bdb-goog
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-15 0:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 0:33 [PATCH 15/15] perf annotate: ensure objdump argv is NULL terminated Ian Rogers
2019-10-15 0:34 ` Ian Rogers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).