[PATCH] perf bench: remove unneeded variable

[PATCH] perf bench: remove unneeded variable

[baomingtong001]

fix the following coccicheck warning:

tools/perf/bench/find-bit-bench.c:127:5-8: Unneeded variable: "err". 
Return "0".

Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
---
  tools/perf/bench/find-bit-bench.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/bench/find-bit-bench.c 
b/tools/perf/bench/find-bit-bench.c
index 7e25b0e413f6..70619bc73841 100644
--- a/tools/perf/bench/find-bit-bench.c
+++ b/tools/perf/bench/find-bit-bench.c
@@ -124,7 +124,7 @@ static int do_for_each_set_bit(unsigned int 
num_bits)

  int bench_mem_find_bit(int argc, const char **argv)
  {
-    int err = 0, i;
+    int i;

      argc = parse_options(argc, argv, options, bench_usage, 0);
      if (argc) {
@@ -135,5 +135,5 @@ int bench_mem_find_bit(int argc, const char **argv)
      for (i = 1; i <= 2048; i <<= 1)
          do_for_each_set_bit(i);

-    return err;
+    return 0;
  }

Re: [PATCH] perf bench: remove unneeded variable

[Ian Rogers]

On Tue, Jun 13, 2023 at 8:38 PM <baomingtong001@208suo.com> wrote:
>
> fix the following coccicheck warning:
>
> tools/perf/bench/find-bit-bench.c:127:5-8: Unneeded variable: "err".
> Return "0".
>
> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>   tools/perf/bench/find-bit-bench.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/bench/find-bit-bench.c
> b/tools/perf/bench/find-bit-bench.c
> index 7e25b0e413f6..70619bc73841 100644
> --- a/tools/perf/bench/find-bit-bench.c
> +++ b/tools/perf/bench/find-bit-bench.c
> @@ -124,7 +124,7 @@ static int do_for_each_set_bit(unsigned int
> num_bits)
>
>   int bench_mem_find_bit(int argc, const char **argv)
>   {
> -    int err = 0, i;
> +    int i;
>
>       argc = parse_options(argc, argv, options, bench_usage, 0);
>       if (argc) {
> @@ -135,5 +135,5 @@ int bench_mem_find_bit(int argc, const char **argv)
>       for (i = 1; i <= 2048; i <<= 1)
>           do_for_each_set_bit(i);
>
> -    return err;
> +    return 0;
>   }

Re: [PATCH] perf bench: remove unneeded variable

[Arnaldo Carvalho de Melo]

Em Wed, Jun 14, 2023 at 11:38:41AM +0800, baomingtong001@208suo.com escreveu:
> fix the following coccicheck warning:
> 
> tools/perf/bench/find-bit-bench.c:127:5-8: Unneeded variable: "err". Return
> "0".

⬢[acme@toolbox perf-tools-next]$ patch -p1 < ~/wb/1.patch
patching file tools/perf/bench/find-bit-bench.c
patch: **** malformed patch at line 117: num_bits)

⬢[acme@toolbox perf-tools-next]$

Please check the process you're following to generate and send the
patch.

There is a doc file for that...

Documentation/process/submitting-patches.rst

Well, two:

Documentation/process/submit-checklist.rst

I'm applying this manually,

Thanks,

- Arnaldo
 
> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
> ---
>  tools/perf/bench/find-bit-bench.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/bench/find-bit-bench.c
> b/tools/perf/bench/find-bit-bench.c
> index 7e25b0e413f6..70619bc73841 100644
> --- a/tools/perf/bench/find-bit-bench.c
> +++ b/tools/perf/bench/find-bit-bench.c
> @@ -124,7 +124,7 @@ static int do_for_each_set_bit(unsigned int num_bits)
> 
>  int bench_mem_find_bit(int argc, const char **argv)
>  {
> -    int err = 0, i;
> +    int i;
> 
>      argc = parse_options(argc, argv, options, bench_usage, 0);
>      if (argc) {
> @@ -135,5 +135,5 @@ int bench_mem_find_bit(int argc, const char **argv)
>      for (i = 1; i <= 2048; i <<= 1)
>          do_for_each_set_bit(i);
> 
> -    return err;
> +    return 0;
>  }

-- 

- Arnaldo

[PATCH] perf: bench: Remove unneeded variable

[Wan Jiabing]

Fix coccicheck warning:

tools/perf/bench/find-bit-bench.c:123:5-8:
Unneeded variable: "err". Return "0" on line 134

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 tools/perf/bench/find-bit-bench.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/bench/find-bit-bench.c b/tools/perf/bench/find-bit-bench.c
index 73b5bcc5946a..7e748a56a8ba 100644
--- a/tools/perf/bench/find-bit-bench.c
+++ b/tools/perf/bench/find-bit-bench.c
@@ -120,7 +120,7 @@ static int do_for_each_set_bit(unsigned int num_bits)
 
 int bench_mem_find_bit(int argc, const char **argv)
 {
-	int err = 0, i;
+	int i;
 
 	argc = parse_options(argc, argv, options, bench_usage, 0);
 	if (argc) {
@@ -131,5 +131,5 @@ int bench_mem_find_bit(int argc, const char **argv)
 	for (i = 1; i <= 2048; i <<= 1)
 		do_for_each_set_bit(i);
 
-	return err;
+	return 0;
 }
-- 
2.30.2