* [PATCH 1/1] r8152: sync sa_family with the media type of network device
@ 2019-04-19 8:45 crag0715
2019-04-19 19:37 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: crag0715 @ 2019-04-19 8:45 UTC (permalink / raw)
To: linux-usb
Cc: linux-kernel, hayeswang, mario_limonciello, crag0715, Crag.Wang,
David S. Miller, Simon Glass, Sean Paul, Grant Grundler,
David Chen, Florian Fainelli, Gustavo A. R. Silva, zhong jiang,
Charles Hyde, Sebastian Andrzej Siewior
From: "Crag.Wang" <crag.wang@dell.com>
Without this patch the socket address family sporadically gets wrong
value ends up the dev_set_mac_address() fails to set the desired MAC
address.
Change-Id: Ib48a303730bee81667a2859be32e48cc8a66f277
Signed-off-by: Crag.Wang <crag.wang@dell.com>
---
drivers/net/usb/r8152.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 4c63b40d5e00..41fb39ce69c9 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -1225,6 +1225,8 @@ static int determine_ethernet_addr(struct r8152 *tp, struct sockaddr *sa)
struct net_device *dev = tp->netdev;
int ret;
+ sa->sa_family = dev->type;
+
if (tp->version == RTL_VER_01) {
ret = pla_ocp_read(tp, PLA_IDR, 8, sa->sa_data);
} else {
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] r8152: sync sa_family with the media type of network device
2019-04-19 8:45 [PATCH 1/1] r8152: sync sa_family with the media type of network device crag0715
@ 2019-04-19 19:37 ` Greg KH
2019-04-22 1:55 ` Crag Wang
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2019-04-19 19:37 UTC (permalink / raw)
To: crag0715
Cc: linux-usb, linux-kernel, hayeswang, mario_limonciello, Crag.Wang,
David S. Miller, Simon Glass, Sean Paul, Grant Grundler,
David Chen, Florian Fainelli, Gustavo A. R. Silva, zhong jiang,
Charles Hyde, Sebastian Andrzej Siewior
On Fri, Apr 19, 2019 at 04:45:46PM +0800, crag0715@gmail.com wrote:
> From: "Crag.Wang" <crag.wang@dell.com>
>
> Without this patch the socket address family sporadically gets wrong
> value ends up the dev_set_mac_address() fails to set the desired MAC
> address.
>
> Change-Id: Ib48a303730bee81667a2859be32e48cc8a66f277
No need for this line here, I don't think you ran checkpatch.pl on your
change before sending it out :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] r8152: sync sa_family with the media type of network device
2019-04-19 19:37 ` Greg KH
@ 2019-04-22 1:55 ` Crag Wang
0 siblings, 0 replies; 3+ messages in thread
From: Crag Wang @ 2019-04-22 1:55 UTC (permalink / raw)
To: Greg KH
Cc: linux-usb, linux-kernel, hayeswang, Mario Limonciello, Crag.Wang,
David S. Miller, Simon Glass, Sean Paul, Grant Grundler,
David Chen, Florian Fainelli, Gustavo A. R. Silva, zhong jiang,
Charles Hyde, Sebastian Andrzej Siewior
Greg KH <gregkh@linuxfoundation.org> 於 2019年4月20日 週六 上午3:37寫道：
>
> On Fri, Apr 19, 2019 at 04:45:46PM +0800, crag0715@gmail.com wrote:
> > From: "Crag.Wang" <crag.wang@dell.com>
> >
> > Without this patch the socket address family sporadically gets wrong
> > value ends up the dev_set_mac_address() fails to set the desired MAC
> > address.
> >
> > Change-Id: Ib48a303730bee81667a2859be32e48cc8a66f277
>
> No need for this line here, I don't think you ran checkpatch.pl on your
> change before sending it out :(
I added param to skip the verification of gerrit change-id, will
remove this line in v2 and upload.
Crag
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-22 1:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-19 8:45 [PATCH 1/1] r8152: sync sa_family with the media type of network device crag0715
2019-04-19 19:37 ` Greg KH
2019-04-22 1:55 ` Crag Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).