[PATCH] drm/panel-edp: Add BOE NT116WHM-N4C (HW: V8.1)

[PATCH] drm/panel-edp: Add BOE NT116WHM-N4C (HW: V8.1)

[Sean Hong]

Add support for the BOE - NT116WHM-N4C (HW: V8.1) panel.

Signed-off-by: Sean Hong <sean.hong@quanta.corp-partner.google.com>
---
 drivers/gpu/drm/panel/panel-edp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index 102ab9f5d40a..03a4a49e4ecb 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -1890,6 +1890,7 @@ static const struct edp_panel_entry edp_panels[] = {
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x098d, &boe_nv110wtm_n61.delay, "NV110WTM-N61"),
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x09dd, &delay_200_500_e50, "NT116WHM-N21"),
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a5d, &delay_200_500_e50, "NV116WHM-N45"),
+	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0ac5, &delay_200_500_e50, "NV116WHM-N4C"),
 
 	EDP_PANEL_ENTRY('C', 'M', 'N', 0x114c, &innolux_n116bca_ea1.delay, "N116BCA-EA1"),
 	EDP_PANEL_ENTRY('C', 'M', 'N', 0x1152, &delay_200_500_p2e80, "N116BCN-EA1"),
-- 
2.25.1

Re: [PATCH] drm/panel-edp: Add BOE NT116WHM-N4C (HW: V8.1)

[Doug Anderson]

Hi,

On Mon, Sep 26, 2022 at 11:35 PM Sean Hong
<sean.hong@quanta.corp-partner.google.com> wrote:
>
> Add support for the BOE - NT116WHM-N4C (HW: V8.1) panel.
>
> Signed-off-by: Sean Hong <sean.hong@quanta.corp-partner.google.com>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 1 +
>  1 file changed, 1 insertion(+)

Wow, another panel?!?

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Pushed to drm-misc:

2f24fe8c54cc drm/panel-edp: Add BOE NT116WHM-N4C (HW: V8.1)

Re: [PATCH] drm/panel-edp: Add BOE NT116WHM-N4C (HW: V8.1)

[Sean Hong]

On Tue, Sep 27, 2022 at 11:27 PM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Mon, Sep 26, 2022 at 11:35 PM Sean Hong
> <sean.hong@quanta.corp-partner.google.com> wrote:
> >
> > Add support for the BOE - NT116WHM-N4C (HW: V8.1) panel.
> >
> > Signed-off-by: Sean Hong <sean.hong@quanta.corp-partner.google.com>
> > ---
> >  drivers/gpu/drm/panel/panel-edp.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> Wow, another panel?!?
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
> Pushed to drm-misc:
>
> 2f24fe8c54cc drm/panel-edp: Add BOE NT116WHM-N4C (HW: V8.1)

Hi Anderson,

I found some mistakes on this commit. I typed the wrong model name on
title and content.
The correct model name is NV116WHM-N4C and the code is correct.

How can I fix it? Do I need to revert this commit and then submit a
new patch upstream?

Sean

Re: [PATCH] drm/panel-edp: Add BOE NT116WHM-N4C (HW: V8.1)

[Doug Anderson]

Hi,

On Tue, Sep 27, 2022 at 11:51 PM Sean Hong
<sean.hong@quanta.corp-partner.google.com> wrote:
>
> On Tue, Sep 27, 2022 at 11:27 PM Doug Anderson <dianders@chromium.org> wrote:
> >
> > Hi,
> >
> > On Mon, Sep 26, 2022 at 11:35 PM Sean Hong
> > <sean.hong@quanta.corp-partner.google.com> wrote:
> > >
> > > Add support for the BOE - NT116WHM-N4C (HW: V8.1) panel.
> > >
> > > Signed-off-by: Sean Hong <sean.hong@quanta.corp-partner.google.com>
> > > ---
> > >  drivers/gpu/drm/panel/panel-edp.c | 1 +
> > >  1 file changed, 1 insertion(+)
> >
> > Wow, another panel?!?
> >
> > Reviewed-by: Douglas Anderson <dianders@chromium.org>
> >
> > Pushed to drm-misc:
> >
> > 2f24fe8c54cc drm/panel-edp: Add BOE NT116WHM-N4C (HW: V8.1)
>
> Hi Anderson,
>
> I found some mistakes on this commit. I typed the wrong model name on
> title and content.
> The correct model name is NV116WHM-N4C and the code is correct.
>
> How can I fix it? Do I need to revert this commit and then submit a
> new patch upstream?

There's not much to be done at this point in time. Reverting /
readding the same code with a slightly different commit message
wouldn't be worth it. The code is correct and that's the important
thing. The commit has a link to the mailing list post so anyone who's
confused will hopefully click the link and can find this discussion.

-Doug