From: Otavio Salvador <otavio.salvador@ossystems.com.br>
To: Fabio Estevam <festevam@gmail.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>,
Sascha Hauer <s.hauer@pengutronix.de>,
Kernel development list <linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
NXP Linux Team <linux-imx@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND
Date: Sun, 25 Nov 2018 18:49:22 -0200 [thread overview]
Message-ID: <CAP9ODKrpde0tpRgoRMihvDur=ftQsT59h4Cqr3VQAOOimoSB1Q@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5AVWbk_gdtDvXQfYqmENr8d3z5oxQVtzFtex0WrfY6tZQ@mail.gmail.com>
Hello Fabio,
On Sun, Nov 25, 2018 at 6:30 PM Fabio Estevam <festevam@gmail.com> wrote:
> On Sun, Nov 25, 2018 at 6:18 PM Otavio Salvador <otavio@ossystems.com.br> wrote:
> >
> > The setting is removed when running a `savedefconfig` using the
> > current setting set. It is being applied in preparation to some
>
> "setting set" is a bit confusing.
>
> > patches making changes to this defconfig.
>
> It would be good to mention that CONFIG_ARM_UNWIND is still selected
> automatically.
>
> Otherwise it may give the impression that such functionality is being removed.
>
> You could reword the commit log to something like this:
>
> CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but it is
> still selected by the Kconfig logic.
> This is done in preparation to making further changes to this defconfig cleaner.
In fact, was removed and now selected.
I changed the commit log as:
ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable
CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but
selected by the Kconfig logic. This is done in preparation to making
further changes to this defconfig cleaner.
Do you agree?
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
next prev parent reply other threads:[~2018-11-25 20:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 20:17 [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND Otavio Salvador
2018-11-25 20:17 ` [PATCH 2/3] ARM: imx_v6_v7_defconfig: Enable BT_BNEP Otavio Salvador
2018-11-25 20:29 ` Fabio Estevam
2018-11-25 20:17 ` [PATCH 3/3] ARM: imx_v6_v7_defconfig: Enable USB_ANNOUNCE_NEW_DEVICES Otavio Salvador
2018-11-25 20:30 ` Fabio Estevam
2018-11-25 20:29 ` [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND Fabio Estevam
2018-11-25 20:49 ` Otavio Salvador [this message]
2018-11-25 20:55 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP9ODKrpde0tpRgoRMihvDur=ftQsT59h4Cqr3VQAOOimoSB1Q@mail.gmail.com' \
--to=otavio.salvador@ossystems.com.br \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=otavio@ossystems.com.br \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).