* [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND
@ 2018-11-25 20:17 Otavio Salvador
2018-11-25 20:17 ` [PATCH 2/3] ARM: imx_v6_v7_defconfig: Enable BT_BNEP Otavio Salvador
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Otavio Salvador @ 2018-11-25 20:17 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: Otavio Salvador, Fabio Estevam, Pengutronix Kernel Team,
Sascha Hauer, Russell King, Shawn Guo, NXP Linux Team
The setting is removed when running a `savedefconfig` using the
current setting set. It is being applied in preparation to some
patches making changes to this defconfig.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
arch/arm/configs/imx_v6_v7_defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index aa02d18f44d1..0c887a059df3 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -445,4 +445,3 @@ CONFIG_MAGIC_SYSRQ=y
CONFIG_PROVE_LOCKING=y
# CONFIG_DEBUG_BUGVERBOSE is not set
# CONFIG_FTRACE is not set
-# CONFIG_ARM_UNWIND is not set
--
2.19.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/3] ARM: imx_v6_v7_defconfig: Enable BT_BNEP
2018-11-25 20:17 [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND Otavio Salvador
@ 2018-11-25 20:17 ` Otavio Salvador
2018-11-25 20:29 ` Fabio Estevam
2018-11-25 20:17 ` [PATCH 3/3] ARM: imx_v6_v7_defconfig: Enable USB_ANNOUNCE_NEW_DEVICES Otavio Salvador
2018-11-25 20:29 ` [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND Fabio Estevam
2 siblings, 1 reply; 8+ messages in thread
From: Otavio Salvador @ 2018-11-25 20:17 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: Andreas Müller, Otavio Salvador, Fabio Estevam,
Pengutronix Kernel Team, Sascha Hauer, Russell King, Shawn Guo,
NXP Linux Team
From: Andreas Müller <schnitzeltony@gmail.com>
This is necessary to support network over bluetooth:
| Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: kernel lacks bnep-protocol support
| Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: System does not support network plugin
Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
arch/arm/configs/imx_v6_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 0c887a059df3..22ad2d7a1cf2 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -81,6 +81,7 @@ CONFIG_NETFILTER=y
CONFIG_CAN=y
CONFIG_CAN_FLEXCAN=y
CONFIG_BT=y
+CONFIG_BT_BNEP=m
CONFIG_BT_HCIUART=y
CONFIG_BT_HCIUART_LL=y
CONFIG_CFG80211=y
--
2.19.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] ARM: imx_v6_v7_defconfig: Enable BT_BNEP
2018-11-25 20:17 ` [PATCH 2/3] ARM: imx_v6_v7_defconfig: Enable BT_BNEP Otavio Salvador
@ 2018-11-25 20:29 ` Fabio Estevam
0 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2018-11-25 20:29 UTC (permalink / raw)
To: Otavio Salvador
Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel, Andreas Müller, Sascha Hauer,
Russell King - ARM Linux, NXP Linux Team, Sascha Hauer,
Fabio Estevam, Shawn Guo
On Sun, Nov 25, 2018 at 6:18 PM Otavio Salvador <otavio@ossystems.com.br> wrote:
>
> From: Andreas Müller <schnitzeltony@gmail.com>
>
> This is necessary to support network over bluetooth:
>
> | Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: kernel lacks bnep-protocol support
> | Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: System does not support network plugin
>
> Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/3] ARM: imx_v6_v7_defconfig: Enable USB_ANNOUNCE_NEW_DEVICES
2018-11-25 20:17 [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND Otavio Salvador
2018-11-25 20:17 ` [PATCH 2/3] ARM: imx_v6_v7_defconfig: Enable BT_BNEP Otavio Salvador
@ 2018-11-25 20:17 ` Otavio Salvador
2018-11-25 20:30 ` Fabio Estevam
2018-11-25 20:29 ` [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND Fabio Estevam
2 siblings, 1 reply; 8+ messages in thread
From: Otavio Salvador @ 2018-11-25 20:17 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: Andreas Müller, Otavio Salvador, Fabio Estevam,
Pengutronix Kernel Team, Sascha Hauer, Russell King, Shawn Guo,
NXP Linux Team
From: Andreas Müller <schnitzeltony@gmail.com>
This is very helpful debugging USB issues.
Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
arch/arm/configs/imx_v6_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 22ad2d7a1cf2..d339913845fa 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -305,6 +305,7 @@ CONFIG_SND_SOC_WM8962=y
CONFIG_SND_SIMPLE_CARD=y
CONFIG_HID_MULTITOUCH=y
CONFIG_USB=y
+CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_EHCI_MXC=y
CONFIG_USB_STORAGE=y
--
2.19.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] ARM: imx_v6_v7_defconfig: Enable USB_ANNOUNCE_NEW_DEVICES
2018-11-25 20:17 ` [PATCH 3/3] ARM: imx_v6_v7_defconfig: Enable USB_ANNOUNCE_NEW_DEVICES Otavio Salvador
@ 2018-11-25 20:30 ` Fabio Estevam
0 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2018-11-25 20:30 UTC (permalink / raw)
To: Otavio Salvador
Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel, Andreas Müller, Sascha Hauer,
Russell King - ARM Linux, NXP Linux Team, Sascha Hauer,
Fabio Estevam, Shawn Guo
On Sun, Nov 25, 2018 at 6:18 PM Otavio Salvador <otavio@ossystems.com.br> wrote:
>
> From: Andreas Müller <schnitzeltony@gmail.com>
>
> This is very helpful debugging USB issues.
>
> Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND
2018-11-25 20:17 [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND Otavio Salvador
2018-11-25 20:17 ` [PATCH 2/3] ARM: imx_v6_v7_defconfig: Enable BT_BNEP Otavio Salvador
2018-11-25 20:17 ` [PATCH 3/3] ARM: imx_v6_v7_defconfig: Enable USB_ANNOUNCE_NEW_DEVICES Otavio Salvador
@ 2018-11-25 20:29 ` Fabio Estevam
2018-11-25 20:49 ` Otavio Salvador
2 siblings, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2018-11-25 20:29 UTC (permalink / raw)
To: Otavio Salvador
Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel, Sascha Hauer, Russell King - ARM Linux,
NXP Linux Team, Sascha Hauer, Fabio Estevam, Shawn Guo
Hi Otavio,
On Sun, Nov 25, 2018 at 6:18 PM Otavio Salvador <otavio@ossystems.com.br> wrote:
>
> The setting is removed when running a `savedefconfig` using the
> current setting set. It is being applied in preparation to some
"setting set" is a bit confusing.
> patches making changes to this defconfig.
It would be good to mention that CONFIG_ARM_UNWIND is still selected
automatically.
Otherwise it may give the impression that such functionality is being removed.
You could reword the commit log to something like this:
CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but it is
still selected by the Kconfig logic.
This is done in preparation to making further changes to this defconfig cleaner.
With the reworded commit log:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND
2018-11-25 20:29 ` [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND Fabio Estevam
@ 2018-11-25 20:49 ` Otavio Salvador
2018-11-25 20:55 ` Fabio Estevam
0 siblings, 1 reply; 8+ messages in thread
From: Otavio Salvador @ 2018-11-25 20:49 UTC (permalink / raw)
To: Fabio Estevam
Cc: Otavio Salvador, Sascha Hauer, Kernel development list,
Russell King, NXP Linux Team, Sascha Hauer, Fabio Estevam,
Shawn Guo, linux-arm-kernel
Hello Fabio,
On Sun, Nov 25, 2018 at 6:30 PM Fabio Estevam <festevam@gmail.com> wrote:
> On Sun, Nov 25, 2018 at 6:18 PM Otavio Salvador <otavio@ossystems.com.br> wrote:
> >
> > The setting is removed when running a `savedefconfig` using the
> > current setting set. It is being applied in preparation to some
>
> "setting set" is a bit confusing.
>
> > patches making changes to this defconfig.
>
> It would be good to mention that CONFIG_ARM_UNWIND is still selected
> automatically.
>
> Otherwise it may give the impression that such functionality is being removed.
>
> You could reword the commit log to something like this:
>
> CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but it is
> still selected by the Kconfig logic.
> This is done in preparation to making further changes to this defconfig cleaner.
In fact, was removed and now selected.
I changed the commit log as:
ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable
CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but
selected by the Kconfig logic. This is done in preparation to making
further changes to this defconfig cleaner.
Do you agree?
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND
2018-11-25 20:49 ` Otavio Salvador
@ 2018-11-25 20:55 ` Fabio Estevam
0 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2018-11-25 20:55 UTC (permalink / raw)
To: Otavio Salvador
Cc: Otavio Salvador, Sascha Hauer, linux-kernel,
Russell King - ARM Linux, NXP Linux Team, Sascha Hauer,
Fabio Estevam, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Otavio,
On Sun, Nov 25, 2018 at 6:49 PM Otavio Salvador
<otavio.salvador@ossystems.com.br> wrote:
> In fact, was removed and now selected.
Yes, correct. In 4.20-rc1 this option is automatically selected.
> I changed the commit log as:
>
> ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable
>
> CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but
> selected by the Kconfig logic. This is done in preparation to making
> further changes to this defconfig cleaner.
>
> Do you agree?
Looks good to me, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-11-25 20:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-25 20:17 [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND Otavio Salvador
2018-11-25 20:17 ` [PATCH 2/3] ARM: imx_v6_v7_defconfig: Enable BT_BNEP Otavio Salvador
2018-11-25 20:29 ` Fabio Estevam
2018-11-25 20:17 ` [PATCH 3/3] ARM: imx_v6_v7_defconfig: Enable USB_ANNOUNCE_NEW_DEVICES Otavio Salvador
2018-11-25 20:30 ` Fabio Estevam
2018-11-25 20:29 ` [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND Fabio Estevam
2018-11-25 20:49 ` Otavio Salvador
2018-11-25 20:55 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).