From: Ray Chi <raychi@google.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: mathias.nyman@linux.intel.com,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Albert Wang <albertccwang@google.com>,
Badhri Jagan Sridharan <badhri@google.com>,
Puma Hsu <pumahsu@google.com>
Subject: Re: [PATCH] usb: core: stop USB enumeration if too many retries
Date: Fri, 2 Sep 2022 17:28:24 +0800 [thread overview]
Message-ID: <CAPBYUsA1oARNuGus5uzxZ7Co+gJrm2V_axCPsyZHhp85cndaAg@mail.gmail.com> (raw)
In-Reply-To: <Yw4GH4U5ULV3VFSY@kroah.com>
On Tue, Aug 30, 2022 at 8:44 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Aug 26, 2022 at 03:58:39PM +0800, Ray Chi wrote:
> > If a broken accessory connected to a USB host, usbcore might
> > keep doing enumeration retries and it will take a long time to
> > cause system unstable.
> >
> > This patch provides a quirk to specific USB ports of the hub to
> > stop USB enumeration if needed.
>
> Where does it ever allow the port to handle new devices in the future if
> the device is removed and then a new one is added back? Or is the port
> just now dead for forever?
>
I modified the patch according to Alan's suggestion, so the port will
be working again
after clearing the quirk with the v2 patch.
> thanks,
>
> greg k-h
Thanks,
Ray
prev parent reply other threads:[~2022-09-02 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 7:58 [PATCH] usb: core: stop USB enumeration if too many retries Ray Chi
2022-08-26 14:55 ` Alan Stern
2022-08-26 17:53 ` Ray Chi
2022-08-26 19:02 ` Alan Stern
2022-08-30 12:44 ` Greg KH
2022-09-02 9:28 ` Ray Chi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPBYUsA1oARNuGus5uzxZ7Co+gJrm2V_axCPsyZHhp85cndaAg@mail.gmail.com \
--to=raychi@google.com \
--cc=albertccwang@google.com \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=pumahsu@google.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).