From: Alan Stern <stern@rowland.harvard.edu>
To: Ray Chi <raychi@google.com>
Cc: gregkh@linuxfoundation.org, mathias.nyman@linux.intel.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
albertccwang@google.com, badhri@google.com, pumahsu@google.com
Subject: Re: [PATCH] usb: core: stop USB enumeration if too many retries
Date: Fri, 26 Aug 2022 10:55:41 -0400 [thread overview]
Message-ID: <Ywje7UCqXridmRpw@rowland.harvard.edu> (raw)
In-Reply-To: <20220826075839.292615-1-raychi@google.com>
On Fri, Aug 26, 2022 at 03:58:39PM +0800, Ray Chi wrote:
> If a broken accessory connected to a USB host, usbcore might
> keep doing enumeration retries and it will take a long time to
> cause system unstable.
>
> This patch provides a quirk to specific USB ports of the hub to
> stop USB enumeration if needed.
Why only to specific ports?
> Signed-off-by: Ray Chi <raychi@google.com>
> ---
> drivers/usb/core/hub.c | 33 +++++++++++++++++++++++++++++++++
> include/linux/usb.h | 3 +++
> 2 files changed, 36 insertions(+)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 2633acde7ac1..0f4097440ffb 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -3081,6 +3081,28 @@ static int hub_port_reset(struct usb_hub *hub, int port1,
> return status;
> }
>
> +/* Stop enumerate if the port met errors and quirk is set */
> +static bool hub_port_stop_enumerate(struct usb_hub *hub, int port1, int retries)
> +{
> + struct usb_port *port_dev = hub->ports[port1 - 1];
> + struct usb_device *hdev = hub->hdev;
> +
> + if (retries < (PORT_INIT_TRIES - 1) / 2)
> + return false;
> +
> + /*
> + * Some USB hosts can't take a long time to keep doing enumeration
> + * retry. After doing half of the retries, we would turn off the port
> + * power to stop enumeration if the quirk is set.
> + */
> + if (port_dev->quirks & USB_PORT_QUIRK_STOP_ENUM) {
> + usb_hub_set_port_power(hdev, hub, port1, false);
Why turn the port power off? Aren't there better ways to stop the
enumeration attempts? When will the power ever get turned back on?
Why not use the initial_descriptor_timeout module parameter for this
purpose? That's the sort of thing it was meant for.
Alan Stern
next prev parent reply other threads:[~2022-08-26 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 7:58 [PATCH] usb: core: stop USB enumeration if too many retries Ray Chi
2022-08-26 14:55 ` Alan Stern [this message]
2022-08-26 17:53 ` Ray Chi
2022-08-26 19:02 ` Alan Stern
2022-08-30 12:44 ` Greg KH
2022-09-02 9:28 ` Ray Chi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ywje7UCqXridmRpw@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=albertccwang@google.com \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=pumahsu@google.com \
--cc=raychi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).