* [PATCH] arm64: dts: qcom: add Venus firmware node on Cheza
@ 2020-01-07 14:34 Alexandre Courbot
2020-01-07 14:50 ` Stanimir Varbanov
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Courbot @ 2020-01-07 14:34 UTC (permalink / raw)
To: Stanimir Varbanov
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, Alexandre Courbot
Cheza boards require this node to probe, so add it.
Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
---
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 6 ++++++
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
index 9a4ff57fc877..35ba65cd9822 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
@@ -1279,3 +1279,9 @@ config {
};
};
};
+
+&venus_codec {
+ video-firmware {
+ iommus = <&apps_smmu 0x10b2 0x0>;
+ };
+};
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index ddb1f23c936f..7b913688cc6d 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -2567,7 +2567,7 @@ usb_2_dwc3: dwc3@a800000 {
};
};
- video-codec@aa00000 {
+ venus_codec: video-codec@aa00000 {
compatible = "qcom,sdm845-venus";
reg = <0 0x0aa00000 0 0xff000>;
interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
--
2.24.1.735.g03f4e72817-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: add Venus firmware node on Cheza
2020-01-07 14:34 [PATCH] arm64: dts: qcom: add Venus firmware node on Cheza Alexandre Courbot
@ 2020-01-07 14:50 ` Stanimir Varbanov
2020-01-07 17:42 ` Rob Clark
2020-01-08 3:27 ` Alexandre Courbot
0 siblings, 2 replies; 5+ messages in thread
From: Stanimir Varbanov @ 2020-01-07 14:50 UTC (permalink / raw)
To: Alexandre Courbot, Stanimir Varbanov
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel
Hi Alex,
On 1/7/20 4:34 PM, Alexandre Courbot wrote:
> Cheza boards require this node to probe, so add it.
>
> Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 6 ++++++
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> index 9a4ff57fc877..35ba65cd9822 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> @@ -1279,3 +1279,9 @@ config {
> };
> };
> };
> +
> +&venus_codec {
We have similar patch for sc7180 and call it just "venus". Do you think
we should shorten it here too?
> + video-firmware {
> + iommus = <&apps_smmu 0x10b2 0x0>;
> + };
> +};
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index ddb1f23c936f..7b913688cc6d 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -2567,7 +2567,7 @@ usb_2_dwc3: dwc3@a800000 {
> };
> };
>
> - video-codec@aa00000 {
> + venus_codec: video-codec@aa00000 {
> compatible = "qcom,sdm845-venus";
> reg = <0 0x0aa00000 0 0xff000>;
> interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
>
--
regards,
Stan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: add Venus firmware node on Cheza
2020-01-07 14:50 ` Stanimir Varbanov
@ 2020-01-07 17:42 ` Rob Clark
2020-01-08 8:31 ` Stanimir Varbanov
2020-01-08 3:27 ` Alexandre Courbot
1 sibling, 1 reply; 5+ messages in thread
From: Rob Clark @ 2020-01-07 17:42 UTC (permalink / raw)
To: Stanimir Varbanov
Cc: Alexandre Courbot, linux-media, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
On Tue, Jan 7, 2020 at 6:51 AM Stanimir Varbanov
<stanimir.varbanov@linaro.org> wrote:
>
> Hi Alex,
>
> On 1/7/20 4:34 PM, Alexandre Courbot wrote:
> > Cheza boards require this node to probe, so add it.
> >
> > Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
> > ---
> > arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 6 ++++++
> > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> > 2 files changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> > index 9a4ff57fc877..35ba65cd9822 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> > @@ -1279,3 +1279,9 @@ config {
> > };
> > };
> > };
> > +
> > +&venus_codec {
>
> We have similar patch for sc7180 and call it just "venus". Do you think
> we should shorten it here too?
>
> > + video-firmware {
> > + iommus = <&apps_smmu 0x10b2 0x0>;
> > + };
btw Stan, not sure if you noticed, but Bjorn started adding
firmware-name properties so we can have different device specific
subdirectories for signed fw (ie. so one /lib/firmware can work on
multiple different devices). I'm just looking at doing the same thing
for gpu zap fw. Afaiu the venus fw is also signed, so I guess it
could benefit from the same treatment? Not sure if that is something
you've already talked with Bjorn about?
BR,
-R
> > +};
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > index ddb1f23c936f..7b913688cc6d 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > @@ -2567,7 +2567,7 @@ usb_2_dwc3: dwc3@a800000 {
> > };
> > };
> >
> > - video-codec@aa00000 {
> > + venus_codec: video-codec@aa00000 {
> > compatible = "qcom,sdm845-venus";
> > reg = <0 0x0aa00000 0 0xff000>;
> > interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> >
>
> --
> regards,
> Stan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: add Venus firmware node on Cheza
2020-01-07 17:42 ` Rob Clark
@ 2020-01-08 8:31 ` Stanimir Varbanov
0 siblings, 0 replies; 5+ messages in thread
From: Stanimir Varbanov @ 2020-01-08 8:31 UTC (permalink / raw)
To: Rob Clark, Stanimir Varbanov
Cc: Alexandre Courbot, linux-media, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List, Vikash Garodia
On 1/7/20 7:42 PM, Rob Clark wrote:
> On Tue, Jan 7, 2020 at 6:51 AM Stanimir Varbanov
> <stanimir.varbanov@linaro.org> wrote:
>>
>> Hi Alex,
>>
>> On 1/7/20 4:34 PM, Alexandre Courbot wrote:
>>> Cheza boards require this node to probe, so add it.
>>>
>>> Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
>>> ---
>>> arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 6 ++++++
>>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
>>> 2 files changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
>>> index 9a4ff57fc877..35ba65cd9822 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
>>> @@ -1279,3 +1279,9 @@ config {
>>> };
>>> };
>>> };
>>> +
>>> +&venus_codec {
>>
>> We have similar patch for sc7180 and call it just "venus". Do you think
>> we should shorten it here too?
>>
>>> + video-firmware {
>>> + iommus = <&apps_smmu 0x10b2 0x0>;
>>> + };
>
>
> btw Stan, not sure if you noticed, but Bjorn started adding
> firmware-name properties so we can have different device specific
> subdirectories for signed fw (ie. so one /lib/firmware can work on
> multiple different devices). I'm just looking at doing the same thing
> for gpu zap fw. Afaiu the venus fw is also signed, so I guess it
> could benefit from the same treatment? Not sure if that is something
> you've already talked with Bjorn about?
I have to check does Venus fw is signed with device specific keys or
with something else (like HMAC).
Cc: Vikash for opinion
>
> BR,
> -R
>
>>> +};
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>>> index ddb1f23c936f..7b913688cc6d 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>>> @@ -2567,7 +2567,7 @@ usb_2_dwc3: dwc3@a800000 {
>>> };
>>> };
>>>
>>> - video-codec@aa00000 {
>>> + venus_codec: video-codec@aa00000 {
>>> compatible = "qcom,sdm845-venus";
>>> reg = <0 0x0aa00000 0 0xff000>;
>>> interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
>>>
>>
>> --
>> regards,
>> Stan
--
regards,
Stan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: add Venus firmware node on Cheza
2020-01-07 14:50 ` Stanimir Varbanov
2020-01-07 17:42 ` Rob Clark
@ 2020-01-08 3:27 ` Alexandre Courbot
1 sibling, 0 replies; 5+ messages in thread
From: Alexandre Courbot @ 2020-01-08 3:27 UTC (permalink / raw)
To: Stanimir Varbanov
Cc: Linux Media Mailing List, linux-arm-msm, devicetree, LKML
On Tue, Jan 7, 2020 at 11:50 PM Stanimir Varbanov
<stanimir.varbanov@linaro.org> wrote:
>
> Hi Alex,
>
> On 1/7/20 4:34 PM, Alexandre Courbot wrote:
> > Cheza boards require this node to probe, so add it.
> >
> > Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
> > ---
> > arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 6 ++++++
> > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> > 2 files changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> > index 9a4ff57fc877..35ba65cd9822 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> > @@ -1279,3 +1279,9 @@ config {
> > };
> > };
> > };
> > +
> > +&venus_codec {
>
> We have similar patch for sc7180 and call it just "venus". Do you think
> we should shorten it here too?
Sure - sent a v2 with that change.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-08 8:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-07 14:34 [PATCH] arm64: dts: qcom: add Venus firmware node on Cheza Alexandre Courbot
2020-01-07 14:50 ` Stanimir Varbanov
2020-01-07 17:42 ` Rob Clark
2020-01-08 8:31 ` Stanimir Varbanov
2020-01-08 3:27 ` Alexandre Courbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).