From: Ulf Hansson <ulf.hansson@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Ludovic Desroches" <ludovic.desroches@microchip.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Manuel Lauss" <manuel.lauss@gmail.com>,
"Kishon Vijay Abraham I" <kishon@ti.com>,
"Prabu Thangamuthu" <prabu.t@synopsys.com>,
"Manjunath M B" <manjumb@synopsys.com>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
linux-stm32@st-md-mailman.stormreply.com,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux-omap <linux-omap@vger.kernel.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
linux-tegra <linux-tegra@vger.kernel.org>,
linux-arm-kernel@axis.com,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Subject: Re: [PATCH v2 2/2] mmc: host: Enable compile testing of multiple drivers
Date: Mon, 7 Sep 2020 12:07:30 +0200 [thread overview]
Message-ID: <CAPDyKFo2Kqcpjb7QmsNgyD_kji2vXt3G2SqdDp9DUnvotKyojA@mail.gmail.com> (raw)
In-Reply-To: <20200904164315.24618-2-krzk@kernel.org>
On Fri, 4 Sep 2020 at 18:43, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Multiple MMC host controller driver can be compile tested as they do not
> depend on architecture specific headers.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
I tried to apply this, but there was a conflict around the SDHCI_S3C.
Can you please rebase.
Kind regards
Uffe
>
> ---
>
> Changes since v1:
> 1. Add COMMON_CLK dependency to MESON_GX to fix errors like:
> ERROR: modpost: "devm_clk_register" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
> ---
> drivers/mmc/host/Kconfig | 41 +++++++++++++++++++++-------------------
> 1 file changed, 22 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index eea01fde0591..93db789cf8ec 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -178,7 +178,7 @@ config MMC_SDHCI_OF_AT91
> config MMC_SDHCI_OF_ESDHC
> tristate "SDHCI OF support for the Freescale eSDHC controller"
> depends on MMC_SDHCI_PLTFM
> - depends on PPC || ARCH_MXC || ARCH_LAYERSCAPE
> + depends on PPC || ARCH_MXC || ARCH_LAYERSCAPE || COMPILE_TEST
> select MMC_SDHCI_IO_ACCESSORS
> select FSL_GUTS
> help
> @@ -216,7 +216,7 @@ config MMC_SDHCI_OF_DWCMSHC
> config MMC_SDHCI_OF_SPARX5
> tristate "SDHCI OF support for the MCHP Sparx5 SoC"
> depends on MMC_SDHCI_PLTFM
> - depends on ARCH_SPARX5
> + depends on ARCH_SPARX5 || COMPILE_TEST
> help
> This selects the Secure Digital Host Controller Interface (SDHCI)
> found in the MCHP Sparx5 SoC.
> @@ -238,7 +238,7 @@ config MMC_SDHCI_CADENCE
>
> config MMC_SDHCI_CNS3XXX
> tristate "SDHCI support on the Cavium Networks CNS3xxx SoC"
> - depends on ARCH_CNS3XXX
> + depends on ARCH_CNS3XXX || COMPILE_TEST
> depends on MMC_SDHCI_PLTFM
> help
> This selects the SDHCI support for CNS3xxx System-on-Chip devices.
> @@ -262,7 +262,7 @@ config MMC_SDHCI_ESDHC_MCF
>
> config MMC_SDHCI_ESDHC_IMX
> tristate "SDHCI support for the Freescale eSDHC/uSDHC i.MX controller"
> - depends on ARCH_MXC
> + depends on ARCH_MXC || COMPILE_TEST
> depends on MMC_SDHCI_PLTFM
> select MMC_SDHCI_IO_ACCESSORS
> select MMC_CQHCI
> @@ -276,7 +276,7 @@ config MMC_SDHCI_ESDHC_IMX
>
> config MMC_SDHCI_DOVE
> tristate "SDHCI support on Marvell's Dove SoC"
> - depends on ARCH_DOVE || MACH_DOVE
> + depends on ARCH_DOVE || MACH_DOVE || COMPILE_TEST
> depends on MMC_SDHCI_PLTFM
> select MMC_SDHCI_IO_ACCESSORS
> help
> @@ -289,7 +289,7 @@ config MMC_SDHCI_DOVE
>
> config MMC_SDHCI_TEGRA
> tristate "SDHCI platform support for the Tegra SD/MMC Controller"
> - depends on ARCH_TEGRA
> + depends on ARCH_TEGRA || COMPILE_TEST
> depends on MMC_SDHCI_PLTFM
> select MMC_SDHCI_IO_ACCESSORS
> select MMC_CQHCI
> @@ -301,7 +301,8 @@ config MMC_SDHCI_TEGRA
>
> config MMC_SDHCI_S3C
> tristate "SDHCI support on Samsung S3C SoC"
> - depends on MMC_SDHCI && (PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS)
> + depends on MMC_SDHCI
> + depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
> help
> This selects the Secure Digital Host Controller Interface (SDHCI)
> often referrered to as the HSMMC block in some of the Samsung S3C
> @@ -313,7 +314,7 @@ config MMC_SDHCI_S3C
>
> config MMC_SDHCI_SIRF
> tristate "SDHCI support on CSR SiRFprimaII and SiRFmarco SoCs"
> - depends on ARCH_SIRF
> + depends on ARCH_SIRF || COMPILE_TEST
> depends on MMC_SDHCI_PLTFM
> select MMC_SDHCI_IO_ACCESSORS
> help
> @@ -351,7 +352,8 @@ config MMC_SDHCI_PXAV2
>
> config MMC_SDHCI_SPEAR
> tristate "SDHCI support on ST SPEAr platform"
> - depends on MMC_SDHCI && PLAT_SPEAR
> + depends on MMC_SDHCI
> + depends on PLAT_SPEAR || COMPILE_TEST
> depends on OF
> help
> This selects the Secure Digital Host Controller Interface (SDHCI)
> @@ -374,7 +376,7 @@ config MMC_SDHCI_S3C_DMA
>
> config MMC_SDHCI_BCM_KONA
> tristate "SDHCI support on Broadcom KONA platform"
> - depends on ARCH_BCM_MOBILE
> + depends on ARCH_BCM_MOBILE || COMPILE_TEST
> depends on MMC_SDHCI_PLTFM
> help
> This selects the Broadcom Kona Secure Digital Host Controller
> @@ -422,7 +424,8 @@ config MMC_SDHCI_IPROC
>
> config MMC_MESON_GX
> tristate "Amlogic S905/GX*/AXG SD/MMC Host Controller support"
> - depends on ARCH_MESON
> + depends on ARCH_MESON || COMPILE_TEST
> + depends on COMMON_CLK
> help
> This selects support for the Amlogic SD/MMC Host Controller
> found on the S905/GX*/AXG family of SoCs. This controller is
> @@ -458,7 +461,7 @@ config MMC_MESON_MX_SDIO
>
> config MMC_MOXART
> tristate "MOXART SD/MMC Host Controller support"
> - depends on ARCH_MOXART
> + depends on ARCH_MOXART || COMPILE_TEST
> help
> This selects support for the MOXART SD/MMC Host Controller.
> MOXA provides one multi-functional card reader which can
> @@ -467,7 +470,7 @@ config MMC_MOXART
>
> config MMC_SDHCI_ST
> tristate "SDHCI support on STMicroelectronics SoC"
> - depends on ARCH_STI || FSP2
> + depends on ARCH_STI || FSP2 || COMPILE_TEST
> depends on MMC_SDHCI_PLTFM
> select MMC_SDHCI_IO_ACCESSORS
> help
> @@ -587,7 +590,7 @@ config MMC_TIFM_SD
>
> config MMC_MVSDIO
> tristate "Marvell MMC/SD/SDIO host driver"
> - depends on PLAT_ORION
> + depends on PLAT_ORION || (COMPILE_TEST && ARM)
> depends on OF
> help
> This selects the Marvell SDIO host driver.
> @@ -599,7 +602,7 @@ config MMC_MVSDIO
>
> config MMC_DAVINCI
> tristate "TI DAVINCI Multimedia Card Interface support"
> - depends on ARCH_DAVINCI
> + depends on ARCH_DAVINCI || COMPILE_TEST
> help
> This selects the TI DAVINCI Multimedia card Interface.
> If you have an DAVINCI board with a Multimedia Card slot,
> @@ -628,7 +631,7 @@ config MMC_SPI
>
> config MMC_S3C
> tristate "Samsung S3C SD/MMC Card Interface support"
> - depends on ARCH_S3C24XX
> + depends on ARCH_S3C24XX || COMPILE_TEST
> depends on S3C24XX_DMAC
> help
> This selects a driver for the MCI interface found in
> @@ -681,7 +684,7 @@ config MMC_SDRICOH_CS
>
> config MMC_SDHCI_SPRD
> tristate "Spreadtrum SDIO host Controller"
> - depends on ARCH_SPRD
> + depends on ARCH_SPRD || COMPILE_TEST
> depends on MMC_SDHCI_PLTFM
> select MMC_SDHCI_IO_ACCESSORS
> select MMC_HSQ
> @@ -698,7 +701,7 @@ config MMC_TMIO_CORE
>
> config MMC_TMIO
> tristate "Toshiba Mobile IO Controller (TMIO) MMC/SD function support"
> - depends on MFD_TMIO || MFD_ASIC3
> + depends on MFD_TMIO || MFD_ASIC3 || COMPILE_TEST
> select MMC_TMIO_CORE
> help
> This provides support for the SD/MMC cell found in TC6393XB,
> @@ -971,7 +974,7 @@ config MMC_REALTEK_USB
>
> config MMC_SUNXI
> tristate "Allwinner sunxi SD/MMC Host Controller support"
> - depends on ARCH_SUNXI
> + depends on ARCH_SUNXI || COMPILE_TEST
> help
> This selects support for the SD/MMC Host Controller on
> Allwinner sunxi SoCs.
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-09-07 10:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 16:43 [PATCH v2 1/2] mmc: host: Drop unneeded MMC dependency in Kconfig Krzysztof Kozlowski
2020-09-04 16:43 ` [PATCH v2 2/2] mmc: host: Enable compile testing of multiple drivers Krzysztof Kozlowski
2020-09-07 10:07 ` Ulf Hansson [this message]
2020-09-07 10:07 ` [PATCH v2 1/2] mmc: host: Drop unneeded MMC dependency in Kconfig Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFo2Kqcpjb7QmsNgyD_kji2vXt3G2SqdDp9DUnvotKyojA@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=kishon@ti.com \
--cc=krzk@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=manjumb@synopsys.com \
--cc=manuel.lauss@gmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=nicolas.ferre@microchip.com \
--cc=prabu.t@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).