From: Ulf Hansson <ulf.hansson@linaro.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Sudeep Holla <sudeep.holla@arm.com>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Linux PM <linux-pm@vger.kernel.org>,
Kevin Hilman <khilman@kernel.org>,
Lina Iyer <ilina@codeaurora.org>,
Lina Iyer <lina.iyer@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vincent Guittot <vincent.guittot@linaro.org>,
Stephen Boyd <sboyd@kernel.org>, Juri Lelli <juri.lelli@arm.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v7 11/26] of: base: Add of_get_cpu_state_node() to get idle states for a CPU node
Date: Sun, 15 Apr 2018 13:59:55 +0200 [thread overview]
Message-ID: <CAPDyKFo8wMetVmUBok_PmhZ6tHLKKn0_23j3PRfyBmXzeMF4VA@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqL=i1mXSW-x2CRAHoyAxG+QtGL1YLGwpJdpQbizrqzv-w@mail.gmail.com>
On 13 April 2018 at 17:05, Rob Herring <robh+dt@kernel.org> wrote:
> On Thu, Apr 12, 2018 at 6:14 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>> The CPU's idle state nodes are currently parsed at the common cpuidle DT
>> library, but also when initializing back-end data for the arch specific CPU
>> operations, as in the PSCI driver case.
>>
>> To avoid open-coding, let's introduce of_get_cpu_state_node(), which takes
>> the device node for the CPU and the index to the requested idle state node,
>> as in-parameters. In case a corresponding idle state node is found, it
>> returns the node with the refcount incremented for it, else it returns
>> NULL.
>>
>> Moreover, for ARM, there are two generic methods, to describe the CPU's
>> idle states, either via the flattened description through the
>> "cpu-idle-states" binding [1] or via the hierarchical layout, using the
>> "power-domains" and the "domain-idle-states" bindings [2]. Hence, let's
>> take both options into account.
>>
>> [1]
>> Documentation/devicetree/bindings/arm/idle-states.txt
>> [2]
>> Documentation/devicetree/bindings/arm/psci.txt
>>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: devicetree@vger.kernel.org
>> Cc: Lina Iyer <ilina@codeaurora.org>
>> Suggested-by: Sudeep Holla <sudeep.holla@arm.com>
>> Co-developed-by: Lina Iyer <lina.iyer@linaro.org>
>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>> ---
>> drivers/of/base.c | 35 +++++++++++++++++++++++++++++++++++
>> include/linux/of.h | 8 ++++++++
>> 2 files changed, 43 insertions(+)
>
> Some reason you didn't add my Reviewed-by from v6?
No, I was just sloppy. My apologies!
Kind regards
Uffe
next prev parent reply other threads:[~2018-04-15 12:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 11:14 [PATCH v7 00/26] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 01/26] PM / Domains: Don't treat zero found compatible idle states as an error Ulf Hansson
2018-04-16 17:33 ` Lina Iyer
2018-04-12 11:14 ` [PATCH v7 02/26] PM / Domains: Deal with multiple states but no governor in genpd Ulf Hansson
2018-04-16 17:34 ` Lina Iyer
2018-04-12 11:14 ` [PATCH v7 03/26] PM / Domains: Add generic data pointer to genpd_power_state struct Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 04/26] PM / Domains: Add support for CPU devices to genpd Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 05/26] PM / Domains: Add helper functions to attach/detach CPUs to/from genpd Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 06/26] timer: Export next wakeup time of a CPU Ulf Hansson
2018-04-13 8:47 ` Rafael J. Wysocki
2018-04-15 12:02 ` Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 07/26] PM / Domains: Add genpd governor for CPUs Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 08/26] PM / Domains: Extend genpd CPU governor to cope with QoS constraints Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 09/26] kernel/cpu_pm: Manage runtime PM in the idle path for CPUs Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 10/26] dt: psci: Update DT bindings to support hierarchical PSCI states Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 11/26] of: base: Add of_get_cpu_state_node() to get idle states for a CPU node Ulf Hansson
2018-04-13 15:05 ` Rob Herring
2018-04-15 11:59 ` Ulf Hansson [this message]
2018-04-12 11:14 ` [PATCH v7 12/26] cpuidle: dt: Support hierarchical CPU idle states Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 13/26] drivers: firmware: psci: Move psci to separate directory Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 14/26] MAINTAINERS: Update files for PSCI Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 15/26] drivers: firmware: psci: Split psci_dt_cpu_init_idle() Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 16/26] drivers: firmware: psci: Support hierarchical CPU idle states Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 17/26] drivers: firmware: psci: Simplify error path of psci_dt_init() Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 18/26] drivers: firmware: psci: Announce support for OS initiated suspend mode Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 19/26] drivers: firmware: psci: Prepare to use " Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 20/26] drivers: firmware: psci: Share a few internal PSCI functions Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 21/26] drivers: firmware: psci: Add support for PM domains using genpd Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 22/26] drivers: firmware: psci: Introduce psci_dt_topology_init() Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 23/26] drivers: firmware: psci: Try to attach CPU devices to their PM domains Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 24/26] drivers: firmware: psci: Deal with CPU hotplug when using OSI mode Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 25/26] arm64: kernel: Respect the hierarchical CPU topology in DT for PSCI Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 26/26] arm64: dts: Convert to the hierarchical CPU topology layout for MSM8916 Ulf Hansson
2018-05-24 9:16 ` [PATCH v7 00/26] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFo8wMetVmUBok_PmhZ6tHLKKn0_23j3PRfyBmXzeMF4VA@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=ilina@codeaurora.org \
--cc=juri.lelli@arm.com \
--cc=khilman@kernel.org \
--cc=lina.iyer@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).