From: Ulf Hansson <ulf.hansson@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Sudeep Holla <sudeep.holla@arm.com>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Linux PM <linux-pm@vger.kernel.org>,
Kevin Hilman <khilman@kernel.org>,
Lina Iyer <ilina@codeaurora.org>,
Lina Iyer <lina.iyer@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vincent Guittot <vincent.guittot@linaro.org>,
Stephen Boyd <sboyd@kernel.org>, Juri Lelli <juri.lelli@arm.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v7 06/26] timer: Export next wakeup time of a CPU
Date: Sun, 15 Apr 2018 14:02:39 +0200 [thread overview]
Message-ID: <CAPDyKFrQ4eUcuNPp6nUak_LvEP1=FNZ4a8SCd-XwLkPuXv9oFQ@mail.gmail.com> (raw)
In-Reply-To: <CAJZ5v0j=TL7Pvc6W+ieJ1D3C-9mJKMzmkcSRoHnquAwZC_k+0w@mail.gmail.com>
On 13 April 2018 at 10:47, Rafael J. Wysocki <rafael@kernel.org> wrote:
> On Thu, Apr 12, 2018 at 1:14 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>> From: Lina Iyer <lina.iyer@linaro.org>
>>
>> Knowing the sleep duration of CPUs, is known to be needed while selecting
>> the most energy efficient idle state for a CPU or a group of CPUs.
>>
>> However, to be able to compute the sleep duration, we need to know at what
>> time the next expected wakeup is for the CPU. Therefore, let's export this
>> information via a new function, tick_nohz_get_next_wakeup(). Following
>> changes make use of it.
>>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>> Cc: Lina Iyer <ilina@codeaurora.org>
>> Cc: Frederic Weisbecker <fweisbec@gmail.com>
>> Cc: Ingo Molnar <mingo@kernel.org>
>> Signed-off-by: Lina Iyer <lina.iyer@linaro.org>
>> Co-developed-by: Ulf Hansson <ulf.hansson@linaro.org>
>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>> ---
>> include/linux/tick.h | 10 ++++++++++
>> kernel/time/tick-sched.c | 11 +++++++++++
>> 2 files changed, 21 insertions(+)
>>
>> diff --git a/include/linux/tick.h b/include/linux/tick.h
>> index 389aa25..d341811 100644
>> --- a/include/linux/tick.h
>> +++ b/include/linux/tick.h
>> @@ -125,6 +125,7 @@ extern bool tick_nohz_idle_got_tick(void);
>> extern ktime_t tick_nohz_get_sleep_length(ktime_t *delta_next);
>> extern unsigned long tick_nohz_get_idle_calls(void);
>> extern unsigned long tick_nohz_get_idle_calls_cpu(int cpu);
>> +extern ktime_t tick_nohz_get_next_wakeup(int cpu);
>> extern u64 get_cpu_idle_time_us(int cpu, u64 *last_update_time);
>> extern u64 get_cpu_iowait_time_us(int cpu, u64 *last_update_time);
>>
>> @@ -151,6 +152,15 @@ static inline ktime_t tick_nohz_get_sleep_length(ktime_t *delta_next)
>> *delta_next = TICK_NSEC;
>> return *delta_next;
>> }
>> +
>> +static inline ktime_t tick_nohz_get_next_wakeup(int cpu)
>> +{
>> + ktime_t t;
>> +
>> + /* Next wake up is the tick period, assume it starts now */
>> + return ktime_add(tick_nohz_get_sleep_length(&t), ktime_get());
>> +}
>
> Well, given that tick_nohz_get_sleep_length() is just the above in
> this case, wouldn't it be simpler to return ktime_add(ktime_get(),
> TICK_NSEC) from here?
Yes!
>
>> +
>> static inline u64 get_cpu_idle_time_us(int cpu, u64 *unused) { return -1; }
>> static inline u64 get_cpu_iowait_time_us(int cpu, u64 *unused) { return -1; }
>>
>> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
>> index 646645e..08db7f3 100644
>> --- a/kernel/time/tick-sched.c
>> +++ b/kernel/time/tick-sched.c
>> @@ -1098,6 +1098,17 @@ unsigned long tick_nohz_get_idle_calls(void)
>> return ts->idle_calls;
>> }
>>
>> +/**
>> + * tick_nohz_get_next_wakeup - return the next wake up of the CPU
>> + */
>> +ktime_t tick_nohz_get_next_wakeup(int cpu)
>> +{
>> + struct clock_event_device *dev =
>> + per_cpu(tick_cpu_device.evtdev, cpu);
>
> I would avoid breaking the line, honestly.
Alright, I have no problem with that.
[,,,]
Thanks for reviewing!
Kind regards
Uffe
next prev parent reply other threads:[~2018-04-15 12:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 11:14 [PATCH v7 00/26] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 01/26] PM / Domains: Don't treat zero found compatible idle states as an error Ulf Hansson
2018-04-16 17:33 ` Lina Iyer
2018-04-12 11:14 ` [PATCH v7 02/26] PM / Domains: Deal with multiple states but no governor in genpd Ulf Hansson
2018-04-16 17:34 ` Lina Iyer
2018-04-12 11:14 ` [PATCH v7 03/26] PM / Domains: Add generic data pointer to genpd_power_state struct Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 04/26] PM / Domains: Add support for CPU devices to genpd Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 05/26] PM / Domains: Add helper functions to attach/detach CPUs to/from genpd Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 06/26] timer: Export next wakeup time of a CPU Ulf Hansson
2018-04-13 8:47 ` Rafael J. Wysocki
2018-04-15 12:02 ` Ulf Hansson [this message]
2018-04-12 11:14 ` [PATCH v7 07/26] PM / Domains: Add genpd governor for CPUs Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 08/26] PM / Domains: Extend genpd CPU governor to cope with QoS constraints Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 09/26] kernel/cpu_pm: Manage runtime PM in the idle path for CPUs Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 10/26] dt: psci: Update DT bindings to support hierarchical PSCI states Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 11/26] of: base: Add of_get_cpu_state_node() to get idle states for a CPU node Ulf Hansson
2018-04-13 15:05 ` Rob Herring
2018-04-15 11:59 ` Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 12/26] cpuidle: dt: Support hierarchical CPU idle states Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 13/26] drivers: firmware: psci: Move psci to separate directory Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 14/26] MAINTAINERS: Update files for PSCI Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 15/26] drivers: firmware: psci: Split psci_dt_cpu_init_idle() Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 16/26] drivers: firmware: psci: Support hierarchical CPU idle states Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 17/26] drivers: firmware: psci: Simplify error path of psci_dt_init() Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 18/26] drivers: firmware: psci: Announce support for OS initiated suspend mode Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 19/26] drivers: firmware: psci: Prepare to use " Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 20/26] drivers: firmware: psci: Share a few internal PSCI functions Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 21/26] drivers: firmware: psci: Add support for PM domains using genpd Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 22/26] drivers: firmware: psci: Introduce psci_dt_topology_init() Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 23/26] drivers: firmware: psci: Try to attach CPU devices to their PM domains Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 24/26] drivers: firmware: psci: Deal with CPU hotplug when using OSI mode Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 25/26] arm64: kernel: Respect the hierarchical CPU topology in DT for PSCI Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 26/26] arm64: dts: Convert to the hierarchical CPU topology layout for MSM8916 Ulf Hansson
2018-05-24 9:16 ` [PATCH v7 00/26] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFrQ4eUcuNPp6nUak_LvEP1=FNZ4a8SCd-XwLkPuXv9oFQ@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=fweisbec@gmail.com \
--cc=geert+renesas@glider.be \
--cc=ilina@codeaurora.org \
--cc=juri.lelli@arm.com \
--cc=khilman@kernel.org \
--cc=lina.iyer@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).