* [PATCH V4] mmc: core: improve reasonableness of bus width setting for HS400es
@ 2018-07-17 9:14 Hongjie Fang
2018-07-24 5:49 ` Fang Hongjie(方洪杰)
2018-07-30 15:06 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Hongjie Fang @ 2018-07-17 9:14 UTC (permalink / raw)
To: ulf.hansson
Cc: shawn.lin, adrian.hunter, linus.walleij, wsa+renesas, bst,
chanho.min, kyle.roeschley, linux-mmc, linux-kernel,
Hongjie Fang
mmc_select_hs400es() calls mmc_select_bus_width() which will continue
to set 4bit transfer mode if fail to set 8bit mode. The bus width
should not be set to 4bit in HS400es.
When fail to set 8bit mode, need return error directly for HS400es.
Signed-off-by: Hongjie Fang <hongjiefang@asrmicro.com>
---
drivers/mmc/core/mmc.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 4466f5d..0dbc512 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -1338,8 +1338,12 @@ static int mmc_select_hs400es(struct mmc_card *card)
goto out_err;
err = mmc_select_bus_width(card);
- if (err < 0)
+ if (err != MMC_BUS_WIDTH_8) {
+ pr_err("%s: switch to 8bit bus width failed, err:%d\n",
+ mmc_hostname(host), err);
+ err = -EIO;
goto out_err;
+ }
/* Switch card to HS mode */
err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH V4] mmc: core: improve reasonableness of bus width setting for HS400es
2018-07-17 9:14 [PATCH V4] mmc: core: improve reasonableness of bus width setting for HS400es Hongjie Fang
@ 2018-07-24 5:49 ` Fang Hongjie(方洪杰)
2018-07-30 15:06 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Fang Hongjie(方洪杰) @ 2018-07-24 5:49 UTC (permalink / raw)
To: ulf.hansson
Cc: shawn.lin, adrian.hunter, linus.walleij, wsa+renesas, bst,
chanho.min, kyle.roeschley, linux-mmc, linux-kernel
> mmc_select_hs400es() calls mmc_select_bus_width() which will continue
> to set 4bit transfer mode if fail to set 8bit mode. The bus width
> should not be set to 4bit in HS400es.
>
> When fail to set 8bit mode, need return error directly for HS400es.
>
> Signed-off-by: Hongjie Fang <hongjiefang@asrmicro.com>
> ---
> drivers/mmc/core/mmc.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 4466f5d..0dbc512 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1338,8 +1338,12 @@ static int mmc_select_hs400es(struct mmc_card *card)
> goto out_err;
>
> err = mmc_select_bus_width(card);
> - if (err < 0)
> + if (err != MMC_BUS_WIDTH_8) {
> + pr_err("%s: switch to 8bit bus width failed, err:%d\n",
> + mmc_hostname(host), err);
> + err = -EIO;
> goto out_err;
> + }
>
> /* Switch card to HS mode */
> err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
> --
> 1.9.1
Ping.
Any suggestion for it?
B&R
Hongjie
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V4] mmc: core: improve reasonableness of bus width setting for HS400es
2018-07-17 9:14 [PATCH V4] mmc: core: improve reasonableness of bus width setting for HS400es Hongjie Fang
2018-07-24 5:49 ` Fang Hongjie(方洪杰)
@ 2018-07-30 15:06 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2018-07-30 15:06 UTC (permalink / raw)
To: Hongjie Fang
Cc: Shawn Lin, Adrian Hunter, Linus Walleij, Wolfram Sang,
Bastian Stender, Chanho Min, Kyle Roeschley, linux-mmc,
Linux Kernel Mailing List
On 17 July 2018 at 11:14, Hongjie Fang <hongjiefang@asrmicro.com> wrote:
> mmc_select_hs400es() calls mmc_select_bus_width() which will continue
> to set 4bit transfer mode if fail to set 8bit mode. The bus width
> should not be set to 4bit in HS400es.
>
> When fail to set 8bit mode, need return error directly for HS400es.
>
> Signed-off-by: Hongjie Fang <hongjiefang@asrmicro.com>
> ---
> drivers/mmc/core/mmc.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 4466f5d..0dbc512 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1338,8 +1338,12 @@ static int mmc_select_hs400es(struct mmc_card *card)
> goto out_err;
>
> err = mmc_select_bus_width(card);
> - if (err < 0)
> + if (err != MMC_BUS_WIDTH_8) {
> + pr_err("%s: switch to 8bit bus width failed, err:%d\n",
> + mmc_hostname(host), err);
> + err = -EIO;
> goto out_err;
ENOTSUPP seems more like the correct one.
Something like this:
err = err < 0 ? err : -ENOTSUPP;
> + }
>
> /* Switch card to HS mode */
> err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
> --
> 1.9.1
>
Kind regards
Uffe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-30 15:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-17 9:14 [PATCH V4] mmc: core: improve reasonableness of bus width setting for HS400es Hongjie Fang
2018-07-24 5:49 ` Fang Hongjie(方洪杰)
2018-07-30 15:06 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).