From: Ulf Hansson <ulf.hansson@linaro.org>
To: Colin King <colin.king@canonical.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: block: make function mmc_cqe_issue_type static
Date: Thu, 30 Nov 2017 14:09:45 +0100 [thread overview]
Message-ID: <CAPDyKFobBdiisrg4NnaNuM5xQiWMUuLEXcNveU8-EAnWp6_XYw@mail.gmail.com> (raw)
In-Reply-To: <20171130113738.3851-1-colin.king@canonical.com>
On 30 November 2017 at 12:37, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function mmc_cqe_issue_type is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/mmc/core/queue.c:62:21: warning: symbol 'mmc_cqe_issue_type'
> was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/core/queue.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
> index d8394007bc99..5db388081789 100644
> --- a/drivers/mmc/core/queue.c
> +++ b/drivers/mmc/core/queue.c
> @@ -59,8 +59,8 @@ static inline bool mmc_cqe_can_dcmd(struct mmc_host *host)
> return host->caps2 & MMC_CAP2_CQE_DCMD;
> }
>
> -enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host,
> - struct request *req)
> +static enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host,
> + struct request *req)
> {
> switch (req_op(req)) {
> case REQ_OP_DRV_IN:
> --
> 2.14.1
>
prev parent reply other threads:[~2017-11-30 13:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 11:37 [PATCH] mmc: block: make function mmc_cqe_issue_type static Colin King
2017-11-30 11:45 ` Adrian Hunter
2017-11-30 13:09 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFobBdiisrg4NnaNuM5xQiWMUuLEXcNveU8-EAnWp6_XYw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).