* [PATCH] mmc: block: make function mmc_cqe_issue_type static
@ 2017-11-30 11:37 Colin King
2017-11-30 11:45 ` Adrian Hunter
2017-11-30 13:09 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-11-30 11:37 UTC (permalink / raw)
To: Ulf Hansson, Linus Walleij, Adrian Hunter, linux-mmc
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function mmc_cqe_issue_type is local to the source and does
not need to be in global scope, so make it static.
Cleans up sparse warning:
drivers/mmc/core/queue.c:62:21: warning: symbol 'mmc_cqe_issue_type'
was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mmc/core/queue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
index d8394007bc99..5db388081789 100644
--- a/drivers/mmc/core/queue.c
+++ b/drivers/mmc/core/queue.c
@@ -59,8 +59,8 @@ static inline bool mmc_cqe_can_dcmd(struct mmc_host *host)
return host->caps2 & MMC_CAP2_CQE_DCMD;
}
-enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host,
- struct request *req)
+static enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host,
+ struct request *req)
{
switch (req_op(req)) {
case REQ_OP_DRV_IN:
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: block: make function mmc_cqe_issue_type static
2017-11-30 11:37 [PATCH] mmc: block: make function mmc_cqe_issue_type static Colin King
@ 2017-11-30 11:45 ` Adrian Hunter
2017-11-30 13:09 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2017-11-30 11:45 UTC (permalink / raw)
To: Colin King, Ulf Hansson, Linus Walleij, linux-mmc
Cc: kernel-janitors, linux-kernel
On 30/11/17 13:37, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function mmc_cqe_issue_type is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/mmc/core/queue.c:62:21: warning: symbol 'mmc_cqe_issue_type'
> was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/core/queue.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
> index d8394007bc99..5db388081789 100644
> --- a/drivers/mmc/core/queue.c
> +++ b/drivers/mmc/core/queue.c
> @@ -59,8 +59,8 @@ static inline bool mmc_cqe_can_dcmd(struct mmc_host *host)
> return host->caps2 & MMC_CAP2_CQE_DCMD;
> }
>
> -enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host,
> - struct request *req)
> +static enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host,
> + struct request *req)
> {
> switch (req_op(req)) {
> case REQ_OP_DRV_IN:
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: block: make function mmc_cqe_issue_type static
2017-11-30 11:37 [PATCH] mmc: block: make function mmc_cqe_issue_type static Colin King
2017-11-30 11:45 ` Adrian Hunter
@ 2017-11-30 13:09 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2017-11-30 13:09 UTC (permalink / raw)
To: Colin King
Cc: Linus Walleij, Adrian Hunter, linux-mmc, kernel-janitors, linux-kernel
On 30 November 2017 at 12:37, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function mmc_cqe_issue_type is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/mmc/core/queue.c:62:21: warning: symbol 'mmc_cqe_issue_type'
> was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/core/queue.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
> index d8394007bc99..5db388081789 100644
> --- a/drivers/mmc/core/queue.c
> +++ b/drivers/mmc/core/queue.c
> @@ -59,8 +59,8 @@ static inline bool mmc_cqe_can_dcmd(struct mmc_host *host)
> return host->caps2 & MMC_CAP2_CQE_DCMD;
> }
>
> -enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host,
> - struct request *req)
> +static enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host,
> + struct request *req)
> {
> switch (req_op(req)) {
> case REQ_OP_DRV_IN:
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-30 13:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-30 11:37 [PATCH] mmc: block: make function mmc_cqe_issue_type static Colin King
2017-11-30 11:45 ` Adrian Hunter
2017-11-30 13:09 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).