* [PATCH -next] mmc: sdhci-pci-gli: Make sdhci_pci_gli_resume static
@ 2020-05-07 12:20 Samuel Zou
2020-05-07 13:16 ` Ulf Hansson
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Zou @ 2020-05-07 12:20 UTC (permalink / raw)
To: adrian.hunter, ulf.hansson, linux-mmc, linux-kernel; +Cc: Samuel Zou
Fix the following sparse warning:
drivers/mmc/host/sdhci-pci-gli.c:343:5: warning:
symbol 'sdhci_pci_gli_resume' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Samuel Zou <zou_wei@huawei.com>
---
drivers/mmc/host/sdhci-pci-gli.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
index bdb6336..fd76aa6 100644
--- a/drivers/mmc/host/sdhci-pci-gli.c
+++ b/drivers/mmc/host/sdhci-pci-gli.c
@@ -340,7 +340,7 @@ static u32 sdhci_gl9750_readl(struct sdhci_host *host, int reg)
}
#ifdef CONFIG_PM_SLEEP
-int sdhci_pci_gli_resume(struct sdhci_pci_chip *chip)
+static int sdhci_pci_gli_resume(struct sdhci_pci_chip *chip)
{
struct sdhci_pci_slot *slot = chip->slots[0];
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mmc: sdhci-pci-gli: Make sdhci_pci_gli_resume static
2020-05-07 12:20 [PATCH -next] mmc: sdhci-pci-gli: Make sdhci_pci_gli_resume static Samuel Zou
@ 2020-05-07 13:16 ` Ulf Hansson
0 siblings, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2020-05-07 13:16 UTC (permalink / raw)
To: Samuel Zou; +Cc: Adrian Hunter, linux-mmc, Linux Kernel Mailing List
On Thu, 7 May 2020 at 14:14, Samuel Zou <zou_wei@huawei.com> wrote:
>
> Fix the following sparse warning:
>
> drivers/mmc/host/sdhci-pci-gli.c:343:5: warning:
> symbol 'sdhci_pci_gli_resume' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Samuel Zou <zou_wei@huawei.com>
This actually fixes a commit that I on my fixes branch, which is also
targeted for stable.
Therefore, I decided to squash this into the offending commit and
adding your sob tag, with a note about what you fixed.
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-pci-gli.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index bdb6336..fd76aa6 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -340,7 +340,7 @@ static u32 sdhci_gl9750_readl(struct sdhci_host *host, int reg)
> }
>
> #ifdef CONFIG_PM_SLEEP
> -int sdhci_pci_gli_resume(struct sdhci_pci_chip *chip)
> +static int sdhci_pci_gli_resume(struct sdhci_pci_chip *chip)
> {
> struct sdhci_pci_slot *slot = chip->slots[0];
>
> --
> 2.6.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mmc: sdhci-pci-gli: Make sdhci_pci_gli_resume static
@ 2020-05-08 7:32 Ben Chuang
0 siblings, 0 replies; 3+ messages in thread
From: Ben Chuang @ 2020-05-08 7:32 UTC (permalink / raw)
To: Samuel Zou, Ulf Hansson
Cc: Adrian Hunter, linux-mmc, Linux Kernel Mailing List
>>On Thu, 7 May 2020 at 14:14, Samuel Zou <zou_wei@huawei.com> wrote:
>>
>> Fix the following sparse warning:
>>
>> drivers/mmc/host/sdhci-pci-gli.c:343:5: warning:
>> symbol 'sdhci_pci_gli_resume' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Samuel Zou <zou_wei@huawei.com>
>
>This actually fixes a commit that I on my fixes branch, which is also
>targeted for stable.
>
>Therefore, I decided to squash this into the offending commit and
>adding your sob tag, with a note about what you fixed.
>
>Kind regards
>Uffe
>
Thanks Samuel for fixed this issue.
Thanks Ulf for your help.
PS.
I use this email to reply because the company's email will have a
confidentiality clause in the letter.
Best regards,
Ben Chuang
>> ---
>> drivers/mmc/host/sdhci-pci-gli.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
>> index bdb6336..fd76aa6 100644
>> --- a/drivers/mmc/host/sdhci-pci-gli.c
>> +++ b/drivers/mmc/host/sdhci-pci-gli.c
>> @@ -340,7 +340,7 @@ static u32 sdhci_gl9750_readl(struct sdhci_host *host, int reg)
>> }
>>
>> #ifdef CONFIG_PM_SLEEP
>>-int sdhci_pci_gli_resume(struct sdhci_pci_chip *chip)
>> +static int sdhci_pci_gli_resume(struct sdhci_pci_chip *chip)
>>{
>> struct sdhci_pci_slot *slot = chip->slots[0];
>>
>>--
>>2.6.2
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-08 7:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 12:20 [PATCH -next] mmc: sdhci-pci-gli: Make sdhci_pci_gli_resume static Samuel Zou
2020-05-07 13:16 ` Ulf Hansson
2020-05-08 7:32 Ben Chuang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).