* [PATCH 1/2] dt-bindings: mmc: add DT bindings for Milbeaut SD controller
@ 2019-04-26 2:06 Takao Orito
2019-04-29 10:24 ` Ulf Hansson
2019-05-02 0:44 ` Rob Herring
0 siblings, 2 replies; 5+ messages in thread
From: Takao Orito @ 2019-04-26 2:06 UTC (permalink / raw)
To: ulf.hansson, robh+dt, mark.rutland
Cc: linux-mmc, devicetree, linux-kernel, masami.hiramatsu,
jaswinder.singh, sugaya.taichi, kasai.kazuhiro, kanematsu.shinji,
orito.takao
Signed-off-by: Takao Orito <orito.takao@socionext.com>
---
.../devicetree/bindings/mmc/sdhci-milbeaut.txt | 35 ++++++++++++++++++++++
1 file changed, 35 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt b/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
new file mode 100644
index 0000000..7008462
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
@@ -0,0 +1,35 @@
+* SOCIONEXT SDHCI controller
+
+This file documents differences between the core properties in mmc.txt
+and the properties used by the sdhci_milbeaut driver.
+
+Required properties:
+- compatible: "socionext,milbeaut-m10v-sdhci-3.0"
+- clocks: Must contain an entry for each entry in clock-names. It is a
+ list of phandles and clock-specifier pairs.
+ See ../clocks/clock-bindings.txt for details.
+- clock-names: Should contain the following two entries:
+ "iface" - clock used for sdhci interface
+ "core" - core clock for sdhci controller
+
+Optional properties:
+- vqmmc-supply: phandle to the regulator device tree node, mentioned
+ as the VCCQ/VDD_IO supply in the eMMC/SD specs.
+- fujitsu,cmd-dat-delay-select: boolean property indicating that this host
+ requires the CMD_DAT_DELAY control to be enabled.
+- sni,mmc-power-gpio: set property indicating that power on or off needs
+ control of gpios.
+
+Example:
+ sdhci3: mmc@1b010000 {
+ compatible = "socionext,milbeaut-m10v-sdhci-3.0";
+ reg = <0x1b010000 0x10000>;
+ interrupts = <0 265 0x4>;
+ voltage-ranges = <3300 3300>;
+ bus-width = <4>;
+ clocks = <&clk 7>, <&ahb_clk>;
+ clock-names = "core", "iface";
+ cap-sdio-irq;
+ sni,mmc-power-gpio = <&pinctrl 53 GPIO_ACTIVE_HIGH>;
+ fujitsu,cmd-dat-delay-select;
+ };
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] dt-bindings: mmc: add DT bindings for Milbeaut SD controller
2019-04-26 2:06 [PATCH 1/2] dt-bindings: mmc: add DT bindings for Milbeaut SD controller Takao Orito
@ 2019-04-29 10:24 ` Ulf Hansson
2019-05-07 9:14 ` orito.takao
2019-05-02 0:44 ` Rob Herring
1 sibling, 1 reply; 5+ messages in thread
From: Ulf Hansson @ 2019-04-29 10:24 UTC (permalink / raw)
To: Takao Orito
Cc: Rob Herring, Mark Rutland, linux-mmc, DTML,
Linux Kernel Mailing List, Masami Hiramatsu, Jaswinder Singh,
sugaya.taichi, kasai.kazuhiro, kanematsu.shinji
On Fri, 26 Apr 2019 at 04:04, Takao Orito <orito.takao@socionext.com> wrote:
>
> Signed-off-by: Takao Orito <orito.takao@socionext.com>
> ---
> .../devicetree/bindings/mmc/sdhci-milbeaut.txt | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt b/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
> new file mode 100644
> index 0000000..7008462
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
> @@ -0,0 +1,35 @@
> +* SOCIONEXT SDHCI controller
> +
> +This file documents differences between the core properties in mmc.txt
> +and the properties used by the sdhci_milbeaut driver.
> +
> +Required properties:
> +- compatible: "socionext,milbeaut-m10v-sdhci-3.0"
> +- clocks: Must contain an entry for each entry in clock-names. It is a
> + list of phandles and clock-specifier pairs.
> + See ../clocks/clock-bindings.txt for details.
> +- clock-names: Should contain the following two entries:
> + "iface" - clock used for sdhci interface
> + "core" - core clock for sdhci controller
> +
> +Optional properties:
> +- vqmmc-supply: phandle to the regulator device tree node, mentioned
> + as the VCCQ/VDD_IO supply in the eMMC/SD specs.
> +- fujitsu,cmd-dat-delay-select: boolean property indicating that this host
> + requires the CMD_DAT_DELAY control to be enabled.
> +- sni,mmc-power-gpio: set property indicating that power on or off needs
> + control of gpios.
Please use a vmmc-supply instead of "power-gpio" (which means you need
to model this as a fixed GPIO regulator).
> +
> +Example:
> + sdhci3: mmc@1b010000 {
> + compatible = "socionext,milbeaut-m10v-sdhci-3.0";
> + reg = <0x1b010000 0x10000>;
> + interrupts = <0 265 0x4>;
> + voltage-ranges = <3300 3300>;
> + bus-width = <4>;
> + clocks = <&clk 7>, <&ahb_clk>;
> + clock-names = "core", "iface";
> + cap-sdio-irq;
> + sni,mmc-power-gpio = <&pinctrl 53 GPIO_ACTIVE_HIGH>;
> + fujitsu,cmd-dat-delay-select;
> + };
> --
> 1.9.1
>
>
Kind regards
Uffe
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] dt-bindings: mmc: add DT bindings for Milbeaut SD controller
2019-04-29 10:24 ` Ulf Hansson
@ 2019-05-07 9:14 ` orito.takao
0 siblings, 0 replies; 5+ messages in thread
From: orito.takao @ 2019-05-07 9:14 UTC (permalink / raw)
To: ulf.hansson
Cc: robh+dt, mark.rutland, linux-mmc, devicetree, linux-kernel,
masami.hiramatsu, jaswinder.singh, sugaya.taichi, kasai.kazuhiro,
kanematsu.shinji
Thank you for reviewing my patches.
Sorry for my late reply. Japan was in Spring Vacation.
> On Fri, 26 Apr 2019 at 04:04, Takao Orito <orito.takao@socionext.com> wrote:
> >
> > Signed-off-by: Takao Orito <orito.takao@socionext.com>
> > ---
> > .../devicetree/bindings/mmc/sdhci-milbeaut.txt | 35 ++++++++++++++++++++++
> > 1 file changed, 35 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt b/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
> > new file mode 100644
> > index 0000000..7008462
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
> > @@ -0,0 +1,35 @@
> > +* SOCIONEXT SDHCI controller
> > +
> > +This file documents differences between the core properties in mmc.txt
> > +and the properties used by the sdhci_milbeaut driver.
> > +
> > +Required properties:
> > +- compatible: "socionext,milbeaut-m10v-sdhci-3.0"
> > +- clocks: Must contain an entry for each entry in clock-names. It is a
> > + list of phandles and clock-specifier pairs.
> > + See ../clocks/clock-bindings.txt for details.
> > +- clock-names: Should contain the following two entries:
> > + "iface" - clock used for sdhci interface
> > + "core" - core clock for sdhci controller
> > +
> > +Optional properties:
> > +- vqmmc-supply: phandle to the regulator device tree node, mentioned
> > + as the VCCQ/VDD_IO supply in the eMMC/SD specs.
> > +- fujitsu,cmd-dat-delay-select: boolean property indicating that this host
> > + requires the CMD_DAT_DELAY control to be enabled.
> > +- sni,mmc-power-gpio: set property indicating that power on or off needs
> > + control of gpios.
>
> Please use a vmmc-supply instead of "power-gpio" (which means you need
> to model this as a fixed GPIO regulator).
OK, I will study about regulator/vmmc-supply and change to use it.
Thanks
Orito
>
> > +
> > +Example:
> > + sdhci3: mmc@1b010000 {
> > + compatible = "socionext,milbeaut-m10v-sdhci-3.0";
> > + reg = <0x1b010000 0x10000>;
> > + interrupts = <0 265 0x4>;
> > + voltage-ranges = <3300 3300>;
> > + bus-width = <4>;
> > + clocks = <&clk 7>, <&ahb_clk>;
> > + clock-names = "core", "iface";
> > + cap-sdio-irq;
> > + sni,mmc-power-gpio = <&pinctrl 53 GPIO_ACTIVE_HIGH>;
> > + fujitsu,cmd-dat-delay-select;
> > + };
> > --
> > 1.9.1
> >
> >
>
> Kind regards
> Uffe
--
Takao Orito <orito.takao@socionext.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mmc: add DT bindings for Milbeaut SD controller
2019-04-26 2:06 [PATCH 1/2] dt-bindings: mmc: add DT bindings for Milbeaut SD controller Takao Orito
2019-04-29 10:24 ` Ulf Hansson
@ 2019-05-02 0:44 ` Rob Herring
2019-05-07 9:20 ` orito.takao
1 sibling, 1 reply; 5+ messages in thread
From: Rob Herring @ 2019-05-02 0:44 UTC (permalink / raw)
To: Takao Orito
Cc: ulf.hansson, mark.rutland, linux-mmc, devicetree, linux-kernel,
masami.hiramatsu, jaswinder.singh, sugaya.taichi, kasai.kazuhiro,
kanematsu.shinji
On Fri, Apr 26, 2019 at 11:06:32AM +0900, Takao Orito wrote:
Needs a commit msg.
> Signed-off-by: Takao Orito <orito.takao@socionext.com>
> ---
> .../devicetree/bindings/mmc/sdhci-milbeaut.txt | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt b/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
> new file mode 100644
> index 0000000..7008462
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
> @@ -0,0 +1,35 @@
> +* SOCIONEXT SDHCI controller
> +
> +This file documents differences between the core properties in mmc.txt
> +and the properties used by the sdhci_milbeaut driver.
> +
> +Required properties:
> +- compatible: "socionext,milbeaut-m10v-sdhci-3.0"
> +- clocks: Must contain an entry for each entry in clock-names. It is a
> + list of phandles and clock-specifier pairs.
> + See ../clocks/clock-bindings.txt for details.
> +- clock-names: Should contain the following two entries:
> + "iface" - clock used for sdhci interface
> + "core" - core clock for sdhci controller
> +
> +Optional properties:
> +- vqmmc-supply: phandle to the regulator device tree node, mentioned
> + as the VCCQ/VDD_IO supply in the eMMC/SD specs.
> +- fujitsu,cmd-dat-delay-select: boolean property indicating that this host
> + requires the CMD_DAT_DELAY control to be enabled.
> +- sni,mmc-power-gpio: set property indicating that power on or off needs
> + control of gpios.
> +
> +Example:
> + sdhci3: mmc@1b010000 {
> + compatible = "socionext,milbeaut-m10v-sdhci-3.0";
> + reg = <0x1b010000 0x10000>;
> + interrupts = <0 265 0x4>;
> + voltage-ranges = <3300 3300>;
> + bus-width = <4>;
> + clocks = <&clk 7>, <&ahb_clk>;
> + clock-names = "core", "iface";
> + cap-sdio-irq;
> + sni,mmc-power-gpio = <&pinctrl 53 GPIO_ACTIVE_HIGH>;
> + fujitsu,cmd-dat-delay-select;
Whitespace problem.
> + };
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] dt-bindings: mmc: add DT bindings for Milbeaut SD controller
2019-05-02 0:44 ` Rob Herring
@ 2019-05-07 9:20 ` orito.takao
0 siblings, 0 replies; 5+ messages in thread
From: orito.takao @ 2019-05-07 9:20 UTC (permalink / raw)
To: robh
Cc: ulf.hansson, mark.rutland, linux-mmc, devicetree, linux-kernel,
masami.hiramatsu, jaswinder.singh, sugaya.taichi, kasai.kazuhiro,
kanematsu.shinji
Thank you for reviewing my patches.
Sorry for my late reply. Japan was in Spring Vacation.
> On Fri, Apr 26, 2019 at 11:06:32AM +0900, Takao Orito wrote:
>
> Needs a commit msg.
I see. I will add message.
>
> > Signed-off-by: Takao Orito <orito.takao@socionext.com>
> > ---
> > .../devicetree/bindings/mmc/sdhci-milbeaut.txt | 35 ++++++++++++++++++++++
> > 1 file changed, 35 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt b/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
> > new file mode 100644
> > index 0000000..7008462
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
> > @@ -0,0 +1,35 @@
> > +* SOCIONEXT SDHCI controller
> > +
> > +This file documents differences between the core properties in mmc.txt
> > +and the properties used by the sdhci_milbeaut driver.
> > +
> > +Required properties:
> > +- compatible: "socionext,milbeaut-m10v-sdhci-3.0"
> > +- clocks: Must contain an entry for each entry in clock-names. It is a
> > + list of phandles and clock-specifier pairs.
> > + See ../clocks/clock-bindings.txt for details.
> > +- clock-names: Should contain the following two entries:
> > + "iface" - clock used for sdhci interface
> > + "core" - core clock for sdhci controller
> > +
> > +Optional properties:
> > +- vqmmc-supply: phandle to the regulator device tree node, mentioned
> > + as the VCCQ/VDD_IO supply in the eMMC/SD specs.
> > +- fujitsu,cmd-dat-delay-select: boolean property indicating that this host
> > + requires the CMD_DAT_DELAY control to be enabled.
> > +- sni,mmc-power-gpio: set property indicating that power on or off needs
> > + control of gpios.
> > +
> > +Example:
> > + sdhci3: mmc@1b010000 {
> > + compatible = "socionext,milbeaut-m10v-sdhci-3.0";
> > + reg = <0x1b010000 0x10000>;
> > + interrupts = <0 265 0x4>;
> > + voltage-ranges = <3300 3300>;
> > + bus-width = <4>;
> > + clocks = <&clk 7>, <&ahb_clk>;
> > + clock-names = "core", "iface";
> > + cap-sdio-irq;
> > + sni,mmc-power-gpio = <&pinctrl 53 GPIO_ACTIVE_HIGH>;
> > + fujitsu,cmd-dat-delay-select;
>
> Whitespace problem.
Sorry, I will fix.
Thanks
Orito
>
> > + };
> > --
> > 1.9.1
> >
> >
--
Takao Orito <orito.takao@socionext.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-07 9:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-26 2:06 [PATCH 1/2] dt-bindings: mmc: add DT bindings for Milbeaut SD controller Takao Orito
2019-04-29 10:24 ` Ulf Hansson
2019-05-07 9:14 ` orito.takao
2019-05-02 0:44 ` Rob Herring
2019-05-07 9:20 ` orito.takao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).