From: Ulf Hansson <ulf.hansson@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Kevin Hilman <khilman@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Len Brown <len.brown@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] PM / Domains: Convert to using %pOF instead of full_name
Date: Fri, 21 Jul 2017 09:56:52 +0200 [thread overview]
Message-ID: <CAPDyKFpBGY+xZyubW6HdQyoJ1GVkEM04ZiJSB_hOq_gpjqZ4CQ@mail.gmail.com> (raw)
In-Reply-To: <20170718214339.7774-10-robh@kernel.org>
On 18 July 2017 at 23:42, Rob Herring <robh@kernel.org> wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Kevin Hilman <khilman@kernel.org>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Len Brown <len.brown@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-pm@vger.kernel.org
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
> ---
> drivers/base/power/domain.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 3b8210ebb50e..d0989f9b5e67 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1743,7 +1743,7 @@ static int genpd_add_provider(struct device_node *np, genpd_xlate_t xlate,
> mutex_lock(&of_genpd_mutex);
> list_add(&cp->link, &of_genpd_providers);
> mutex_unlock(&of_genpd_mutex);
> - pr_debug("Added domain provider from %s\n", np->full_name);
> + pr_debug("Added domain provider from %pOF\n", np);
>
> return 0;
> }
> @@ -2149,16 +2149,16 @@ static int genpd_parse_state(struct genpd_power_state *genpd_state,
> err = of_property_read_u32(state_node, "entry-latency-us",
> &entry_latency);
> if (err) {
> - pr_debug(" * %s missing entry-latency-us property\n",
> - state_node->full_name);
> + pr_debug(" * %pOF missing entry-latency-us property\n",
> + state_node);
> return -EINVAL;
> }
>
> err = of_property_read_u32(state_node, "exit-latency-us",
> &exit_latency);
> if (err) {
> - pr_debug(" * %s missing exit-latency-us property\n",
> - state_node->full_name);
> + pr_debug(" * %pOF missing exit-latency-us property\n",
> + state_node);
> return -EINVAL;
> }
>
> @@ -2212,8 +2212,8 @@ int of_genpd_parse_idle_states(struct device_node *dn,
> ret = genpd_parse_state(&st[i++], np);
> if (ret) {
> pr_err
> - ("Parsing idle state node %s failed with err %d\n",
> - np->full_name, ret);
> + ("Parsing idle state node %pOF failed with err %d\n",
> + np, ret);
> of_node_put(np);
> kfree(st);
> return ret;
> --
> 2.11.0
>
prev parent reply other threads:[~2017-07-21 7:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 21:42 [PATCH] PM / Domains: Convert to using %pOF instead of full_name Rob Herring
2017-07-19 9:18 ` Geert Uytterhoeven
2017-07-21 7:56 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFpBGY+xZyubW6HdQyoJ1GVkEM04ZiJSB_hOq_gpjqZ4CQ@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).