Re: drivers/mmc/cor/bus: Delete redundant match function

Re: drivers/mmc/cor/bus: Delete redundant match function

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 1760 bytes --]

On Wed, Nov 10, 2021 at 03:12:51AM +0800, 李哲 wrote:
> HI：
>      I failed to send kernel patch mail with git sendmail,
>     could  you help me take a look at the submitted patch?
>     the attachment is a patch file, 
>     For convenience, I put the content of the patch in the body of the email
> 
> 
>                                                                                             thanks.
>                                                                                             lizhe
> patch : 
> |
> From 40577316f4dbcf35061a14f27f7a777c2f4199a1 Mon Sep 17 00:00:00 2001
> From: lizhe <sensor1010@163.com>
> Date: Tue, 9 Nov 2021 10:13:43 -0800
> Subject: [PATCH] drivers/mmc/cor/bus: Delete redundant match function
> 
> 
> When the device and the driver are matching,
> if the device or the bus to which the device driver belongs
> does not provide a match function,
> then the device and the driver are matched by default.
> function 'driver_match_device' illustrates this mechanism.
> Because the return value of mmc_bus_match is 1,
> even if this function is not provided,
> the function 'driver_match_device' returns 1,
> so function 'mmc_bus_match' is redundant.
> 
> 
> Signed-off-by: lizhe <sensor1010@163.com>

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Apart from how the patch is put in the mail, a maintainer responsible
for picking patches up in this area will probably refuse because the
name in the From line of your mail doesn't match the name used in the
Signed-off-by: line.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Re: drivers/mmc/cor/bus: Delete redundant match function

[Ulf Hansson]

On Fri, 19 Nov 2021 at 13:45, lizhe <sensor1010@163.com> wrote:
>
>
> HI :
>         Does this patch need to be changed? If  need to modify something, please let me know and I will fix it soon
>
>                                                                                                                                                                            Thanks
>                                                                                                                                                                             lizhe

Hi Lizhe,

Please read Documentation/process/submitting-patches.rst carefully. It
guides you through the process of how to submit a patch.

For example, you need to use "git send-email" and we only use plain text emails.

Kind regards
Uffe

>
>
>
>
>
>
> At 2021-11-12 23:00:36, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> wrote:
> >On Wed, Nov 10, 2021 at 03:12:51AM +0800, 李哲 wrote:
> >> HI：
> >>      I failed to send kernel patch mail with git sendmail,
> >>     could  you help me take a look at the submitted patch?
> >>     the attachment is a patch file,
> >>     For convenience, I put the content of the patch in the body of the email
> >>
> >>
> >>                                                                                             thanks.
> >>                                                                                             lizhe
> >> patch :
> >> |
> >> From 40577316f4dbcf35061a14f27f7a777c2f4199a1 Mon Sep 17 00:00:00 2001
> >> From: lizhe <sensor1010@163.com>
> >> Date: Tue, 9 Nov 2021 10:13:43 -0800
> >> Subject: [PATCH] drivers/mmc/cor/bus: Delete redundant match function
> >>
> >>
> >> When the device and the driver are matching,
> >> if the device or the bus to which the device driver belongs
> >> does not provide a match function,
> >> then the device and the driver are matched by default.
> >> function 'driver_match_device' illustrates this mechanism.
> >> Because the return value of mmc_bus_match is 1,
> >> even if this function is not provided,
> >> the function 'driver_match_device' returns 1,
> >> so function 'mmc_bus_match' is redundant.
> >>
> >>
> >> Signed-off-by: lizhe <sensor1010@163.com>
> >
> >Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >
> >Apart from how the patch is put in the mail, a maintainer responsible
> >for picking patches up in this area will probably refuse because the
> >name in the From line of your mail doesn't match the name used in the
> >Signed-off-by: line.
> >
> >Best regards
> >Uwe
> >
> >--
> >Pengutronix e.K.                           | Uwe Kleine-König            |
> >Industrial Linux Solutions                 | https://www.pengutronix.de/ |
>
>
>
>