* [PATCH] mmc: host: use pr_err for sdhci_dumpregs @ 2016-05-30 7:59 Baranowska, BeataX 2016-05-31 15:46 ` Andy Shevchenko 2016-06-15 11:28 ` Adrian Hunter 0 siblings, 2 replies; 6+ messages in thread From: Baranowska, BeataX @ 2016-05-30 7:59 UTC (permalink / raw) To: Hunter, Adrian, Ulf Hansson, linux-mmc, linux-kernel Cc: Dong, Chuanxiao, Jarosz, SebastianX From: Chuanxiao Dong <chuanxiao.dong@intel.com> sdhci_dumpregs is used to dump registers when error happens. Thus it should use pr_err instead of pr_debug to show more information about the hardware. Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com> --- drivers/mmc/host/sdhci.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index e010ea4eb6f5..99441742d86e 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -52,58 +52,58 @@ static int sdhci_get_cd(struct mmc_host *mmc); static void sdhci_dumpregs(struct sdhci_host *host) { - pr_debug(DRIVER_NAME ": =========== REGISTER DUMP (%s)===========\n", + pr_err(DRIVER_NAME ": =========== REGISTER DUMP (%s)===========\n", mmc_hostname(host->mmc)); - pr_debug(DRIVER_NAME ": Sys addr: 0x%08x | Version: 0x%08x\n", + pr_err(DRIVER_NAME ": Sys addr: 0x%08x | Version: 0x%08x\n", sdhci_readl(host, SDHCI_DMA_ADDRESS), sdhci_readw(host, SDHCI_HOST_VERSION)); - pr_debug(DRIVER_NAME ": Blk size: 0x%08x | Blk cnt: 0x%08x\n", + pr_err(DRIVER_NAME ": Blk size: 0x%08x | Blk cnt: 0x%08x\n", sdhci_readw(host, SDHCI_BLOCK_SIZE), sdhci_readw(host, SDHCI_BLOCK_COUNT)); - pr_debug(DRIVER_NAME ": Argument: 0x%08x | Trn mode: 0x%08x\n", + pr_err(DRIVER_NAME ": Argument: 0x%08x | Trn mode: 0x%08x\n", sdhci_readl(host, SDHCI_ARGUMENT), sdhci_readw(host, SDHCI_TRANSFER_MODE)); - pr_debug(DRIVER_NAME ": Present: 0x%08x | Host ctl: 0x%08x\n", + pr_err(DRIVER_NAME ": Present: 0x%08x | Host ctl: 0x%08x\n", sdhci_readl(host, SDHCI_PRESENT_STATE), sdhci_readb(host, SDHCI_HOST_CONTROL)); - pr_debug(DRIVER_NAME ": Power: 0x%08x | Blk gap: 0x%08x\n", + pr_err(DRIVER_NAME ": Power: 0x%08x | Blk gap: 0x%08x\n", sdhci_readb(host, SDHCI_POWER_CONTROL), sdhci_readb(host, SDHCI_BLOCK_GAP_CONTROL)); - pr_debug(DRIVER_NAME ": Wake-up: 0x%08x | Clock: 0x%08x\n", + pr_err(DRIVER_NAME ": Wake-up: 0x%08x | Clock: 0x%08x\n", sdhci_readb(host, SDHCI_WAKE_UP_CONTROL), sdhci_readw(host, SDHCI_CLOCK_CONTROL)); - pr_debug(DRIVER_NAME ": Timeout: 0x%08x | Int stat: 0x%08x\n", + pr_err(DRIVER_NAME ": Timeout: 0x%08x | Int stat: 0x%08x\n", sdhci_readb(host, SDHCI_TIMEOUT_CONTROL), sdhci_readl(host, SDHCI_INT_STATUS)); - pr_debug(DRIVER_NAME ": Int enab: 0x%08x | Sig enab: 0x%08x\n", + pr_err(DRIVER_NAME ": Int enab: 0x%08x | Sig enab: 0x%08x\n", sdhci_readl(host, SDHCI_INT_ENABLE), sdhci_readl(host, SDHCI_SIGNAL_ENABLE)); - pr_debug(DRIVER_NAME ": AC12 err: 0x%08x | Slot int: 0x%08x\n", + pr_err(DRIVER_NAME ": AC12 err: 0x%08x | Slot int: 0x%08x\n", sdhci_readw(host, SDHCI_ACMD12_ERR), sdhci_readw(host, SDHCI_SLOT_INT_STATUS)); - pr_debug(DRIVER_NAME ": Caps: 0x%08x | Caps_1: 0x%08x\n", + pr_err(DRIVER_NAME ": Caps: 0x%08x | Caps_1: 0x%08x\n", sdhci_readl(host, SDHCI_CAPABILITIES), sdhci_readl(host, SDHCI_CAPABILITIES_1)); - pr_debug(DRIVER_NAME ": Cmd: 0x%08x | Max curr: 0x%08x\n", + pr_err(DRIVER_NAME ": Cmd: 0x%08x | Max curr: 0x%08x\n", sdhci_readw(host, SDHCI_COMMAND), sdhci_readl(host, SDHCI_MAX_CURRENT)); - pr_debug(DRIVER_NAME ": Host ctl2: 0x%08x\n", + pr_err(DRIVER_NAME ": Host ctl2: 0x%08x\n", sdhci_readw(host, SDHCI_HOST_CONTROL2)); if (host->flags & SDHCI_USE_ADMA) { if (host->flags & SDHCI_USE_64_BIT_DMA) - pr_debug(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x%08x\n", + pr_err(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x%08x\n", readl(host->ioaddr + SDHCI_ADMA_ERROR), readl(host->ioaddr + SDHCI_ADMA_ADDRESS_HI), readl(host->ioaddr + SDHCI_ADMA_ADDRESS)); else - pr_debug(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x\n", + pr_err(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x\n", readl(host->ioaddr + SDHCI_ADMA_ERROR), readl(host->ioaddr + SDHCI_ADMA_ADDRESS)); } - pr_debug(DRIVER_NAME ": ===========================================\n"); + pr_err(DRIVER_NAME ": ===========================================\n"); } /*****************************************************************************\ -- Regards, Beata Baranowska Intel Technology Poland sp. z o.o. ul. Słowackiego 173 | 80-298 Gdańsk Sąd Rejonowy Gdańsk Północ VII Wydział Gospodarczy Krajowego Rejestru Sądowego - KRS 101882 NIP 957-07-52-316 | Kapitał zakładowy 200.000 PLN ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs 2016-05-30 7:59 [PATCH] mmc: host: use pr_err for sdhci_dumpregs Baranowska, BeataX @ 2016-05-31 15:46 ` Andy Shevchenko 2016-06-01 5:12 ` Baranowska, BeataX 2016-06-15 11:28 ` Adrian Hunter 1 sibling, 1 reply; 6+ messages in thread From: Andy Shevchenko @ 2016-05-31 15:46 UTC (permalink / raw) To: Baranowska, BeataX Cc: Hunter, Adrian, Ulf Hansson, linux-mmc, linux-kernel, Dong, Chuanxiao, Jarosz, SebastianX On Mon, May 30, 2016 at 10:59 AM, Baranowska, BeataX <beatax.baranowska@intel.com> wrote: > From: Chuanxiao Dong <chuanxiao.dong@intel.com> > > sdhci_dumpregs is used to dump registers when error happens. Thus it should > use pr_err instead of pr_debug to show more information about the hardware. > Wouldn't be too noisy? -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] mmc: host: use pr_err for sdhci_dumpregs 2016-05-31 15:46 ` Andy Shevchenko @ 2016-06-01 5:12 ` Baranowska, BeataX 0 siblings, 0 replies; 6+ messages in thread From: Baranowska, BeataX @ 2016-06-01 5:12 UTC (permalink / raw) To: Andy Shevchenko Cc: Hunter, Adrian, Ulf Hansson, linux-mmc, linux-kernel, Dong, Chuanxiao, Jarosz, SebastianX > -----Original Message----- > From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com] > Sent: Tuesday, May 31, 2016 5:47 PM > To: Baranowska, BeataX <beatax.baranowska@intel.com> > Cc: Hunter, Adrian <adrian.hunter@intel.com>; Ulf Hansson > <ulf.hansson@linaro.org>; linux-mmc@vger.kernel.org; linux- > kernel@vger.kernel.org; Dong, Chuanxiao <chuanxiao.dong@intel.com>; > Jarosz, SebastianX <sebastianx.jarosz@intel.com> > Subject: Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs > > On Mon, May 30, 2016 at 10:59 AM, Baranowska, BeataX > <beatax.baranowska@intel.com> wrote: > > From: Chuanxiao Dong <chuanxiao.dong@intel.com> > > > > sdhci_dumpregs is used to dump registers when error happens. Thus it > > should use pr_err instead of pr_debug to show more information about > the hardware. > > > > Wouldn't be too noisy? > > -- > With Best Regards, > Andy Shevchenko It is when error happens so IMHO it should be well visible. Regards, Beata Baranowska ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs 2016-05-30 7:59 [PATCH] mmc: host: use pr_err for sdhci_dumpregs Baranowska, BeataX 2016-05-31 15:46 ` Andy Shevchenko @ 2016-06-15 11:28 ` Adrian Hunter 2016-06-22 11:40 ` [PATCH V2] mmc: sdhci: " Adrian Hunter 1 sibling, 1 reply; 6+ messages in thread From: Adrian Hunter @ 2016-06-15 11:28 UTC (permalink / raw) To: Baranowska, BeataX, Ulf Hansson, linux-mmc, linux-kernel Cc: Dong, Chuanxiao, Jarosz, SebastianX On 30/05/16 10:59, Baranowska, BeataX wrote: > From: Chuanxiao Dong <chuanxiao.dong@intel.com> > > sdhci_dumpregs is used to dump registers when error happens. Thus it should > use pr_err instead of pr_debug to show more information about the hardware. > > Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2] mmc: sdhci: use pr_err for sdhci_dumpregs 2016-06-15 11:28 ` Adrian Hunter @ 2016-06-22 11:40 ` Adrian Hunter 2016-06-22 15:23 ` Ulf Hansson 0 siblings, 1 reply; 6+ messages in thread From: Adrian Hunter @ 2016-06-22 11:40 UTC (permalink / raw) To: Ulf Hansson, linux-mmc, linux-kernel Cc: Baranowska, BeataX, Dong, Chuanxiao, Jarosz, SebastianX From: Chuanxiao Dong <chuanxiao.dong@intel.com> sdhci_dumpregs is used to dump registers when error happens. Thus it should use pr_err instead of pr_debug to show more information about the hardware. Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com> [Fix whitespace and checkpatch warnings] Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> --- Changes in V2: Fix whitespace and checkpatch warnings Change subject 'host' -> 'sdhci' drivers/mmc/host/sdhci.c | 92 ++++++++++++++++++++++++------------------------ 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 040af1b6b412..49800d2c69fa 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -52,58 +52,58 @@ static int sdhci_get_cd(struct mmc_host *mmc); static void sdhci_dumpregs(struct sdhci_host *host) { - pr_debug(DRIVER_NAME ": =========== REGISTER DUMP (%s)===========\n", - mmc_hostname(host->mmc)); - - pr_debug(DRIVER_NAME ": Sys addr: 0x%08x | Version: 0x%08x\n", - sdhci_readl(host, SDHCI_DMA_ADDRESS), - sdhci_readw(host, SDHCI_HOST_VERSION)); - pr_debug(DRIVER_NAME ": Blk size: 0x%08x | Blk cnt: 0x%08x\n", - sdhci_readw(host, SDHCI_BLOCK_SIZE), - sdhci_readw(host, SDHCI_BLOCK_COUNT)); - pr_debug(DRIVER_NAME ": Argument: 0x%08x | Trn mode: 0x%08x\n", - sdhci_readl(host, SDHCI_ARGUMENT), - sdhci_readw(host, SDHCI_TRANSFER_MODE)); - pr_debug(DRIVER_NAME ": Present: 0x%08x | Host ctl: 0x%08x\n", - sdhci_readl(host, SDHCI_PRESENT_STATE), - sdhci_readb(host, SDHCI_HOST_CONTROL)); - pr_debug(DRIVER_NAME ": Power: 0x%08x | Blk gap: 0x%08x\n", - sdhci_readb(host, SDHCI_POWER_CONTROL), - sdhci_readb(host, SDHCI_BLOCK_GAP_CONTROL)); - pr_debug(DRIVER_NAME ": Wake-up: 0x%08x | Clock: 0x%08x\n", - sdhci_readb(host, SDHCI_WAKE_UP_CONTROL), - sdhci_readw(host, SDHCI_CLOCK_CONTROL)); - pr_debug(DRIVER_NAME ": Timeout: 0x%08x | Int stat: 0x%08x\n", - sdhci_readb(host, SDHCI_TIMEOUT_CONTROL), - sdhci_readl(host, SDHCI_INT_STATUS)); - pr_debug(DRIVER_NAME ": Int enab: 0x%08x | Sig enab: 0x%08x\n", - sdhci_readl(host, SDHCI_INT_ENABLE), - sdhci_readl(host, SDHCI_SIGNAL_ENABLE)); - pr_debug(DRIVER_NAME ": AC12 err: 0x%08x | Slot int: 0x%08x\n", - sdhci_readw(host, SDHCI_ACMD12_ERR), - sdhci_readw(host, SDHCI_SLOT_INT_STATUS)); - pr_debug(DRIVER_NAME ": Caps: 0x%08x | Caps_1: 0x%08x\n", - sdhci_readl(host, SDHCI_CAPABILITIES), - sdhci_readl(host, SDHCI_CAPABILITIES_1)); - pr_debug(DRIVER_NAME ": Cmd: 0x%08x | Max curr: 0x%08x\n", - sdhci_readw(host, SDHCI_COMMAND), - sdhci_readl(host, SDHCI_MAX_CURRENT)); - pr_debug(DRIVER_NAME ": Host ctl2: 0x%08x\n", - sdhci_readw(host, SDHCI_HOST_CONTROL2)); + pr_err(DRIVER_NAME ": =========== REGISTER DUMP (%s)===========\n", + mmc_hostname(host->mmc)); + + pr_err(DRIVER_NAME ": Sys addr: 0x%08x | Version: 0x%08x\n", + sdhci_readl(host, SDHCI_DMA_ADDRESS), + sdhci_readw(host, SDHCI_HOST_VERSION)); + pr_err(DRIVER_NAME ": Blk size: 0x%08x | Blk cnt: 0x%08x\n", + sdhci_readw(host, SDHCI_BLOCK_SIZE), + sdhci_readw(host, SDHCI_BLOCK_COUNT)); + pr_err(DRIVER_NAME ": Argument: 0x%08x | Trn mode: 0x%08x\n", + sdhci_readl(host, SDHCI_ARGUMENT), + sdhci_readw(host, SDHCI_TRANSFER_MODE)); + pr_err(DRIVER_NAME ": Present: 0x%08x | Host ctl: 0x%08x\n", + sdhci_readl(host, SDHCI_PRESENT_STATE), + sdhci_readb(host, SDHCI_HOST_CONTROL)); + pr_err(DRIVER_NAME ": Power: 0x%08x | Blk gap: 0x%08x\n", + sdhci_readb(host, SDHCI_POWER_CONTROL), + sdhci_readb(host, SDHCI_BLOCK_GAP_CONTROL)); + pr_err(DRIVER_NAME ": Wake-up: 0x%08x | Clock: 0x%08x\n", + sdhci_readb(host, SDHCI_WAKE_UP_CONTROL), + sdhci_readw(host, SDHCI_CLOCK_CONTROL)); + pr_err(DRIVER_NAME ": Timeout: 0x%08x | Int stat: 0x%08x\n", + sdhci_readb(host, SDHCI_TIMEOUT_CONTROL), + sdhci_readl(host, SDHCI_INT_STATUS)); + pr_err(DRIVER_NAME ": Int enab: 0x%08x | Sig enab: 0x%08x\n", + sdhci_readl(host, SDHCI_INT_ENABLE), + sdhci_readl(host, SDHCI_SIGNAL_ENABLE)); + pr_err(DRIVER_NAME ": AC12 err: 0x%08x | Slot int: 0x%08x\n", + sdhci_readw(host, SDHCI_ACMD12_ERR), + sdhci_readw(host, SDHCI_SLOT_INT_STATUS)); + pr_err(DRIVER_NAME ": Caps: 0x%08x | Caps_1: 0x%08x\n", + sdhci_readl(host, SDHCI_CAPABILITIES), + sdhci_readl(host, SDHCI_CAPABILITIES_1)); + pr_err(DRIVER_NAME ": Cmd: 0x%08x | Max curr: 0x%08x\n", + sdhci_readw(host, SDHCI_COMMAND), + sdhci_readl(host, SDHCI_MAX_CURRENT)); + pr_err(DRIVER_NAME ": Host ctl2: 0x%08x\n", + sdhci_readw(host, SDHCI_HOST_CONTROL2)); if (host->flags & SDHCI_USE_ADMA) { if (host->flags & SDHCI_USE_64_BIT_DMA) - pr_debug(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x%08x\n", - readl(host->ioaddr + SDHCI_ADMA_ERROR), - readl(host->ioaddr + SDHCI_ADMA_ADDRESS_HI), - readl(host->ioaddr + SDHCI_ADMA_ADDRESS)); + pr_err(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x%08x\n", + readl(host->ioaddr + SDHCI_ADMA_ERROR), + readl(host->ioaddr + SDHCI_ADMA_ADDRESS_HI), + readl(host->ioaddr + SDHCI_ADMA_ADDRESS)); else - pr_debug(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x\n", - readl(host->ioaddr + SDHCI_ADMA_ERROR), - readl(host->ioaddr + SDHCI_ADMA_ADDRESS)); + pr_err(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x\n", + readl(host->ioaddr + SDHCI_ADMA_ERROR), + readl(host->ioaddr + SDHCI_ADMA_ADDRESS)); } - pr_debug(DRIVER_NAME ": ===========================================\n"); + pr_err(DRIVER_NAME ": ===========================================\n"); } /*****************************************************************************\ -- 1.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2] mmc: sdhci: use pr_err for sdhci_dumpregs 2016-06-22 11:40 ` [PATCH V2] mmc: sdhci: " Adrian Hunter @ 2016-06-22 15:23 ` Ulf Hansson 0 siblings, 0 replies; 6+ messages in thread From: Ulf Hansson @ 2016-06-22 15:23 UTC (permalink / raw) To: Adrian Hunter Cc: linux-mmc, linux-kernel, Baranowska, BeataX, Dong, Chuanxiao, Jarosz, SebastianX On 22 June 2016 at 13:40, Adrian Hunter <adrian.hunter@intel.com> wrote: > From: Chuanxiao Dong <chuanxiao.dong@intel.com> > > sdhci_dumpregs is used to dump registers when error happens. Thus it should > use pr_err instead of pr_debug to show more information about the hardware. > > Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com> > [Fix whitespace and checkpatch warnings] > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Thanks, applied for next! Kind regards Uffe > --- > > Changes in V2: > > Fix whitespace and checkpatch warnings > Change subject 'host' -> 'sdhci' > > drivers/mmc/host/sdhci.c | 92 ++++++++++++++++++++++++------------------------ > 1 file changed, 46 insertions(+), 46 deletions(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index 040af1b6b412..49800d2c69fa 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -52,58 +52,58 @@ static int sdhci_get_cd(struct mmc_host *mmc); > > static void sdhci_dumpregs(struct sdhci_host *host) > { > - pr_debug(DRIVER_NAME ": =========== REGISTER DUMP (%s)===========\n", > - mmc_hostname(host->mmc)); > - > - pr_debug(DRIVER_NAME ": Sys addr: 0x%08x | Version: 0x%08x\n", > - sdhci_readl(host, SDHCI_DMA_ADDRESS), > - sdhci_readw(host, SDHCI_HOST_VERSION)); > - pr_debug(DRIVER_NAME ": Blk size: 0x%08x | Blk cnt: 0x%08x\n", > - sdhci_readw(host, SDHCI_BLOCK_SIZE), > - sdhci_readw(host, SDHCI_BLOCK_COUNT)); > - pr_debug(DRIVER_NAME ": Argument: 0x%08x | Trn mode: 0x%08x\n", > - sdhci_readl(host, SDHCI_ARGUMENT), > - sdhci_readw(host, SDHCI_TRANSFER_MODE)); > - pr_debug(DRIVER_NAME ": Present: 0x%08x | Host ctl: 0x%08x\n", > - sdhci_readl(host, SDHCI_PRESENT_STATE), > - sdhci_readb(host, SDHCI_HOST_CONTROL)); > - pr_debug(DRIVER_NAME ": Power: 0x%08x | Blk gap: 0x%08x\n", > - sdhci_readb(host, SDHCI_POWER_CONTROL), > - sdhci_readb(host, SDHCI_BLOCK_GAP_CONTROL)); > - pr_debug(DRIVER_NAME ": Wake-up: 0x%08x | Clock: 0x%08x\n", > - sdhci_readb(host, SDHCI_WAKE_UP_CONTROL), > - sdhci_readw(host, SDHCI_CLOCK_CONTROL)); > - pr_debug(DRIVER_NAME ": Timeout: 0x%08x | Int stat: 0x%08x\n", > - sdhci_readb(host, SDHCI_TIMEOUT_CONTROL), > - sdhci_readl(host, SDHCI_INT_STATUS)); > - pr_debug(DRIVER_NAME ": Int enab: 0x%08x | Sig enab: 0x%08x\n", > - sdhci_readl(host, SDHCI_INT_ENABLE), > - sdhci_readl(host, SDHCI_SIGNAL_ENABLE)); > - pr_debug(DRIVER_NAME ": AC12 err: 0x%08x | Slot int: 0x%08x\n", > - sdhci_readw(host, SDHCI_ACMD12_ERR), > - sdhci_readw(host, SDHCI_SLOT_INT_STATUS)); > - pr_debug(DRIVER_NAME ": Caps: 0x%08x | Caps_1: 0x%08x\n", > - sdhci_readl(host, SDHCI_CAPABILITIES), > - sdhci_readl(host, SDHCI_CAPABILITIES_1)); > - pr_debug(DRIVER_NAME ": Cmd: 0x%08x | Max curr: 0x%08x\n", > - sdhci_readw(host, SDHCI_COMMAND), > - sdhci_readl(host, SDHCI_MAX_CURRENT)); > - pr_debug(DRIVER_NAME ": Host ctl2: 0x%08x\n", > - sdhci_readw(host, SDHCI_HOST_CONTROL2)); > + pr_err(DRIVER_NAME ": =========== REGISTER DUMP (%s)===========\n", > + mmc_hostname(host->mmc)); > + > + pr_err(DRIVER_NAME ": Sys addr: 0x%08x | Version: 0x%08x\n", > + sdhci_readl(host, SDHCI_DMA_ADDRESS), > + sdhci_readw(host, SDHCI_HOST_VERSION)); > + pr_err(DRIVER_NAME ": Blk size: 0x%08x | Blk cnt: 0x%08x\n", > + sdhci_readw(host, SDHCI_BLOCK_SIZE), > + sdhci_readw(host, SDHCI_BLOCK_COUNT)); > + pr_err(DRIVER_NAME ": Argument: 0x%08x | Trn mode: 0x%08x\n", > + sdhci_readl(host, SDHCI_ARGUMENT), > + sdhci_readw(host, SDHCI_TRANSFER_MODE)); > + pr_err(DRIVER_NAME ": Present: 0x%08x | Host ctl: 0x%08x\n", > + sdhci_readl(host, SDHCI_PRESENT_STATE), > + sdhci_readb(host, SDHCI_HOST_CONTROL)); > + pr_err(DRIVER_NAME ": Power: 0x%08x | Blk gap: 0x%08x\n", > + sdhci_readb(host, SDHCI_POWER_CONTROL), > + sdhci_readb(host, SDHCI_BLOCK_GAP_CONTROL)); > + pr_err(DRIVER_NAME ": Wake-up: 0x%08x | Clock: 0x%08x\n", > + sdhci_readb(host, SDHCI_WAKE_UP_CONTROL), > + sdhci_readw(host, SDHCI_CLOCK_CONTROL)); > + pr_err(DRIVER_NAME ": Timeout: 0x%08x | Int stat: 0x%08x\n", > + sdhci_readb(host, SDHCI_TIMEOUT_CONTROL), > + sdhci_readl(host, SDHCI_INT_STATUS)); > + pr_err(DRIVER_NAME ": Int enab: 0x%08x | Sig enab: 0x%08x\n", > + sdhci_readl(host, SDHCI_INT_ENABLE), > + sdhci_readl(host, SDHCI_SIGNAL_ENABLE)); > + pr_err(DRIVER_NAME ": AC12 err: 0x%08x | Slot int: 0x%08x\n", > + sdhci_readw(host, SDHCI_ACMD12_ERR), > + sdhci_readw(host, SDHCI_SLOT_INT_STATUS)); > + pr_err(DRIVER_NAME ": Caps: 0x%08x | Caps_1: 0x%08x\n", > + sdhci_readl(host, SDHCI_CAPABILITIES), > + sdhci_readl(host, SDHCI_CAPABILITIES_1)); > + pr_err(DRIVER_NAME ": Cmd: 0x%08x | Max curr: 0x%08x\n", > + sdhci_readw(host, SDHCI_COMMAND), > + sdhci_readl(host, SDHCI_MAX_CURRENT)); > + pr_err(DRIVER_NAME ": Host ctl2: 0x%08x\n", > + sdhci_readw(host, SDHCI_HOST_CONTROL2)); > > if (host->flags & SDHCI_USE_ADMA) { > if (host->flags & SDHCI_USE_64_BIT_DMA) > - pr_debug(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x%08x\n", > - readl(host->ioaddr + SDHCI_ADMA_ERROR), > - readl(host->ioaddr + SDHCI_ADMA_ADDRESS_HI), > - readl(host->ioaddr + SDHCI_ADMA_ADDRESS)); > + pr_err(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x%08x\n", > + readl(host->ioaddr + SDHCI_ADMA_ERROR), > + readl(host->ioaddr + SDHCI_ADMA_ADDRESS_HI), > + readl(host->ioaddr + SDHCI_ADMA_ADDRESS)); > else > - pr_debug(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x\n", > - readl(host->ioaddr + SDHCI_ADMA_ERROR), > - readl(host->ioaddr + SDHCI_ADMA_ADDRESS)); > + pr_err(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x\n", > + readl(host->ioaddr + SDHCI_ADMA_ERROR), > + readl(host->ioaddr + SDHCI_ADMA_ADDRESS)); > } > > - pr_debug(DRIVER_NAME ": ===========================================\n"); > + pr_err(DRIVER_NAME ": ===========================================\n"); > } > > /*****************************************************************************\ > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-22 15:24 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-05-30 7:59 [PATCH] mmc: host: use pr_err for sdhci_dumpregs Baranowska, BeataX 2016-05-31 15:46 ` Andy Shevchenko 2016-06-01 5:12 ` Baranowska, BeataX 2016-06-15 11:28 ` Adrian Hunter 2016-06-22 11:40 ` [PATCH V2] mmc: sdhci: " Adrian Hunter 2016-06-22 15:23 ` Ulf Hansson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).