linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mmc/android-goldfish: remove incorrect __iomem annotation
@ 2015-08-17  8:09 Christoph Hellwig
  2015-09-01 12:23 ` Ulf Hansson
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2015-08-17  8:09 UTC (permalink / raw)
  To: Ulf Hansson, Chris Ball; +Cc: linux-kernel

Make sparse happy:

drivers/mmc/host/android-goldfish.c:535:56: sparse: incorrect type in argument 3 (different address spaces)

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/mmc/host/android-goldfish.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/android-goldfish.c b/drivers/mmc/host/android-goldfish.c
index b1eac71..dca5518 100644
--- a/drivers/mmc/host/android-goldfish.c
+++ b/drivers/mmc/host/android-goldfish.c
@@ -118,7 +118,7 @@ struct goldfish_mmc_host {
 	struct mmc_host		*mmc;
 	struct device		*dev;
 	unsigned char		id; /* 16xx chips have 2 MMC blocks */
-	void __iomem		*virt_base;
+	void			*virt_base;
 	unsigned int		phys_base;
 	int			irq;
 	unsigned char		bus_mode;
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mmc/android-goldfish: remove incorrect __iomem annotation
  2015-08-17  8:09 [PATCH] mmc/android-goldfish: remove incorrect __iomem annotation Christoph Hellwig
@ 2015-09-01 12:23 ` Ulf Hansson
  0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2015-09-01 12:23 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: linux-kernel, linux-mmc

+linux-mmc
-Chris (don't maintain mmc no more)

On 17 August 2015 at 10:09, Christoph Hellwig <hch@lst.de> wrote:
> Make sparse happy:
>
> drivers/mmc/host/android-goldfish.c:535:56: sparse: incorrect type in argument 3 (different address spaces)
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Normally I like you to post mmc patces to the linux-mmc list. As this
is a trivial patch and the driver don't have a dedicated maintainer, I
am going to pick it up anyway.

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/android-goldfish.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/android-goldfish.c b/drivers/mmc/host/android-goldfish.c
> index b1eac71..dca5518 100644
> --- a/drivers/mmc/host/android-goldfish.c
> +++ b/drivers/mmc/host/android-goldfish.c
> @@ -118,7 +118,7 @@ struct goldfish_mmc_host {
>         struct mmc_host         *mmc;
>         struct device           *dev;
>         unsigned char           id; /* 16xx chips have 2 MMC blocks */
> -       void __iomem            *virt_base;
> +       void                    *virt_base;
>         unsigned int            phys_base;
>         int                     irq;
>         unsigned char           bus_mode;
> --
> 1.9.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-01 12:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-17  8:09 [PATCH] mmc/android-goldfish: remove incorrect __iomem annotation Christoph Hellwig
2015-09-01 12:23 ` Ulf Hansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).