* [PATCH 2/2] mmc: queue: Flush recovery work on cleanup
@ 2022-10-06 13:39 Christian Löhle
2022-10-07 13:12 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Christian Löhle @ 2022-10-06 13:39 UTC (permalink / raw)
To: Adrian Hunter, ulf.hansson, Linux MMC List, linux-kernel,
Christian Löhle
To prevent any recovery work running after the queue cleanup flush it.
Any recovery running post-cleanup dereferenced mq->card as NULL
and was not meaningful to begin with.
Cc: stable@vger.kernel.org
Signed-off-by: Christian Loehle <cloehle@hyperstone.com>
---
drivers/mmc/core/queue.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
index fefaa901b50f..a1b985d3dfda 100644
--- a/drivers/mmc/core/queue.c
+++ b/drivers/mmc/core/queue.c
@@ -493,6 +493,13 @@ void mmc_cleanup_queue(struct mmc_queue *mq)
if (blk_queue_quiesced(q))
blk_mq_unquiesce_queue(q);
+ /*
+ * If the recovery completes the last (and only remaining) request in
+ * the queue, and the card has been removed, we could end up here with
+ * the recovery not quite finished yet, so flush it.
+ */
+ flush_work(&mq->recovery_work);
+
blk_mq_free_tag_set(&mq->tag_set);
/*
--
2.37.3
Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz
Managing Director: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] mmc: queue: Flush recovery work on cleanup
2022-10-06 13:39 [PATCH 2/2] mmc: queue: Flush recovery work on cleanup Christian Löhle
@ 2022-10-07 13:12 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2022-10-07 13:12 UTC (permalink / raw)
To: Adrian Hunter, Christian Löhle; +Cc: Linux MMC List, linux-kernel
On Thu, 6 Oct 2022 at 15:39, Christian Löhle <CLoehle@hyperstone.com> wrote:
>
> To prevent any recovery work running after the queue cleanup flush it.
> Any recovery running post-cleanup dereferenced mq->card as NULL
> and was not meaningful to begin with.
>
> Cc: stable@vger.kernel.org
>
> Signed-off-by: Christian Loehle <cloehle@hyperstone.com>
> ---
> drivers/mmc/core/queue.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
> index fefaa901b50f..a1b985d3dfda 100644
> --- a/drivers/mmc/core/queue.c
> +++ b/drivers/mmc/core/queue.c
> @@ -493,6 +493,13 @@ void mmc_cleanup_queue(struct mmc_queue *mq)
> if (blk_queue_quiesced(q))
> blk_mq_unquiesce_queue(q);
>
> + /*
> + * If the recovery completes the last (and only remaining) request in
> + * the queue, and the card has been removed, we could end up here with
> + * the recovery not quite finished yet, so flush it.
> + */
> + flush_work(&mq->recovery_work);
> +
Not sure if it really matters in this case, but isn't
cancel_work_sync() the more proper thing to call instead?
> blk_mq_free_tag_set(&mq->tag_set);
>
> /*
Kind regards
Uffe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-07 13:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-06 13:39 [PATCH 2/2] mmc: queue: Flush recovery work on cleanup Christian Löhle
2022-10-07 13:12 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).