* [PATCH v2] mmc: sdhci_am654: Set HIGH_SPEED_ENA for SDR12 and SDR25
@ 2023-03-17 9:27 Bhavya Kapoor
2023-03-23 12:13 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Bhavya Kapoor @ 2023-03-17 9:27 UTC (permalink / raw)
To: linux-kernel, linux-mmc; +Cc: b-kapoor, ulf.hansson, adrian.hunter
Timing Information in Datasheet assumes that HIGH_SPEED_ENA=1 should be
set for SDR12 and SDR25 modes. But sdhci_am654 driver clears
HIGH_SPEED_ENA register. Thus, Modify sdhci_am654 to not clear
HIGH_SPEED_ENA (HOST_CONTROL[2]) bit for SDR12 and SDR25 speed modes.
Fixes: e374e87538f4 ("mmc: sdhci_am654: Clear HISPD_ENA in some lower speed modes")
Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
---
Changelog v1->v2:
- Corrected Names of speed modes in commit message
Link to v1: https://lore.kernel.org/all/20230316080451.475020-1-b-kapoor@ti.com/
drivers/mmc/host/sdhci_am654.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
index 7ef828942df3..ac90e86bb0a0 100644
--- a/drivers/mmc/host/sdhci_am654.c
+++ b/drivers/mmc/host/sdhci_am654.c
@@ -351,8 +351,6 @@ static void sdhci_am654_write_b(struct sdhci_host *host, u8 val, int reg)
*/
case MMC_TIMING_SD_HS:
case MMC_TIMING_MMC_HS:
- case MMC_TIMING_UHS_SDR12:
- case MMC_TIMING_UHS_SDR25:
val &= ~SDHCI_CTRL_HISPD;
}
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mmc: sdhci_am654: Set HIGH_SPEED_ENA for SDR12 and SDR25
2023-03-17 9:27 [PATCH v2] mmc: sdhci_am654: Set HIGH_SPEED_ENA for SDR12 and SDR25 Bhavya Kapoor
@ 2023-03-23 12:13 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2023-03-23 12:13 UTC (permalink / raw)
To: Bhavya Kapoor; +Cc: linux-kernel, linux-mmc, adrian.hunter
On Fri, 17 Mar 2023 at 10:28, Bhavya Kapoor <b-kapoor@ti.com> wrote:
>
> Timing Information in Datasheet assumes that HIGH_SPEED_ENA=1 should be
> set for SDR12 and SDR25 modes. But sdhci_am654 driver clears
> HIGH_SPEED_ENA register. Thus, Modify sdhci_am654 to not clear
> HIGH_SPEED_ENA (HOST_CONTROL[2]) bit for SDR12 and SDR25 speed modes.
>
> Fixes: e374e87538f4 ("mmc: sdhci_am654: Clear HISPD_ENA in some lower speed modes")
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
Applied for fixes and by adding a stable tag, thanks!
Kind regards
Uffe
> ---
>
> Changelog v1->v2:
> - Corrected Names of speed modes in commit message
>
> Link to v1: https://lore.kernel.org/all/20230316080451.475020-1-b-kapoor@ti.com/
>
> drivers/mmc/host/sdhci_am654.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index 7ef828942df3..ac90e86bb0a0 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -351,8 +351,6 @@ static void sdhci_am654_write_b(struct sdhci_host *host, u8 val, int reg)
> */
> case MMC_TIMING_SD_HS:
> case MMC_TIMING_MMC_HS:
> - case MMC_TIMING_UHS_SDR12:
> - case MMC_TIMING_UHS_SDR25:
> val &= ~SDHCI_CTRL_HISPD;
> }
> }
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-23 12:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-17 9:27 [PATCH v2] mmc: sdhci_am654: Set HIGH_SPEED_ENA for SDR12 and SDR25 Bhavya Kapoor
2023-03-23 12:13 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).