* [PATCH] mmc: dw_mmc-k3: use the correct HiSilicon copyright
@ 2021-03-30 6:40 Hao Fang
2021-03-30 10:38 ` Ulf Hansson
2021-03-31 6:59 ` Zhangfei Gao
0 siblings, 2 replies; 7+ messages in thread
From: Hao Fang @ 2021-03-30 6:40 UTC (permalink / raw)
To: jh80.chung, ulf.hansson; +Cc: linux-mmc, linux-kernel, prime.zeng, fanghao11
s/Hisilicon/HiSilicon/g.
It should use capital S, according to
https://www.hisilicon.com/en/terms-of-use.
Signed-off-by: Hao Fang <fanghao11@huawei.com>
---
drivers/mmc/host/dw_mmc-k3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c
index 29d2494..0311a37 100644
--- a/drivers/mmc/host/dw_mmc-k3.c
+++ b/drivers/mmc/host/dw_mmc-k3.c
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Copyright (c) 2013 Linaro Ltd.
- * Copyright (c) 2013 Hisilicon Limited.
+ * Copyright (c) 2013 HiSilicon Limited.
*/
#include <linux/bitops.h>
--
2.8.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] mmc: dw_mmc-k3: use the correct HiSilicon copyright
2021-03-30 6:40 [PATCH] mmc: dw_mmc-k3: use the correct HiSilicon copyright Hao Fang
@ 2021-03-30 10:38 ` Ulf Hansson
2021-03-30 13:43 ` Pavel Machek
2021-03-30 14:27 ` fanghao (A)
2021-03-31 6:59 ` Zhangfei Gao
1 sibling, 2 replies; 7+ messages in thread
From: Ulf Hansson @ 2021-03-30 10:38 UTC (permalink / raw)
To: Hao Fang; +Cc: Jaehoon Chung, linux-mmc, Linux Kernel Mailing List, prime.zeng
On Tue, 30 Mar 2021 at 08:43, Hao Fang <fanghao11@huawei.com> wrote:
>
> s/Hisilicon/HiSilicon/g.
> It should use capital S, according to
> https://www.hisilicon.com/en/terms-of-use.
>
> Signed-off-by: Hao Fang <fanghao11@huawei.com>
> ---
> drivers/mmc/host/dw_mmc-k3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c
> index 29d2494..0311a37 100644
> --- a/drivers/mmc/host/dw_mmc-k3.c
> +++ b/drivers/mmc/host/dw_mmc-k3.c
> @@ -1,7 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> * Copyright (c) 2013 Linaro Ltd.
> - * Copyright (c) 2013 Hisilicon Limited.
> + * Copyright (c) 2013 HiSilicon Limited.
This change looks really silly to me, but I am not a lawyer - so I
can't tell if this makes sense or not.
In any case, "Hisilicon" is being used all over the kernel - do you
intend to patch all places with similar changes like this one? Perhaps
just send a big tree-wide-patch instead and see what people think?
> */
>
> #include <linux/bitops.h>
Kind regards
Uffe
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mmc: dw_mmc-k3: use the correct HiSilicon copyright
2021-03-30 10:38 ` Ulf Hansson
@ 2021-03-30 13:43 ` Pavel Machek
2021-03-30 14:31 ` fanghao (A)
2021-03-30 14:27 ` fanghao (A)
1 sibling, 1 reply; 7+ messages in thread
From: Pavel Machek @ 2021-03-30 13:43 UTC (permalink / raw)
To: Ulf Hansson
Cc: Hao Fang, Jaehoon Chung, linux-mmc, Linux Kernel Mailing List,
prime.zeng
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
Hi!
> On Tue, 30 Mar 2021 at 08:43, Hao Fang <fanghao11@huawei.com> wrote:
> >
> > s/Hisilicon/HiSilicon/g.
> > It should use capital S, according to
> > https://www.hisilicon.com/en/terms-of-use.
> >
> > Signed-off-by: Hao Fang <fanghao11@huawei.com>
> > /*
> > * Copyright (c) 2013 Linaro Ltd.
> > - * Copyright (c) 2013 Hisilicon Limited.
> > + * Copyright (c) 2013 HiSilicon Limited.
>
> This change looks really silly to me, but I am not a lawyer - so I
> can't tell if this makes sense or not.
>
> In any case, "Hisilicon" is being used all over the kernel - do you
> intend to patch all places with similar changes like this one? Perhaps
> just send a big tree-wide-patch instead and see what people think?
Plus, I'd expect authors to submit changes to copyright notices.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mmc: dw_mmc-k3: use the correct HiSilicon copyright
2021-03-30 10:38 ` Ulf Hansson
2021-03-30 13:43 ` Pavel Machek
@ 2021-03-30 14:27 ` fanghao (A)
2021-03-31 12:51 ` Ulf Hansson
1 sibling, 1 reply; 7+ messages in thread
From: fanghao (A) @ 2021-03-30 14:27 UTC (permalink / raw)
To: Ulf Hansson
Cc: Jaehoon Chung, linux-mmc, Linux Kernel Mailing List, prime.zeng
On 2021/3/30 18:38, Ulf Hansson wrote:
> On Tue, 30 Mar 2021 at 08:43, Hao Fang <fanghao11@huawei.com> wrote:
>>
>> s/Hisilicon/HiSilicon/g.
>> It should use capital S, according to
>> https://www.hisilicon.com/en/terms-of-use.
>>
>> Signed-off-by: Hao Fang <fanghao11@huawei.com>
>> ---
>> drivers/mmc/host/dw_mmc-k3.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c
>> index 29d2494..0311a37 100644
>> --- a/drivers/mmc/host/dw_mmc-k3.c
>> +++ b/drivers/mmc/host/dw_mmc-k3.c
>> @@ -1,7 +1,7 @@
>> // SPDX-License-Identifier: GPL-2.0-or-later
>> /*
>> * Copyright (c) 2013 Linaro Ltd.
>> - * Copyright (c) 2013 Hisilicon Limited.
>> + * Copyright (c) 2013 HiSilicon Limited.
>
> This change looks really silly to me, but I am not a lawyer - so I
> can't tell if this makes sense or not.
>
> In any case, "Hisilicon" is being used all over the kernel - do you
> intend to patch all places with similar changes like this one? Perhaps
> just send a big tree-wide-patch instead and see what people think?
>
Although HiSilicon has applied for two trademarks Hisilicon/HiSilicon,
there is only one English name for the company. We have consulted with
company's lawyer who suggested that should use a copyright statement
consistent with the official website.
Though the kernel has tons of "Hisilicon", I just fix the copyright,
and plan to send a commit to each subsystem where is uncorrect. Fortunately,
there are not many modules that have the problem, this is one of them.
Thanks.
Hao
>> */
>>
>> #include <linux/bitops.h>
>
> Kind regards
> Uffe
>
> .
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mmc: dw_mmc-k3: use the correct HiSilicon copyright
2021-03-30 13:43 ` Pavel Machek
@ 2021-03-30 14:31 ` fanghao (A)
0 siblings, 0 replies; 7+ messages in thread
From: fanghao (A) @ 2021-03-30 14:31 UTC (permalink / raw)
To: Pavel Machek, Ulf Hansson
Cc: Jaehoon Chung, linux-mmc, Linux Kernel Mailing List, prime.zeng
On 2021/3/30 21:43, Pavel Machek wrote:
> Hi!
>
>> On Tue, 30 Mar 2021 at 08:43, Hao Fang <fanghao11@huawei.com> wrote:
>>>
>>> s/Hisilicon/HiSilicon/g.
>>> It should use capital S, according to
>>> https://www.hisilicon.com/en/terms-of-use.
>>>
>>> Signed-off-by: Hao Fang <fanghao11@huawei.com>
>
>>> /*
>>> * Copyright (c) 2013 Linaro Ltd.
>>> - * Copyright (c) 2013 Hisilicon Limited.
>>> + * Copyright (c) 2013 HiSilicon Limited.
>>
>> This change looks really silly to me, but I am not a lawyer - so I
>> can't tell if this makes sense or not.
>>
>> In any case, "Hisilicon" is being used all over the kernel - do you
>> intend to patch all places with similar changes like this one? Perhaps
>> just send a big tree-wide-patch instead and see what people think?
>
> Plus, I'd expect authors to submit changes to copyright notices.
>
Just add Reviewed-by or Acked-by! Thanks.
> Best regards,
> Pavel
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mmc: dw_mmc-k3: use the correct HiSilicon copyright
2021-03-30 6:40 [PATCH] mmc: dw_mmc-k3: use the correct HiSilicon copyright Hao Fang
2021-03-30 10:38 ` Ulf Hansson
@ 2021-03-31 6:59 ` Zhangfei Gao
1 sibling, 0 replies; 7+ messages in thread
From: Zhangfei Gao @ 2021-03-31 6:59 UTC (permalink / raw)
To: Hao Fang; +Cc: Jaehoon Chung, Ulf Hansson, linux-mmc, linux-kernel, prime.zeng
On Tue, Mar 30, 2021 at 2:46 PM Hao Fang <fanghao11@huawei.com> wrote:
>
> s/Hisilicon/HiSilicon/g.
> It should use capital S, according to
> https://www.hisilicon.com/en/terms-of-use.
>
> Signed-off-by: Hao Fang <fanghao11@huawei.com>
Thanks for the fix.
Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> ---
> drivers/mmc/host/dw_mmc-k3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c
> index 29d2494..0311a37 100644
> --- a/drivers/mmc/host/dw_mmc-k3.c
> +++ b/drivers/mmc/host/dw_mmc-k3.c
> @@ -1,7 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> * Copyright (c) 2013 Linaro Ltd.
> - * Copyright (c) 2013 Hisilicon Limited.
> + * Copyright (c) 2013 HiSilicon Limited.
> */
>
> #include <linux/bitops.h>
> --
> 2.8.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mmc: dw_mmc-k3: use the correct HiSilicon copyright
2021-03-30 14:27 ` fanghao (A)
@ 2021-03-31 12:51 ` Ulf Hansson
0 siblings, 0 replies; 7+ messages in thread
From: Ulf Hansson @ 2021-03-31 12:51 UTC (permalink / raw)
To: fanghao (A)
Cc: Jaehoon Chung, linux-mmc, Linux Kernel Mailing List, prime.zeng
On Tue, 30 Mar 2021 at 16:27, fanghao (A) <fanghao11@huawei.com> wrote:
>
>
>
> On 2021/3/30 18:38, Ulf Hansson wrote:
> > On Tue, 30 Mar 2021 at 08:43, Hao Fang <fanghao11@huawei.com> wrote:
> >>
> >> s/Hisilicon/HiSilicon/g.
> >> It should use capital S, according to
> >> https://www.hisilicon.com/en/terms-of-use.
> >>
> >> Signed-off-by: Hao Fang <fanghao11@huawei.com>
> >> ---
> >> drivers/mmc/host/dw_mmc-k3.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c
> >> index 29d2494..0311a37 100644
> >> --- a/drivers/mmc/host/dw_mmc-k3.c
> >> +++ b/drivers/mmc/host/dw_mmc-k3.c
> >> @@ -1,7 +1,7 @@
> >> // SPDX-License-Identifier: GPL-2.0-or-later
> >> /*
> >> * Copyright (c) 2013 Linaro Ltd.
> >> - * Copyright (c) 2013 Hisilicon Limited.
> >> + * Copyright (c) 2013 HiSilicon Limited.
> >
> > This change looks really silly to me, but I am not a lawyer - so I
> > can't tell if this makes sense or not.
> >
> > In any case, "Hisilicon" is being used all over the kernel - do you
> > intend to patch all places with similar changes like this one? Perhaps
> > just send a big tree-wide-patch instead and see what people think?
> >
>
> Although HiSilicon has applied for two trademarks Hisilicon/HiSilicon,
> there is only one English name for the company. We have consulted with
> company's lawyer who suggested that should use a copyright statement
> consistent with the official website.
>
> Though the kernel has tons of "Hisilicon", I just fix the copyright,
> and plan to send a commit to each subsystem where is uncorrect. Fortunately,
> there are not many modules that have the problem, this is one of them.
git grep Hisilicon | grep Copyright | nl
gives 159 cases.
Although if you make one patch per subsystem that should be a lot
less, which seems like a reasonable approach to me.
[...]
So, applied for next, thanks!
Kind regards
Uffe
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-03-31 12:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-30 6:40 [PATCH] mmc: dw_mmc-k3: use the correct HiSilicon copyright Hao Fang
2021-03-30 10:38 ` Ulf Hansson
2021-03-30 13:43 ` Pavel Machek
2021-03-30 14:31 ` fanghao (A)
2021-03-30 14:27 ` fanghao (A)
2021-03-31 12:51 ` Ulf Hansson
2021-03-31 6:59 ` Zhangfei Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).