From: Ulf Hansson <ulf.hansson@linaro.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: rafael@kernel.org, khilman@kernel.org, robh@kernel.org,
krzysztof.kozlowski@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, festevam@gmail.com, pavel@ucw.cz,
kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org,
l.stach@pengutronix.de, aford173@gmail.com,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 2/2] soc: imx: gpcv2: fix suspend/resume by setting GENPD_FLAG_IRQ_ON
Date: Tue, 26 Jul 2022 17:08:03 +0200 [thread overview]
Message-ID: <CAPDyKFrJjxm3Ljh0-oTGhOHRyg1+8xNkjDKE7+NE7mb_8C9dXQ@mail.gmail.com> (raw)
In-Reply-To: <20220726083257.1730630-3-martin.kepplinger@puri.sm>
On Tue, 26 Jul 2022 at 10:33, Martin Kepplinger
<martin.kepplinger@puri.sm> wrote:
>
> For boards that use power-domains' power-supplies that need interrupts
> to work (like regulator over i2c), set GENPD_FLAG_IRQ_ON.
> This will tell genpd to adjust accordingly. Currently it "only" sets the
> correct suspend/resume callbacks.
>
> This fixes suspend/resume on imx8mq-librem5 boards (tested) and
> imx8mq-evk (by looking at dts) and possibly more.
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
> ---
> drivers/soc/imx/gpcv2.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
> index 6383a4edc360..199a621d8186 100644
> --- a/drivers/soc/imx/gpcv2.c
> +++ b/drivers/soc/imx/gpcv2.c
> @@ -1337,6 +1337,9 @@ static int imx_pgc_domain_probe(struct platform_device *pdev)
> regmap_update_bits(domain->regmap, domain->regs->map,
> domain->bits.map, domain->bits.map);
>
> + if (of_property_read_bool(domain->dev->of_node, "power-supply"))
> + domain->genpd.flags |= GENPD_FLAG_IRQ_ON;
> +
> ret = pm_genpd_init(&domain->genpd, NULL, true);
> if (ret) {
> dev_err(domain->dev, "Failed to init power domain\n");
> --
> 2.30.2
>
prev parent reply other threads:[~2022-07-26 15:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 8:32 [PATCH v6 0/2] power: domain: handle power supplies that need interrupts Martin Kepplinger
2022-07-26 8:32 ` [PATCH v6 1/2] power: domain: handle genpd correctly when needing interrupts Martin Kepplinger
2022-07-26 15:07 ` Ulf Hansson
2022-07-26 18:33 ` Rafael J. Wysocki
2022-07-28 9:19 ` Ulf Hansson
2022-08-19 9:17 ` Martin Kepplinger
2022-08-19 14:53 ` Ulf Hansson
2022-08-22 8:38 ` Martin Kepplinger
2022-08-24 13:30 ` Ulf Hansson
2022-08-25 7:06 ` Martin Kepplinger
2022-09-23 13:55 ` Ulf Hansson
2022-09-26 9:52 ` Martin Kepplinger
2023-06-21 18:20 ` Martin Kepplinger
2023-06-26 9:50 ` Ulf Hansson
2022-07-26 8:32 ` [PATCH v6 2/2] soc: imx: gpcv2: fix suspend/resume by setting GENPD_FLAG_IRQ_ON Martin Kepplinger
2022-07-26 15:08 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFrJjxm3Ljh0-oTGhOHRyg1+8xNkjDKE7+NE7mb_8C9dXQ@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=aford173@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@puri.sm \
--cc=khilman@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).