* [patch] mmc: mmc_test: Uninitialized return value
@ 2016-11-14 11:31 Dan Carpenter
2016-11-18 14:29 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-11-14 11:31 UTC (permalink / raw)
To: Ulf Hansson, Per Forlin
Cc: Adrian Hunter, Linus Walleij, Wolfram Sang, linux-mmc,
linux-kernel, kernel-janitors
We never set "ret" to RESULT_OK.
Fixes: 9f9c4180f88d ("mmc: mmc_test: add test for non-blocking transfers")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/mmc/card/mmc_test.c b/drivers/mmc/card/mmc_test.c
index f61c812..5ba6d77 100644
--- a/drivers/mmc/card/mmc_test.c
+++ b/drivers/mmc/card/mmc_test.c
@@ -832,7 +832,7 @@ static int mmc_test_nonblock_transfer(struct mmc_test_card *test,
struct mmc_async_req *other_areq = &test_areq[1].areq;
enum mmc_blk_status status;
int i;
- int ret;
+ int ret = RESULT_OK;
test_areq[0].test = test;
test_areq[1].test = test;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] mmc: mmc_test: Uninitialized return value
2016-11-14 11:31 [patch] mmc: mmc_test: Uninitialized return value Dan Carpenter
@ 2016-11-18 14:29 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2016-11-18 14:29 UTC (permalink / raw)
To: Dan Carpenter
Cc: Per Forlin, Adrian Hunter, Linus Walleij, Wolfram Sang,
linux-mmc, linux-kernel, kernel-janitors
On 14 November 2016 at 12:31, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We never set "ret" to RESULT_OK.
>
> Fixes: 9f9c4180f88d ("mmc: mmc_test: add test for non-blocking transfers")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied for next!
Kind regards
Uffe
>
> diff --git a/drivers/mmc/card/mmc_test.c b/drivers/mmc/card/mmc_test.c
> index f61c812..5ba6d77 100644
> --- a/drivers/mmc/card/mmc_test.c
> +++ b/drivers/mmc/card/mmc_test.c
> @@ -832,7 +832,7 @@ static int mmc_test_nonblock_transfer(struct mmc_test_card *test,
> struct mmc_async_req *other_areq = &test_areq[1].areq;
> enum mmc_blk_status status;
> int i;
> - int ret;
> + int ret = RESULT_OK;
>
> test_areq[0].test = test;
> test_areq[1].test = test;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-18 14:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-14 11:31 [patch] mmc: mmc_test: Uninitialized return value Dan Carpenter
2016-11-18 14:29 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).