linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* question about drivers/gpu/drm/drm_ioc32.c
@ 2012-01-28 19:28 Julia Lawall
  2012-01-30 10:16 ` Dave Airlie
  0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2012-01-28 19:28 UTC (permalink / raw)
  To: airlied, dri-devel, linux-kernel

In the function compat_drm_getclient, I have the impression that the 
structure c32 is copied to user level with the field idx uninitialized?

julia

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: question about drivers/gpu/drm/drm_ioc32.c
  2012-01-28 19:28 question about drivers/gpu/drm/drm_ioc32.c Julia Lawall
@ 2012-01-30 10:16 ` Dave Airlie
  2012-01-30 10:28   ` Julia Lawall
  0 siblings, 1 reply; 4+ messages in thread
From: Dave Airlie @ 2012-01-30 10:16 UTC (permalink / raw)
  To: Julia Lawall; +Cc: airlied, dri-devel, linux-kernel

On Sat, Jan 28, 2012 at 7:28 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> In the function compat_drm_getclient, I have the impression that the
> structure c32 is copied to user level with the field idx uninitialized?

Looks like it alright,

care to send a patch?

Dave.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: question about drivers/gpu/drm/drm_ioc32.c
  2012-01-30 10:16 ` Dave Airlie
@ 2012-01-30 10:28   ` Julia Lawall
  2012-01-30 11:33     ` devendra.aaru
  0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2012-01-30 10:28 UTC (permalink / raw)
  To: Dave Airlie; +Cc: Julia Lawall, airlied, dri-devel, linux-kernel

On Mon, 30 Jan 2012, Dave Airlie wrote:

> On Sat, Jan 28, 2012 at 7:28 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>> In the function compat_drm_getclient, I have the impression that the
>> structure c32 is copied to user level with the field idx uninitialized?
>
> Looks like it alright,
>
> care to send a patch?

What should it be initialized to?  The idx value that was got and put 
earlier?

thanks,
julia

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: question about drivers/gpu/drm/drm_ioc32.c
  2012-01-30 10:28   ` Julia Lawall
@ 2012-01-30 11:33     ` devendra.aaru
  0 siblings, 0 replies; 4+ messages in thread
From: devendra.aaru @ 2012-01-30 11:33 UTC (permalink / raw)
  To: Julia Lawall; +Cc: Dave Airlie, airlied, dri-devel, linux-kernel

On Mon, Jan 30, 2012 at 5:28 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> On Mon, 30 Jan 2012, Dave Airlie wrote:
>
>> On Sat, Jan 28, 2012 at 7:28 PM, Julia Lawall <julia.lawall@lip6.fr>
>> wrote:
>>>
>>> In the function compat_drm_getclient, I have the impression that the
>>> structure c32 is copied to user level with the field idx uninitialized?
>>
>>
>> Looks like it alright,
>>
>> care to send a patch?
>
>
> What should it be initialized to?  The idx value that was got and put
> earlier?
>
> thanks,
> julia
>
There was again a variable in drm_client32_t struct, idx which was
uninitialised.
c32.idx = idx is ok?

Thanks,
Dev.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-01-30 11:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-28 19:28 question about drivers/gpu/drm/drm_ioc32.c Julia Lawall
2012-01-30 10:16 ` Dave Airlie
2012-01-30 10:28   ` Julia Lawall
2012-01-30 11:33     ` devendra.aaru

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).