From: Enrico Granata <egranata@google.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
mst@redhat.com, jasowang@redhat.com, pbonzini@redhat.com,
axboe@kernel.dk, virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio_blk: Add support for lifetime feature
Date: Wed, 14 Apr 2021 14:12:18 -0600 [thread overview]
Message-ID: <CAPR809uOOsULgAA647=g+GTY32KbevqytsUfQACCfuuztqdSzg@mail.gmail.com> (raw)
In-Reply-To: <YHarc5gGgjyQOaA+@stefanha-x1.localdomain>
First and foremost thanks for the feedback on the code. I will send
out an up-to-date patch with those comments addressed ASAP
As for the broader issue, I am definitely happy to incorporate any
feedback and work to improve the spec, but looking at embedded storage
devices both eMMC and UFS seem to me to be exposing the attributes
that are included in the virtio-blk lifetime feature, and the same
data is also used by the Android Open Source Project for Health HAL.
It does seem like this format has a lot of practical adoption in the
wider industry and that makes it fairly trivial to implement in a lot
of common embedded systems. Having this immediate path to adoption in
a variety of scenarios seems to me in and of itself valuable.
Thanks,
- Enrico
On Wed, Apr 14, 2021 at 2:44 AM Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> On Mon, Apr 12, 2021 at 10:42:17AM +0100, Christoph Hellwig wrote:
> > A note to the virtio committee: eMMC is the worst of all the currently
> > active storage standards by a large margin. It defines very strange
> > ad-hoc interfaces that expose very specific internals and often provides
> > very poor abstractions. It would be great it you could reach out to the
> > wider storage community before taking bad ideas from the eMMC standard
> > and putting it into virtio.
>
> As Michael mentioned, there is still time to change the virtio-blk spec
> since this feature hasn't been released yet.
>
> Why exactly is exposing eMMC-style lifetime information problematic?
>
> Can you and Enrico discuss the use case to figure out an alternative
> interface?
>
> Thanks,
> Stefan
next prev parent reply other threads:[~2021-04-14 20:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 23:16 [PATCH] virtio_blk: Add support for lifetime feature Enrico Granata
2021-04-12 9:17 ` Stefan Hajnoczi
2021-04-12 9:42 ` Christoph Hellwig
2021-04-12 12:00 ` Michael S. Tsirkin
2021-04-15 15:54 ` Christoph Hellwig
2021-04-14 8:44 ` Stefan Hajnoczi
2021-04-14 20:12 ` Enrico Granata [this message]
2021-04-15 15:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPR809uOOsULgAA647=g+GTY32KbevqytsUfQACCfuuztqdSzg@mail.gmail.com' \
--to=egranata@google.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).