* [PATCH] staging: android: ashmem: used const keyword
@ 2020-07-28 17:59 Dhiraj Sharma
2020-07-28 18:04 ` Joe Perches
2020-07-28 18:25 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Dhiraj Sharma @ 2020-07-28 17:59 UTC (permalink / raw)
To: gregkh, arve, tkjos, maco, joel, christian, hridya, surenb
Cc: Dhiraj Sharma, devel, linux-kernel
I ran checkpatch.pl script which reported a warning to use const keyword
on line 370.Therefore I made this change.
Signed-off-by: Dhiraj Sharma <dhiraj.sharma0024@gmail.com>
---
drivers/staging/android/ashmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index c05a214191da..f9cfa15b785f 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
{
- static struct file_operations vmfile_fops;
+ static const struct file_operations vmfile_fops;
struct ashmem_area *asma = file->private_data;
int ret = 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: android: ashmem: used const keyword
2020-07-28 17:59 [PATCH] staging: android: ashmem: used const keyword Dhiraj Sharma
@ 2020-07-28 18:04 ` Joe Perches
2020-07-28 18:25 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Joe Perches @ 2020-07-28 18:04 UTC (permalink / raw)
To: Dhiraj Sharma, gregkh, arve, tkjos, maco, joel, christian,
hridya, surenb
Cc: devel, linux-kernel
On Tue, 2020-07-28 at 23:29 +0530, Dhiraj Sharma wrote:
> I ran checkpatch.pl script which reported a warning to use const keyword
> on line 370.Therefore I made this change.
checkpatch is a brainless script.
Not everything it suggests is appropriate.
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
[]
> @@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>
> static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
> {
> - static struct file_operations vmfile_fops;
> + static const struct file_operations vmfile_fops;
This can't work.
Please make sure to compile your proposed changes
_before_ you post them.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: android: ashmem: used const keyword
2020-07-28 17:59 [PATCH] staging: android: ashmem: used const keyword Dhiraj Sharma
2020-07-28 18:04 ` Joe Perches
@ 2020-07-28 18:25 ` Greg KH
2020-07-28 18:35 ` Dhiraj Sharma
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2020-07-28 18:25 UTC (permalink / raw)
To: Dhiraj Sharma
Cc: arve, tkjos, maco, joel, christian, hridya, surenb, devel, linux-kernel
On Tue, Jul 28, 2020 at 11:29:35PM +0530, Dhiraj Sharma wrote:
> I ran checkpatch.pl script which reported a warning to use const keyword
> on line 370.Therefore I made this change.
>
> Signed-off-by: Dhiraj Sharma <dhiraj.sharma0024@gmail.com>
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index c05a214191da..f9cfa15b785f 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>
> static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
> {
> - static struct file_operations vmfile_fops;
> + static const struct file_operations vmfile_fops;
You have now submitted two patches that you obviously never even built,
which is the first step in kernel development :(
Please be more careful next time.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: android: ashmem: used const keyword
2020-07-28 18:25 ` Greg KH
@ 2020-07-28 18:35 ` Dhiraj Sharma
0 siblings, 0 replies; 4+ messages in thread
From: Dhiraj Sharma @ 2020-07-28 18:35 UTC (permalink / raw)
To: Greg KH
Cc: arve, tkjos, maco, joel, christian, Hridya Valsaraju,
Suren Baghdasaryan, devel, linux-kernel
Alright, I have understood now that I should not trust on
checkpatch.pl script fully but partially it is indeed helpful. Please
don't criticize this script, it was my fault instead.
Before submitting code changes I would test them all, sorry for
wasting your time please ignore this patch changes now.
I will not commit such foolish mistakes now.
Thank you
Dhiraj Sharma
On Tue, Jul 28, 2020 at 11:55 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Jul 28, 2020 at 11:29:35PM +0530, Dhiraj Sharma wrote:
> > I ran checkpatch.pl script which reported a warning to use const keyword
> > on line 370.Therefore I made this change.
> >
> > Signed-off-by: Dhiraj Sharma <dhiraj.sharma0024@gmail.com>
> > ---
> > drivers/staging/android/ashmem.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> > index c05a214191da..f9cfa15b785f 100644
> > --- a/drivers/staging/android/ashmem.c
> > +++ b/drivers/staging/android/ashmem.c
> > @@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
> >
> > static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
> > {
> > - static struct file_operations vmfile_fops;
> > + static const struct file_operations vmfile_fops;
>
> You have now submitted two patches that you obviously never even built,
> which is the first step in kernel development :(
>
> Please be more careful next time.
>
> greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-28 18:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 17:59 [PATCH] staging: android: ashmem: used const keyword Dhiraj Sharma
2020-07-28 18:04 ` Joe Perches
2020-07-28 18:25 ` Greg KH
2020-07-28 18:35 ` Dhiraj Sharma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).