* [PATCH] usb: typec: tcpm: Ignore Vsafe0v in PR_SWAP_SNK_SRC_SOURCE_ON state
@ 2021-06-15 17:32 Kyle Tso
2021-06-15 17:45 ` Badhri Jagan Sridharan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kyle Tso @ 2021-06-15 17:32 UTC (permalink / raw)
To: linux, heikki.krogerus, gregkh; +Cc: badhri, linux-usb, linux-kernel, Kyle Tso
In PR_SWAP_SNK_SRC_SOURCE_ON state, Vsafe0v is expected as well so do
nothing here to avoid state machine going into SNK_UNATTACHED.
Fixes: 28b43d3d746b ("usb: typec: tcpm: Introduce vsafe0v for vbus")
Signed-off-by: Kyle Tso <kyletso@google.com>
---
drivers/usb/typec/tcpm/tcpm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index 197556038ba4..e11e9227107d 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -5212,6 +5212,7 @@ static void _tcpm_pd_vbus_vsafe0v(struct tcpm_port *port)
}
break;
case PR_SWAP_SNK_SRC_SINK_OFF:
+ case PR_SWAP_SNK_SRC_SOURCE_ON:
/* Do nothing, vsafe0v is expected during transition */
break;
default:
--
2.32.0.272.g935e593368-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] usb: typec: tcpm: Ignore Vsafe0v in PR_SWAP_SNK_SRC_SOURCE_ON state
2021-06-15 17:32 [PATCH] usb: typec: tcpm: Ignore Vsafe0v in PR_SWAP_SNK_SRC_SOURCE_ON state Kyle Tso
@ 2021-06-15 17:45 ` Badhri Jagan Sridharan
2021-06-15 21:39 ` Guenter Roeck
2021-06-16 13:41 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Badhri Jagan Sridharan @ 2021-06-15 17:45 UTC (permalink / raw)
To: Kyle Tso; +Cc: Guenter Roeck, Heikki Krogerus, Greg Kroah-Hartman, USB, LKML
On Tue, Jun 15, 2021 at 10:32 AM Kyle Tso <kyletso@google.com> wrote:
>
> In PR_SWAP_SNK_SRC_SOURCE_ON state, Vsafe0v is expected as well so do
> nothing here to avoid state machine going into SNK_UNATTACHED.
>
> Fixes: 28b43d3d746b ("usb: typec: tcpm: Introduce vsafe0v for vbus")
> Signed-off-by: Kyle Tso <kyletso@google.com>
Reviewed-by: Badhri Jagan Sridharan <badhri@google.com>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 197556038ba4..e11e9227107d 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -5212,6 +5212,7 @@ static void _tcpm_pd_vbus_vsafe0v(struct tcpm_port *port)
> }
> break;
> case PR_SWAP_SNK_SRC_SINK_OFF:
> + case PR_SWAP_SNK_SRC_SOURCE_ON:
> /* Do nothing, vsafe0v is expected during transition */
> break;
> default:
> --
> 2.32.0.272.g935e593368-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] usb: typec: tcpm: Ignore Vsafe0v in PR_SWAP_SNK_SRC_SOURCE_ON state
2021-06-15 17:32 [PATCH] usb: typec: tcpm: Ignore Vsafe0v in PR_SWAP_SNK_SRC_SOURCE_ON state Kyle Tso
2021-06-15 17:45 ` Badhri Jagan Sridharan
@ 2021-06-15 21:39 ` Guenter Roeck
2021-06-16 13:41 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2021-06-15 21:39 UTC (permalink / raw)
To: Kyle Tso; +Cc: heikki.krogerus, gregkh, badhri, linux-usb, linux-kernel
On Wed, Jun 16, 2021 at 01:32:06AM +0800, Kyle Tso wrote:
> In PR_SWAP_SNK_SRC_SOURCE_ON state, Vsafe0v is expected as well so do
> nothing here to avoid state machine going into SNK_UNATTACHED.
>
> Fixes: 28b43d3d746b ("usb: typec: tcpm: Introduce vsafe0v for vbus")
> Signed-off-by: Kyle Tso <kyletso@google.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 197556038ba4..e11e9227107d 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -5212,6 +5212,7 @@ static void _tcpm_pd_vbus_vsafe0v(struct tcpm_port *port)
> }
> break;
> case PR_SWAP_SNK_SRC_SINK_OFF:
> + case PR_SWAP_SNK_SRC_SOURCE_ON:
> /* Do nothing, vsafe0v is expected during transition */
> break;
> default:
> --
> 2.32.0.272.g935e593368-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] usb: typec: tcpm: Ignore Vsafe0v in PR_SWAP_SNK_SRC_SOURCE_ON state
2021-06-15 17:32 [PATCH] usb: typec: tcpm: Ignore Vsafe0v in PR_SWAP_SNK_SRC_SOURCE_ON state Kyle Tso
2021-06-15 17:45 ` Badhri Jagan Sridharan
2021-06-15 21:39 ` Guenter Roeck
@ 2021-06-16 13:41 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Heikki Krogerus @ 2021-06-16 13:41 UTC (permalink / raw)
To: Kyle Tso; +Cc: linux, gregkh, badhri, linux-usb, linux-kernel
On Wed, Jun 16, 2021 at 01:32:06AM +0800, Kyle Tso wrote:
> In PR_SWAP_SNK_SRC_SOURCE_ON state, Vsafe0v is expected as well so do
> nothing here to avoid state machine going into SNK_UNATTACHED.
>
> Fixes: 28b43d3d746b ("usb: typec: tcpm: Introduce vsafe0v for vbus")
> Signed-off-by: Kyle Tso <kyletso@google.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 197556038ba4..e11e9227107d 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -5212,6 +5212,7 @@ static void _tcpm_pd_vbus_vsafe0v(struct tcpm_port *port)
> }
> break;
> case PR_SWAP_SNK_SRC_SINK_OFF:
> + case PR_SWAP_SNK_SRC_SOURCE_ON:
> /* Do nothing, vsafe0v is expected during transition */
> break;
> default:
> --
> 2.32.0.272.g935e593368-goog
--
heikki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-16 13:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-15 17:32 [PATCH] usb: typec: tcpm: Ignore Vsafe0v in PR_SWAP_SNK_SRC_SOURCE_ON state Kyle Tso
2021-06-15 17:45 ` Badhri Jagan Sridharan
2021-06-15 21:39 ` Guenter Roeck
2021-06-16 13:41 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).