From: Badhri Jagan Sridharan <badhri@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Guenter Roeck <linux@roeck-us.net>,
Oliver Neukum <oneukum@suse.com>, USB <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv4] usb: typec: Add a sysfs node to manage port type
Date: Sat, 27 May 2017 13:34:43 -0700 [thread overview]
Message-ID: <CAPTae5Lmwi5qa=RUym+hr_gh2R=OX1VuBQ9XXAJ9xVAH+Hjp5g@mail.gmail.com> (raw)
In-Reply-To: <20170527054330.GB28555@kroah.com>
On Fri, May 26, 2017 at 10:43 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Fri, May 26, 2017 at 01:42:57PM -0700, Badhri Jagan Sridharan wrote:
>> User space applications in some cases have the need to enforce a
>> specific port type(DFP/UFP/DRP). This change allows userspace to
>> attempt setting the desired port type. Low level drivers can
>> however reject the request if the specific port type is not supported.
>>
>> Signed-off-by: Badhri Jagan Sridharan <Badhri@google.com>
>> ---
>> Changelog since v1:
>> - introduced a new variable port_type in struct typec_port to track
>> the current port type instead of changing type member in
>> typec_capability to address Heikki Krogerus comments.
>> - changed the output format and strings that would be displayed as
>> suggested by Heikki Krogerus.
>>
>> Changelog since v2:
>> - introduced a new mutex lock to protect port_type for addressing
>> the race conditions identified by Geunter Roeck
>> - added typec_port_types_drp for printing port_type when cap->type
>> is TYPE_PORT_DRP as suggested by Geunter Roeck
>> - Power role swap and data role swaps would be rejected unless
>> port port_type == TYPE_PORT_DRP
>> - port_type_store would return immediately if the current port_type
>> is same as the new port_type as suggested by Geunter Roeck
>>
>> Changelog since v3:
>> - Moved as much as code outside port_type_lock as suggested by
>> Geunter Roeck
>> - Removed Change-Id line from commit message identified by
>> Greg Kroah-Hartman
>
> Ok, this is how you write a changelog for a patch, very nice job!
Thanks Greg :)
>
> greg k-h
prev parent reply other threads:[~2017-05-27 20:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 20:42 [PATCHv4] usb: typec: Add a sysfs node to manage port type Badhri Jagan Sridharan
2017-05-27 5:43 ` Greg Kroah-Hartman
2017-05-27 20:34 ` Badhri Jagan Sridharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPTae5Lmwi5qa=RUym+hr_gh2R=OX1VuBQ9XXAJ9xVAH+Hjp5g@mail.gmail.com' \
--to=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).