linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Blake Jones <blakejones@google.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <olsajiri@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Add a "-m" option to "perf buildid-list".
Date: Mon, 18 Jul 2022 13:22:50 -0700	[thread overview]
Message-ID: <CAP_z_CgPPg7o1TYyQ0b9MtEO17X-69Te3zOfocXK2MYc-SmPmA@mail.gmail.com> (raw)
In-Reply-To: <YtW1aFY4MyeqxhdH@kernel.org>

Ah yeah of course, sorry about that!


On Mon, Jul 18, 2022 at 12:33 PM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Mon, Jul 18, 2022 at 10:07:32AM -0700, Blake Jones escreveu:
> > Fabulous, thanks!
> >
> > On Mon, Jul 18, 2022 at 7:51 AM Arnaldo Carvalho de Melo <acme@kernel.org>
> > wrote:
> > > > > Signed-off-by: Blake Jones <blakejones@google.com>
> > > >
> > > > Acked-by: Jiri Olsa <jolsa@kernel.org>
> > >
> > > To clarify, b4 found v3 and that was the one applied.
>
> Now fixing this:
>
>   28     5.28 debian:experimental-x-mips    : FAIL gcc version 11.2.0 (Debian 11.2.0-18)
>     builtin-buildid-list.c: In function 'buildid__map_cb':
>     builtin-buildid-list.c:32:24: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'u64' {aka 'long long unsigned int'} [-Werror=format=]
>        32 |         printf("%s %16lx %16lx", bid_buf, map->start, map->end);
>           |                    ~~~~^                  ~~~~~~~~~~
>           |                        |                     |
>           |                        long unsigned int     u64 {aka long long unsigned int}
>           |                    %16llx
>     builtin-buildid-list.c:32:30: error: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'u64' {aka 'long long unsigned int'} [-Werror=format=]
>        32 |         printf("%s %16lx %16lx", bid_buf, map->start, map->end);
>           |                          ~~~~^                        ~~~~~~~~
>           |                              |                           |
>           |                              long unsigned int           u64 {aka long long unsigned int}
>           |                          %16llx
>     cc1: all warnings being treated as errors
>   29    23.06 debian:experimental-x-mips64  : Ok   mips64-linux-gnuabi64-gcc (Debian 10.2.1-6) 10.2.1 20210110
>   30     6.08 debian:experimental-x-mipsel  : FAIL gcc version 11.2.0 (Debian 11.2.0-18)
>     builtin-buildid-list.c: In function 'buildid__map_cb':
>     builtin-buildid-list.c:32:24: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'u64' {aka 'long long unsigned int'} [-Werror=format=]
>        32 |         printf("%s %16lx %16lx", bid_buf, map->start, map->end);
>           |                    ~~~~^                  ~~~~~~~~~~
>           |                        |                     |
>           |                        long unsigned int     u64 {aka long long unsigned int}
>           |                    %16llx
>     builtin-buildid-list.c:32:30: error: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'u64' {aka 'long long unsigned int'} [-Werror=format=]
>        32 |         printf("%s %16lx %16lx", bid_buf, map->start, map->end);
>           |                          ~~~~^                        ~~~~~~~~
>           |                              |                           |
>           |                              long unsigned int           u64 {aka long long unsigned int}
>           |                          %16llx
>     cc1: all warnings being treated as errors
>
>
> These should use PRIx64, etc.
>
> - Arnaldo

      reply	other threads:[~2022-07-18 20:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29 21:36 [PATCH v3] Add a "-m" option to "perf buildid-list" Blake Jones
2022-07-01  8:23 ` Jiri Olsa
2022-07-18 14:51   ` Arnaldo Carvalho de Melo
     [not found]     ` <CAP_z_CjUi-Uk_mftfw33+eac13sLyHMBtQJd8V393SaD4OocNg@mail.gmail.com>
2022-07-18 19:32       ` Arnaldo Carvalho de Melo
2022-07-18 20:22         ` Blake Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP_z_CgPPg7o1TYyQ0b9MtEO17X-69Te3zOfocXK2MYc-SmPmA@mail.gmail.com \
    --to=blakejones@google.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=olsajiri@gmail.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).