* [PATCH] drm/virtio: ratelimit error logging
@ 2020-02-05 10:25 Gerd Hoffmann
2020-02-05 20:20 ` Chia-I Wu
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2020-02-05 10:25 UTC (permalink / raw)
To: dri-devel
Cc: gurchetansingh, olvaffe, Gerd Hoffmann, David Airlie,
Daniel Vetter, open list:VIRTIO GPU DRIVER, open list
Avoid flooding the log in case we screw up badly.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
drivers/gpu/drm/virtio/virtgpu_vq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
index 5914e79d3429..83f22933c3bb 100644
--- a/drivers/gpu/drm/virtio/virtgpu_vq.c
+++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
@@ -212,9 +212,9 @@ void virtio_gpu_dequeue_ctrl_func(struct work_struct *work)
if (resp->type >= cpu_to_le32(VIRTIO_GPU_RESP_ERR_UNSPEC)) {
struct virtio_gpu_ctrl_hdr *cmd;
cmd = (struct virtio_gpu_ctrl_hdr *)entry->buf;
- DRM_ERROR("response 0x%x (command 0x%x)\n",
- le32_to_cpu(resp->type),
- le32_to_cpu(cmd->type));
+ DRM_ERROR_RATELIMITED("response 0x%x (command 0x%x)\n",
+ le32_to_cpu(resp->type),
+ le32_to_cpu(cmd->type));
} else
DRM_DEBUG("response 0x%x\n", le32_to_cpu(resp->type));
}
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/virtio: ratelimit error logging
2020-02-05 10:25 [PATCH] drm/virtio: ratelimit error logging Gerd Hoffmann
@ 2020-02-05 20:20 ` Chia-I Wu
0 siblings, 0 replies; 2+ messages in thread
From: Chia-I Wu @ 2020-02-05 20:20 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: ML dri-devel, Gurchetan Singh, David Airlie, Daniel Vetter,
open list:VIRTIO GPU DRIVER, open list
On Wed, Feb 5, 2020 at 2:26 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Avoid flooding the log in case we screw up badly.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Chia-I Wu <olvaffe@gmail.com>
> ---
> drivers/gpu/drm/virtio/virtgpu_vq.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
> index 5914e79d3429..83f22933c3bb 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_vq.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
> @@ -212,9 +212,9 @@ void virtio_gpu_dequeue_ctrl_func(struct work_struct *work)
> if (resp->type >= cpu_to_le32(VIRTIO_GPU_RESP_ERR_UNSPEC)) {
> struct virtio_gpu_ctrl_hdr *cmd;
> cmd = (struct virtio_gpu_ctrl_hdr *)entry->buf;
> - DRM_ERROR("response 0x%x (command 0x%x)\n",
> - le32_to_cpu(resp->type),
> - le32_to_cpu(cmd->type));
> + DRM_ERROR_RATELIMITED("response 0x%x (command 0x%x)\n",
> + le32_to_cpu(resp->type),
> + le32_to_cpu(cmd->type));
> } else
> DRM_DEBUG("response 0x%x\n", le32_to_cpu(resp->type));
> }
> --
> 2.18.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-05 20:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-05 10:25 [PATCH] drm/virtio: ratelimit error logging Gerd Hoffmann
2020-02-05 20:20 ` Chia-I Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).