Re: [Linux-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices

[Dan Williams <dan.j.williams@intel.com>]

On Wed, Apr 22, 2015 at 12:12 PM, Elliott, Robert (Server Storage)
<Elliott@hp.com> wrote:
>> -----Original Message-----
>> From: Linux-nvdimm [mailto:linux-nvdimm-bounces@lists.01.org] On Behalf Of
>> Dan Williams
>> Sent: Friday, April 17, 2015 8:37 PM
>> To: linux-nvdimm@lists.01.org
>> Subject: [Linux-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices
>>
> ...
>> +/*
>> + * btt_sb_checksum: compute checksum for btt info block
>> + *
>> + * Returns a fletcher64 checksum of everything in the given info block
>> + * except the last field (since that's where the checksum lives).
>> + */
>> +u64 btt_sb_checksum(struct btt_sb *btt_sb)
>> +{
>> +     u64 sum, sum_save;
>> +
>> +     sum_save = btt_sb->checksum;
>> +     btt_sb->checksum = 0;
>> +     sum = nd_fletcher64(btt_sb, sizeof(*btt_sb));
>> +     btt_sb->checksum = sum_save;
>> +     return sum;
>> +}
>> +EXPORT_SYMBOL(btt_sb_checksum);
> ...
>
> Of all the functions with prototypes in nd.h, this is the only
> function that doesn't have a name starting with nd_.
>
> Following such a convention helps ease setting up ftrace filters.

Sure, I'll fix that up.