From: Dan Williams <dan.j.williams@intel.com>
To: Toshi Kani <toshi.kani@hp.com>
Cc: Linda Knippers <linda.knippers@hp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>
Subject: Re: [Linux-nvdimm] [PATCH 04/21] nd: create an 'nd_bus' from an 'nfit_desc'
Date: Wed, 22 Apr 2015 13:00:02 -0700 [thread overview]
Message-ID: <CAPcyv4i4JOpDbOpL9FGEAtm_z-J4L0w_htRu5BsCrHY+p5-y2g@mail.gmail.com> (raw)
In-Reply-To: <1429731538.16996.32.camel@misato.fc.hp.com>
On Wed, Apr 22, 2015 at 12:38 PM, Toshi Kani <toshi.kani@hp.com> wrote:
> On Wed, 2015-04-22 at 12:28 -0700, Dan Williams wrote:
>> On Wed, Apr 22, 2015 at 11:23 AM, Toshi Kani <toshi.kani@hp.com> wrote:
>> > On Wed, 2015-04-22 at 11:20 -0700, Dan Williams wrote:
>> >> On Wed, Apr 22, 2015 at 11:00 AM, Linda Knippers <linda.knippers@hp.com> wrote:
>> >> Wait, point of clarification, DCRs (dimm-control-regions) have RFICs,
>> >> not MEMDEVs (memory-device-to-spa-mapping). Toshi's original report
>> >> was that an NFIT with a SPA+MEMDEV was failing to enable a PMEM
>> >> device. That specific problem can be fixed by either deleting the
>> >> MEMDEV, or adding a DCR.
>> >
>> > By a DCR, do you mean a DCR structure or SPA with Control Region GUID?
>>
>> Hmm, I meant a DCR as defined below. I agree you would not need a "SPA-DCR".
>>
>> > Adding a DCR structure does not solve this issue since it requires SPA
>> > with Control Region GUID, which battery-backed DIMMs do not have.
>>
>> I would not go that far, half of a DCR entry is relevant for any
>> NVDIMM, and half is only relevant if a DIMM offers BLK access:
>>
>> struct acpi_nfit_dcr {
>> u16 type;
>> u16 length;
>> u16 dcr_index;
>> u16 vendor_id;
>> u16 device_id;
>> u16 revision_id;
>> u16 sub_vendor_id;
>> u16 sub_device_id;
>> u16 sub_revision_id;
>> u8 reserved[6];
>> u32 serial_number;
>> u16 fic;
>> <<<<< BLK relevant fields start here <<<<<
>> u16 num_bcw;
>> u64 bcw_size;
>> u64 cmd_offset;
>> u64 cmd_size;
>> u64 status_offset;
>> u64 status_size;
>> u16 flags;
>> u8 reserved2[6];
>> };
>
> Yes, we do have a DCR entry. But we do not have a SPA-DCR.
Got it. will fix.
next prev parent reply other threads:[~2015-04-22 20:00 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 1:35 [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem Dan Williams
2015-04-18 1:35 ` [PATCH 01/21] e820, efi: add ACPI 6.0 persistent memory types Dan Williams
2015-04-18 4:41 ` Andy Lutomirski
2015-04-19 7:46 ` Boaz Harrosh
2015-04-20 17:08 ` Dan Williams
2015-04-28 12:46 ` [Linux-nvdimm] " Christoph Hellwig
2015-04-28 19:20 ` Dan Williams
2015-04-18 1:35 ` [PATCH 02/21] ND NFIT-Defined/NVIDIMM Subsystem Dan Williams
2015-04-20 7:06 ` Ingo Molnar
2015-04-20 8:14 ` Dan Williams
2015-04-20 12:53 ` Christoph Hellwig
2015-04-20 15:57 ` Dan Williams
2015-04-21 13:38 ` Dan Williams
2015-04-28 12:48 ` [Linux-nvdimm] " Christoph Hellwig
2015-04-18 1:35 ` [PATCH 03/21] nd_acpi: initial core implementation and nfit skeleton Dan Williams
2015-04-18 19:41 ` Paul Bolle
2015-04-19 19:12 ` Rafael J. Wysocki
2015-04-28 12:53 ` [Linux-nvdimm] " Christoph Hellwig
2015-04-28 19:21 ` Dan Williams
2015-04-18 1:35 ` [PATCH 04/21] nd: create an 'nd_bus' from an 'nfit_desc' Dan Williams
2015-04-21 19:35 ` [Linux-nvdimm] " Toshi Kani
2015-04-21 19:58 ` Dan Williams
2015-04-21 19:55 ` Toshi Kani
2015-04-21 20:35 ` Dan Williams
2015-04-21 20:32 ` Toshi Kani
2015-04-22 16:39 ` Toshi Kani
2015-04-22 17:03 ` Dan Williams
2015-04-22 18:00 ` Linda Knippers
2015-04-22 18:20 ` Dan Williams
2015-04-22 18:23 ` Toshi Kani
2015-04-22 19:28 ` Dan Williams
2015-04-22 19:38 ` Toshi Kani
2015-04-22 20:00 ` Dan Williams [this message]
2015-04-28 16:47 ` Toshi Kani
2015-04-28 17:14 ` Toshi Kani
2015-04-18 1:35 ` [PATCH 05/21] nfit-test: manufactured NFITs for interface development Dan Williams
2015-04-24 21:47 ` [Linux-nvdimm] " Linda Knippers
2015-04-24 21:50 ` Dan Williams
2015-04-24 21:59 ` Linda Knippers
2015-04-24 23:02 ` Dan Williams
2015-04-28 12:54 ` Christoph Hellwig
2015-04-28 19:35 ` Dan Williams
2015-04-18 1:35 ` [PATCH 06/21] nd: ndctl class device, and nd bus attributes Dan Williams
2015-04-18 8:07 ` Greg KH
2015-04-18 20:08 ` Dan Williams
2015-04-18 1:35 ` [PATCH 07/21] nd: dimm devices (nfit "memory-devices") Dan Williams
2015-04-18 8:06 ` Greg KH
2015-04-18 20:12 ` Dan Williams
2015-04-18 1:35 ` [PATCH 08/21] nd: ndctl.h, the nd ioctl abi Dan Williams
2015-04-21 21:20 ` [Linux-nvdimm] " Toshi Kani
2015-04-21 22:05 ` Dan Williams
2015-04-21 22:16 ` Toshi Kani
2015-04-24 15:56 ` Toshi Kani
2015-04-24 16:09 ` Toshi Kani
2015-04-24 16:31 ` Dan Williams
2015-04-24 16:25 ` Dan Williams
2015-04-24 17:18 ` Toshi Kani
2015-04-24 17:45 ` Dan Williams
2015-04-25 0:35 ` Toshi Kani
2015-04-18 1:36 ` [PATCH 09/21] nd_dimm: dimm driver and base nd-bus device-driver infrastructure Dan Williams
2015-04-18 1:36 ` [PATCH 10/21] nd: regions (block-data-window, persistent memory, volatile memory) Dan Williams
2015-04-18 1:36 ` [PATCH 11/21] nd_region: support for legacy nvdimms Dan Williams
2015-04-18 1:36 ` [PATCH 12/21] nd_pmem: add NFIT support to the pmem driver Dan Williams
2015-04-18 6:38 ` Christoph Hellwig
2015-04-18 19:37 ` Dan Williams
2015-04-28 12:56 ` [Linux-nvdimm] " Christoph Hellwig
2015-04-28 19:37 ` Dan Williams
2015-04-18 1:36 ` [PATCH 13/21] nd: add interleave-set state-tracking infrastructure Dan Williams
2015-04-18 1:36 ` [PATCH 14/21] nd: namespace indices: read and validate Dan Williams
2015-04-18 1:36 ` [PATCH 15/21] nd: pmem label sets and namespace instantiation Dan Williams
2015-04-18 1:36 ` [PATCH 16/21] nd: blk labels " Dan Williams
2015-04-18 1:36 ` [PATCH 17/21] nd: write pmem label set Dan Williams
2015-04-18 1:36 ` [PATCH 18/21] nd: write blk " Dan Williams
2015-04-18 1:36 ` [PATCH 19/21] nd: infrastructure for btt devices Dan Williams
2015-04-22 19:12 ` [Linux-nvdimm] " Elliott, Robert (Server Storage)
2015-04-22 19:39 ` Dan Williams
2015-04-28 13:01 ` Christoph Hellwig
2015-04-28 15:42 ` Matthew Wilcox
2015-04-18 1:37 ` [PATCH 20/21] nd_btt: atomic sector updates Dan Williams
2015-04-18 1:37 ` [PATCH 21/21] nd_blk: nfit blk driver Dan Williams
2015-04-18 19:29 ` [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem Dan Williams
2015-04-22 19:06 ` [Linux-nvdimm] " Elliott, Robert (Server Storage)
2015-04-22 19:39 ` Dan Williams
2015-04-23 5:43 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4i4JOpDbOpL9FGEAtm_z-J4L0w_htRu5BsCrHY+p5-y2g@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=linda.knippers@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=toshi.kani@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).